URL: https://github.com/SSSD/sssd/pull/92 Author: lslebodn Title: #92: UTIL: Fix compilation of sss_utf8 with libunistring Action: opened
PR body: """ The internal header file "util/util.h" was removed from sss_utf8.h as part of commit de5fa34860886ad68fba5e739987e16c342e8f14. It was neccessary to ensure libipa_hbac can be build with C90 compatible compiler.
This header file includes many system header file and after this change caused missing declaration of the function free()
src/util/sss_utf8.c: In function ‘sss_utf8_free’: src/util/sss_utf8.c:40:12: error: implicit declaration of function ‘free’ [-Werror=implicit-function-declaration] return free(ptr); ^~~~ src/util/sss_utf8.c:40:12: warning: incompatible implicit declaration of built-in function ‘free’ src/util/sss_utf8.c:40:12: note: include ‘<stdlib.h>’ or provide a declaration of ‘free’ cc1: some warnings being treated as errors """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/92/head:pr92 git checkout pr92
URL: https://github.com/SSSD/sssd/pull/92 Title: #92: UTIL: Fix compilation of sss_utf8 with libunistring
fidencio commented: """ Please, include some info in the commit message about how the breakage was noticed. Is this part of the "Fixing SSSD build on FreeBSD"? Was this found using some "non-usual" configure option?
Also, the whole series about "Fixing SSSD build on FreeBSD" could have been sent together instead of one patch per PR. """
See the full comment at https://github.com/SSSD/sssd/pull/92#issuecomment-262854746
URL: https://github.com/SSSD/sssd/pull/92 Title: #92: UTIL: Fix compilation of sss_utf8 with libunistring
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/92 Title: #92: UTIL: Fix compilation of sss_utf8 with libunistring
lslebodn commented: """ On (24/11/16 15:14), fidencio wrote:
Please, include some info in the commit message about how the breakage was noticed. Is this part of the "Fixing SSSD build on FreeBSD"? Was this found using some "non-usual" configure option?
If you had read description of ticket properly then you would have noticed it's not BSD realted.
Also, the whole series about "Fixing SSSD build on FreeBSD" could have been sent together instead of one patch per PR.
BTW I do not see a reason for one FreeBSD patch set. They are all independent fixes with different root cause. or should we create series "Fixing SSSD with Active Directory" This request does not make any sense too me.
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/92#issuecomment-262913463
URL: https://github.com/SSSD/sssd/pull/92 Title: #92: UTIL: Fix compilation of sss_utf8 with libunistring
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/92 Title: #92: UTIL: Fix compilation of sss_utf8 with libunistring
fidencio commented: """ On Fri, Nov 25, 2016 at 10:20 AM, lslebodn notifications@github.com wrote:
On (24/11/16 15:14), fidencio wrote:
Please, include some info in the commit message about how the breakage
was noticed.
Is this part of the "Fixing SSSD build on FreeBSD"? Was this found using
some "non-usual" configure option?
If you had read description of ticket properly then you would have noticed it's not BSD realted.
This comment was really unnecessary, at least in the way it's been written. It's really far from being polite. A suggestion of a similar answer would be: "Try building your code passing '--with-unicode-lib=libunistring' to the configure."
Anyways, Acked-by: Fabiano Fidêncio fidencio@redhat.com
Also, the whole series about "Fixing SSSD build on FreeBSD" could have
been sent together instead of one patch per PR.
BTW I do not see a reason for one FreeBSD patch set. They are all independent fixes with different root cause. or should we create series "Fixing SSSD with Active Directory" This request does not make any sense too me.
LS
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SSSD/sssd/pull/92#issuecomment-262913463, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG4eqnfJADQ4VoWqbCabMf5IQJixuxJks5rBqhsgaJpZM4K7rm4 .
"""
See the full comment at https://github.com/SSSD/sssd/pull/92#issuecomment-262918912
URL: https://github.com/SSSD/sssd/pull/92 Title: #92: UTIL: Fix compilation of sss_utf8 with libunistring
lslebodn commented: """ On (25/11/16 01:49), fidencio wrote:
On Fri, Nov 25, 2016 at 10:20 AM, lslebodn notifications@github.com wrote:
On (24/11/16 15:14), fidencio wrote:
Please, include some info in the commit message about how the breakage
was noticed.
Is this part of the "Fixing SSSD build on FreeBSD"? Was this found using
some "non-usual" configure option?
If you had read description of ticket properly then you would have noticed it's not BSD realted.
This comment was really unnecessary, at least in the way it's been written. It's really far from being polite. A suggestion of a similar answer would be: "Try building your code passing '--with-unicode-lib=libunistring' to the configure."
That is a reduntand version of commit mesasge "Fix compilation of sss_utf8 with libunistring"
Anyways, Thank you for review.
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/92#issuecomment-262936474
URL: https://github.com/SSSD/sssd/pull/92 Title: #92: UTIL: Fix compilation of sss_utf8 with libunistring
lslebodn commented: """ master: * c101cb130df0705a9227dadce22554307eee54db
sssd-1-14: * 76e2df701559d8723ea632722c94c8dfb820fc93
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/92#issuecomment-262943081
URL: https://github.com/SSSD/sssd/pull/92 Author: lslebodn Title: #92: UTIL: Fix compilation of sss_utf8 with libunistring Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/92/head:pr92 git checkout pr92
URL: https://github.com/SSSD/sssd/pull/92 Title: #92: UTIL: Fix compilation of sss_utf8 with libunistring
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
fidencio