Hi,
attached are some small patches and most importantly unit tests I wrote recently when patching the child_common.c module.
Please note that these patches shouldn't be applied until we split off the master branch from 1.12, but if I don't send them out before the Christmas break I'll forget completely :-)
On 12/11/2014 12:01 PM, Jakub Hrozek wrote:
Hi,
attached are some small patches and most importantly unit tests I wrote recently when patching the child_common.c module.
Please note that these patches shouldn't be applied until we split off the master branch from 1.12, but if I don't send them out before the Christmas break I'll forget completely :-)
Patch #1: ACK Patch #2: ACK Although, can you put the change that makes sss_child_handler static in a separate commit as well? It doesn't seem to belong here.
Patch #3: ACK Patch #4: ACK Patch #5: ACK
On Tue, Jan 06, 2015 at 01:38:21PM +0100, Pavel Březina wrote:
On 12/11/2014 12:01 PM, Jakub Hrozek wrote:
Hi,
attached are some small patches and most importantly unit tests I wrote recently when patching the child_common.c module.
Please note that these patches shouldn't be applied until we split off the master branch from 1.12, but if I don't send them out before the Christmas break I'll forget completely :-)
Patch #1: ACK Patch #2: ACK Although, can you put the change that makes sss_child_handler static in a separate commit as well? It doesn't seem to belong here.
Patch #3: ACK Patch #4: ACK Patch #5: ACK
Thanks for the review. I rebased the patches atop the current master, added a test for the custom FD used for output and moved sss_child_handler() to the first patch -- it seemed excessive to me to have two patches just to make two functions static.
On 01/13/2015 10:08 PM, Jakub Hrozek wrote:
On Tue, Jan 06, 2015 at 01:38:21PM +0100, Pavel Březina wrote:
On 12/11/2014 12:01 PM, Jakub Hrozek wrote:
Hi,
attached are some small patches and most importantly unit tests I wrote recently when patching the child_common.c module.
Please note that these patches shouldn't be applied until we split off the master branch from 1.12, but if I don't send them out before the Christmas break I'll forget completely :-)
Patch #1: ACK Patch #2: ACK Although, can you put the change that makes sss_child_handler static in a separate commit as well? It doesn't seem to belong here.
Patch #3: ACK Patch #4: ACK Patch #5: ACK
Thanks for the review. I rebased the patches atop the current master, added a test for the custom FD used for output and moved sss_child_handler() to the first patch -- it seemed excessive to me to have two patches just to make two functions static.
Ack to all. Good job on those unit tests.
On Wed, Jan 14, 2015 at 09:39:12PM +0100, Pavel Březina wrote:
On 01/13/2015 10:08 PM, Jakub Hrozek wrote:
On Tue, Jan 06, 2015 at 01:38:21PM +0100, Pavel Březina wrote:
On 12/11/2014 12:01 PM, Jakub Hrozek wrote:
Hi,
attached are some small patches and most importantly unit tests I wrote recently when patching the child_common.c module.
Please note that these patches shouldn't be applied until we split off the master branch from 1.12, but if I don't send them out before the Christmas break I'll forget completely :-)
Patch #1: ACK Patch #2: ACK Although, can you put the change that makes sss_child_handler static in a separate commit as well? It doesn't seem to belong here.
Patch #3: ACK Patch #4: ACK Patch #5: ACK
Thanks for the review. I rebased the patches atop the current master, added a test for the custom FD used for output and moved sss_child_handler() to the first patch -- it seemed excessive to me to have two patches just to make two functions static.
Ack to all. Good job on those unit tests.
CI: http://sssd-ci.duckdns.org/logs/commit/f3/d91181d4ee9da3f8bbf4ddf8782951c0ae...
master: dc7d8ab0f796239338ea67cf6698e0bc6b619174 44703b84feaafa4f0a4f8df11c5a503dcf48616e 752227a75c0349089f1d7fdd3a09c8d4a77f425d 0e8a48e38e467b05951d2719956f8c0d5aed76b3 f3d91181d4ee9da3f8bbf4ddf8782951c0ae46c1
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Pavel Březina