[sssd PR#938][opened] Don't use tabs for indentation

[miztake]

URL: https://github.com/SSSD/sssd/pull/938
Author: miztake
 Title: #938: Don't use tabs for indentation
Action: opened

PR body:
"""
The Coding guidelines include the following:

https://docs.pagure.org/SSSD.sssd/developers/coding_style.html
    MUST: No tabs all indentation 4 spaces.

However, there are places where tabs are used for indentation.
Remove tabs indentation.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/938/head:pr938
git checkout pr938

[sssd PR#938][comment] Don't use tabs for indentation

[centos-ci]

URL: https://github.com/SSSD/sssd/pull/938
Title: #938: Don't use tabs for indentation

centos-ci commented:
"""
Can one of the admins verify this patch?
"""

See the full comment at https://github.com/SSSD/sssd/pull/938#issuecomment-553510508

[sssd PR#938][comment] Don't use tabs for indentation

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/938
Title: #938: Don't use tabs for indentation

mzidek-rh commented:
"""
Hi @miztake ,

I would prefer not to merge this change. I am worried about the backporting issues that may arise from this. We fix indentation issues when we already touch the badly formatted part of code for some other reason, for example if we touch a function and notice some lines are not indented properly, so we fix that as well (in the same or in separate patch), because the overall scope of change does not change too much. But fixing all indentation issues in the codebase touches too many places and complicates backporting.

Citing the coding guidelines:
"All new code should adhere to these standards but please do not go back and make wholesale formatting changes to the old code. It just confuses things and is generally a waste of time."
( see https://docs.pagure.org/SSSD.sssd/developers/coding_style.html )

I do see value in this patch, but it is still a NACK from me.

Anyway, thank you for your efforts.
"""

See the full comment at https://github.com/SSSD/sssd/pull/938#issuecomment-553820338

[sssd PR#938][+Rejected] Don't use tabs for indentation

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/938
Title: #938: Don't use tabs for indentation

Label: +Rejected

[sssd PR#938][comment] Don't use tabs for indentation

[miztake]

URL: https://github.com/SSSD/sssd/pull/938
Title: #938: Don't use tabs for indentation

miztake commented:
"""
mzidek-rh san,

Thank you for your polite comment.
I missed the explanation below.

https://docs.pagure.org/SSSD.sssd/developers/coding_style.html
  --------
  All new code should adhere to these standards but please do not go back and make wholesale formatting changes to the old code.
  It just confuses things and is generally a waste of time.
  --------

I understand your explanation.
I accept not to merge this PR.
Thank you for taking your time.
"""

See the full comment at https://github.com/SSSD/sssd/pull/938#issuecomment-553824120

[sssd PR#938][closed] Don't use tabs for indentation

[miztake]

URL: https://github.com/SSSD/sssd/pull/938
Author: miztake
 Title: #938: Don't use tabs for indentation
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/938/head:pr938
git checkout pr938

[sssd PR#938][comment] Don't use tabs for indentation

[miztake]

URL: https://github.com/SSSD/sssd/pull/938
Title: #938: Don't use tabs for indentation

miztake commented:
"""
mzidek-rh san,

Thank you for your polite comment.
I missed the explanation below.

https://docs.pagure.org/SSSD.sssd/developers/coding_style.html
  All new code should adhere to these standards but please do not go back and make wholesale formatting changes to the old code.
  It just confuses things and is generally a waste of time.

I understand your explanation.
I accept not to merge this PR.
Thank you for taking your time.
"""

See the full comment at https://github.com/SSSD/sssd/pull/938#issuecomment-553824120