URL: https://github.com/SSSD/sssd/pull/850 Author: pbrezina Title: #850: sudo: use proper datetime for default modifyTimestamp value Action: opened
PR body: """ The current default was simply "1", however OpenLDAP server was unable to compare modifyTimestamp attribute to simple number. A proper datetime is required by OpenLDAP.
It worked correctly on 389-ds.
Steps to reproduce: 1. install openldap server 2. run sssd 3. there are no sudo rules on the server and there are no cached objects 4. you'll see in the logs that sudo smart refresh uses `(&(&(objectclass=sudoRole)(modifyTimestamp>=1))...` filter (`1` instead of proper datetime value)
Resolves: https://pagure.io/SSSD/sssd/issue/4046 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/850/head:pr850 git checkout pr850
URL: https://github.com/SSSD/sssd/pull/850 Title: #850: sudo: use proper datetime for default modifyTimestamp value
abbra commented: """ LGTM but could you please add a comment to the commit message about a particular format of the timestamp (the fact that month and day cannot be zeroes, etc). """
See the full comment at https://github.com/SSSD/sssd/pull/850#issuecomment-512194056
URL: https://github.com/SSSD/sssd/pull/850 Author: pbrezina Title: #850: sudo: use proper datetime for default modifyTimestamp value Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/850/head:pr850 git checkout pr850
URL: https://github.com/SSSD/sssd/pull/850 Title: #850: sudo: use proper datetime for default modifyTimestamp value
pbrezina commented: """ Thank you. Commit message is updated. """
See the full comment at https://github.com/SSSD/sssd/pull/850#issuecomment-512214623
URL: https://github.com/SSSD/sssd/pull/850 Title: #850: sudo: use proper datetime for default modifyTimestamp value
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/850 Title: #850: sudo: use proper datetime for default modifyTimestamp value
abbra commented: """ Thanks. Please push. """
See the full comment at https://github.com/SSSD/sssd/pull/850#issuecomment-512724413
URL: https://github.com/SSSD/sssd/pull/850 Title: #850: sudo: use proper datetime for default modifyTimestamp value
pbrezina commented: """ * `master`: * 6815844daa7701c76e31addbbdff74656cd30bea """
See the full comment at https://github.com/SSSD/sssd/pull/850#issuecomment-512730616
URL: https://github.com/SSSD/sssd/pull/850 Author: pbrezina Title: #850: sudo: use proper datetime for default modifyTimestamp value Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/850/head:pr850 git checkout pr850
sssd-devel@lists.fedorahosted.org
-
abbra -
pbrezina