Should we close several stalled PRs?

[Jakub Hrozek]

Hi,
there are several PRs that were not touched for months. I would like to close them with a friendly message that the reporter can reopen them if they are inclined:

https://github.com/SSSD/sssd/pull/175 - Add module for starting services
 - does not apply anymore. It’s a good effort in general, though and I would like to see someone revive it, there is too much code duplication in the integration tests

https://github.com/SSSD/sssd/pull/247 - Subdomain inherit
 - we want this change to be done eventually, but there’s no reason to keep tracking this PR as long as we have a ticket upstream

https://github.com/SSSD/sssd/pull/387 - Setting ldap_sudo_include_regexp to false
 - no updates from the submitter for several months

https://github.com/SSSD/sssd/pull/410 - IPA: sanitize name in override search filter - Backport to SSSD-1.13
 - I don’t think anyone will respin this PR..

https://github.com/SSSD/sssd/pull/430 - tests: Remove the pysss.local interface
 - no updates from the submitter for several months

https://github.com/SSSD/sssd/pull/431 - Remove ldap_groups_use_matching_rule_in_chain
 - no updates from the submitter for several months

https://github.com/SSSD/sssd/pull/436 - subdomains: Remove code only used in tests
  - no updates from the submitter for several months

Is anyone against closing these?

[Fabiano Fidêncio]

Jakub,

On Wed, May 16, 2018 at 10:46 AM, Jakub Hrozek  wrote:
> Hi,
> there are several PRs that were not touched for months. I would like to close them with a friendly message that the reporter can reopen them if they are inclined:
>
> https://github.com/SSSD/sssd/pull/175 - Add module for starting services
> does not apply anymore. It’s a good effort in general, though and I would like to see someone revive it, there is too much code duplication in the integration tests

I'm not sure about this one. I'd really like to hear from Lukáš here
whether he plans to work on this or not. If that's not the case, we
can close the PR and someone else could open a new PR when needed.
> https://github.com/SSSD/sssd/pull/247 - Subdomain inherit
> we want this change to be done eventually, but there’s no reason to keep tracking this PR as long as we have a ticket upstream

Ack!
> https://github.com/SSSD/sssd/pull/387 - Setting ldap_sudo_include_regexp to false
> no updates from the submitter for several months

Ack!
> https://github.com/SSSD/sssd/pull/410 - IPA: sanitize name in override search filter - Backport to SSSD-1.13
> I don’t think anyone will respin this PR..

Ack! (And mea-culpa here that never got back to it).
> https://github.com/SSSD/sssd/pull/430 - tests: Remove the pysss.local interface
> no updates from the submitter for several months

Ack!
> https://github.com/SSSD/sssd/pull/431 - Remove ldap_groups_use_matching_rule_in_chain
> no updates from the submitter for several months

Ack!
> https://github.com/SSSD/sssd/pull/436 - subdomains: Remove code only used in tests
> no updates from the submitter for several months

Ack!
> Is anyone against closing these?
> _______________________________________________
> sssd-devel mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

Note: "Ack!" meaning "let's close!" :-)