URL: https://github.com/SSSD/sssd/pull/416 Author: mzidek-rh Title: #416: NSS: Memcache timeout equals zero Action: opened
PR body: """ Hi, these patches add new semantics to the memcache_timeout=0. From users perspective there is basically no change, but with value 0 the memcache files are not created. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/416/head:pr416 git checkout pr416
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
fidencio commented: """ @mzidek-rh, patches look okay and I just have one nitpick - **MAN: Document memcache_timeout=0 meaning**: s/can have significant/will have significant/ """
See the full comment at https://github.com/SSSD/sssd/pull/416#issuecomment-338020922
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
fidencio commented: """ I've fired a CI build with your patches and I'll post the result as soon as I get those. """
See the full comment at https://github.com/SSSD/sssd/pull/416#issuecomment-338021040
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
lslebodn commented: """ It is not simple solution as it was agreed on yesterday meeting.
https://github.com/SSSD/sssd/pull/414 """
See the full comment at https://github.com/SSSD/sssd/pull/416#issuecomment-338128727
URL: https://github.com/SSSD/sssd/pull/416 Author: mzidek-rh Title: #416: NSS: Memcache timeout equals zero Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/416/head:pr416 git checkout pr416
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
Label: +Rejected
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
pbrezina commented: """ But it does exactly what we agreed on. """
See the full comment at https://github.com/SSSD/sssd/pull/416#issuecomment-338130145
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
pbrezina commented: """ The non-simple solution is just that Michal moved the code to a separate function. I know you don't agree with this, bit given the fact you are the only one, can you finally stop, please? """
See the full comment at https://github.com/SSSD/sssd/pull/416#issuecomment-338130799
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
Label: -Rejected
URL: https://github.com/SSSD/sssd/pull/416 Author: mzidek-rh Title: #416: NSS: Memcache timeout equals zero Action: reopened
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/416/head:pr416 git checkout pr416
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
jhrozek commented: """ I'm getting really tired about this getting back and forth.. """
See the full comment at https://github.com/SSSD/sssd/pull/416#issuecomment-338137646
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
pbrezina commented: """ Michal, can you please add a sentence to the manpage warning, saying that it should only be used for testing purposes and not in production? """
See the full comment at https://github.com/SSSD/sssd/pull/416#issuecomment-338143369
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
lslebodn commented: """ we agreen on simple solution which is already in #414 """
See the full comment at https://github.com/SSSD/sssd/pull/416#issuecomment-338149573
URL: https://github.com/SSSD/sssd/pull/416 Author: mzidek-rh Title: #416: NSS: Memcache timeout equals zero Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/416/head:pr416 git checkout pr416
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
Label: +Rejected
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
lslebodn commented: """ we agreed on simple solution which is already in #414. And conditional build was removed from last version. """
See the full comment at https://github.com/SSSD/sssd/pull/416#issuecomment-338149573
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
fidencio commented: """ We agreed on **not** having conditional build. """
See the full comment at https://github.com/SSSD/sssd/pull/416#issuecomment-338153243
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
Label: -Rejected
URL: https://github.com/SSSD/sssd/pull/416 Author: mzidek-rh Title: #416: NSS: Memcache timeout equals zero Action: reopened
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/416/head:pr416 git checkout pr416
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
lslebodn commented: """ Closing per comment https://github.com/SSSD/sssd/pull/414#issuecomment-338160535
Simple solution (which we agreen on) have a huge benefit. It can be easily backported to older version of sssd in case of request from customers. """
See the full comment at https://github.com/SSSD/sssd/pull/416#issuecomment-338161084
URL: https://github.com/SSSD/sssd/pull/416 Author: mzidek-rh Title: #416: NSS: Memcache timeout equals zero Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/416/head:pr416 git checkout pr416
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
Label: +Rejected
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
Label: -Rejected
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
fidencio commented: """ I'm, **again**, reopening this pull-request. """
See the full comment at https://github.com/SSSD/sssd/pull/416#issuecomment-338164081
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
fidencio commented: """ And "Reopen and comment" button is not available for me. :-/ """
See the full comment at https://github.com/SSSD/sssd/pull/416#issuecomment-338164217
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
mzidek-rh commented: """ I do not see the changes I made... could it be because I pushed the changes while the PR was closed?
Will try to do something about it... """
See the full comment at https://github.com/SSSD/sssd/pull/416#issuecomment-338164421
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
mzidek-rh commented: """ Oh, I see the PR is still closed (I thought Fabiano reopened it but he probably only has the same permissions as I do). Ok, then I guess somebody will have to reopen it. Hopefully the changes will be visible after that. """
See the full comment at https://github.com/SSSD/sssd/pull/416#issuecomment-338165252
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
jhrozek commented: """ There is a hover-text above the "Reopen and comment" button that says "The memcache-timeout-zero branch was force-pushed or recreated" so I can't reopen the PR again either. A search only showed https://github.com/isaacs/github/issues/361 so it looks like a new PR needs to be created? """
See the full comment at https://github.com/SSSD/sssd/pull/416#issuecomment-338167401
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
lslebodn commented: """ I did changes in #414 after @pbrezina comment and there was still old version in PR https://github.com/SSSD/sssd/pull/414#issuecomment-338160535 """
See the full comment at https://github.com/SSSD/sssd/pull/416#issuecomment-338169424
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
lslebodn commented: """ I did changes in #414 after @pbrezina's comment and there was still old version in PR https://github.com/SSSD/sssd/pull/414#issuecomment-338160535 """
See the full comment at https://github.com/SSSD/sssd/pull/416#issuecomment-338169424
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
lslebodn commented: """ I did changes in #414 after @pbrezina's comment and there were still old version in PR https://github.com/SSSD/sssd/pull/414#issuecomment-338160535 """
See the full comment at https://github.com/SSSD/sssd/pull/416#issuecomment-338169424
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
pbrezina commented: """ @lslebodn Michal's solution is more elegant thus I prefer this one. About your argument on backporting, it's true, but lets not code for future requests that may never come. """
See the full comment at https://github.com/SSSD/sssd/pull/416#issuecomment-338173584
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
mzidek-rh commented: """ This PR was resurrected here: https://github.com/SSSD/sssd/pull/420 """
See the full comment at https://github.com/SSSD/sssd/pull/416#issuecomment-338176210
URL: https://github.com/SSSD/sssd/pull/416 Title: #416: NSS: Memcache timeout equals zero
lslebodn commented: """ On (20/10/17 10:50), Pavel Březina wrote:
@lslebodn Michal's solution is more elegant thus I prefer this one. About your argument on backporting, it's true, but lets not code for future requests that may never come.
Just for the record. Are you sure that such request will not come from the user? hint: check related case.
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/416#issuecomment-338239837
sssd-devel@lists.fedorahosted.org
-
fidencio -
jhrozek
-
lslebodn
-
mzidek-rh
-
pbrezina