[PATCH] FAIL_OVER: Fix warning value computed is not used

[Lukas Slebodnik]

ehlo,

another warning on rhel6.

BTW different solution would be to cast to void.

LS

[Jakub Hrozek]

On Tue, Nov 10, 2015 at 09:11:25AM +0100, Lukas Slebodnik wrote:
> ehlo,
>
> another warning on rhel6.

ACK
> BTW different solution would be to cast to void.

I prefer this solution

CI: http://sssd-ci.duckdns.org/logs/job/32/38/summary.html

(Fedora-20 failure is unrelated)

[Pavel Reichl]

On 11/10/2015 02:39 PM, Jakub Hrozek wrote:
> On Tue, Nov 10, 2015 at 09:11:25AM +0100, Lukas Slebodnik wrote:
> > ehlo,
> >
> > another warning on rhel6.
>
> ACK
> > BTW different solution would be to cast to void.
>
> I prefer this solution

Why? I think that changing value of input parameter is generally a discouraged practice, although in our code base it's common. (I'm just asking I'm *not* nacking the patch.)
> CI: http://sssd-ci.duckdns.org/logs/job/32/38/summary.html
>
> (Fedora-20 failure is unrelated)
> _______________________________________________
> sssd-devel mailing list
> [e-mail]
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[Lukas Slebodnik]

On (10/11/15 14:55), Pavel Reichl wrote:
> On 11/10/2015 02:39 PM, Jakub Hrozek wrote:
> > On Tue, Nov 10, 2015 at 09:11:25AM +0100, Lukas Slebodnik wrote:
> > > ehlo,
> > >
> > > another warning on rhel6.
> >
> > ACK
> > > BTW different solution would be to cast to void.
> >
> > I prefer this solution
>
> Why? I think that changing value of input parameter is generally a discouraged practice, although in our code base it's common. (I'm just asking I'm *not* nacking the patch.)

It is a macro which return itself.
Without changing anything.

It is basicly noop.
  int a = 1;
  a = a;

LS

[Jakub Hrozek]

On Tue, Nov 10, 2015 at 02:55:43PM +0100, Pavel Reichl wrote:
> On 11/10/2015 02:39 PM, Jakub Hrozek wrote:
> > On Tue, Nov 10, 2015 at 09:11:25AM +0100, Lukas Slebodnik wrote:
> > > ehlo,
> > >
> > > another warning on rhel6.
> >
> > ACK
> > > BTW different solution would be to cast to void.
> >
> > I prefer this solution
>
> Why? I think that changing value of input parameter is generally a discouraged practice, although in our code base it's common. (I'm just asking I'm *not* nacking the patch.)

It seems more readable that the parameter is changed. It's not really
input parameter per se, its refcount is increased.

[Pavel Reichl]

On 11/10/2015 03:05 PM, Jakub Hrozek wrote:
> On Tue, Nov 10, 2015 at 02:55:43PM +0100, Pavel Reichl wrote:
> > On 11/10/2015 02:39 PM, Jakub Hrozek wrote:
> > > On Tue, Nov 10, 2015 at 09:11:25AM +0100, Lukas Slebodnik wrote:
> > > > ehlo,
> > > >
> > > > another warning on rhel6.
> > >
> > > ACK
> > > > BTW different solution would be to cast to void.
> > >
> > > I prefer this solution
> >
> > Why? I think that changing value of input parameter is generally a discouraged practice, although in our code base it's common. (I'm just asking I'm *not* nacking the patch.)
>
> It seems more readable that the parameter is changed. It's not really
> input parameter per se, its refcount is increased.

OK, thanks both.
> sssd-devel mailing list
> [e-mail]
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[Jakub Hrozek]

On Tue, Nov 10, 2015 at 02:39:03PM +0100, Jakub Hrozek wrote:
> On Tue, Nov 10, 2015 at 09:11:25AM +0100, Lukas Slebodnik wrote:
> > ehlo,
> >
> > another warning on rhel6.
>
> ACK

* master: acd615cffd144b69e2558a0fc45c6966423f2d02