sdap_async_netgroups.c misused SDAP_SEARCH_BASE?

[Moritz Baumann]

I have filed a bug report at:

https://bugzilla.redhat.com/show_bug.cgi?id=648150

ddiff -Nur sssd-1.4.0/src/providers/ldap/sdap_async_netgroups.c
sssd-1.4.0.patch/src/providers/ldap/sdap_async_netgroups.c
--- sssd-1.4.0/src/providers/ldap/sdap_async_netgroups.c        2010-10-18
20:03:45.000000000 +0200
+++ sssd-1.4.0.patch/src/providers/ldap/sdap_async_netgroups.c  2010-10-31
14:57:51.963194696 +0100
@@ -603,7 +603,7 @@

subreq = sdap_get_generic_send(state, state->ev, state->opts, 
state->sh,
                                     dp_opt_get_string(state->opts->basic,
-                                                     SDAP_SEARCH_BASE),
+
SDAP_NETGROUP_SEARCH_BASE),
                                     LDAP_SCOPE_SUBTREE,
                                     state->filter, state->attrs,
                                     state->opts->netgroup_map,

I'm not sure if this fixes the issue.

Best,
Moritz

[Sumit Bose]

On Sun, Oct 31, 2010 at 03:34:44PM +0100, Moritz Baumann wrote:
> I have filed a bug report at:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=648150
>
> ddiff -Nur sssd-1.4.0/src/providers/ldap/sdap_async_netgroups.c
> sssd-1.4.0.patch/src/providers/ldap/sdap_async_netgroups.c
> --- sssd-1.4.0/src/providers/ldap/sdap_async_netgroups.c        2010-10-18
> 20:03:45.000000000 +0200
> +++ sssd-1.4.0.patch/src/providers/ldap/sdap_async_netgroups.c  2010-10-31
> 14:57:51.963194696 +0100
> @@ -603,7 +603,7 @@
>   subreq = sdap_get_generic_send(state, state->ev, state->opts, 
>
> state->sh,
>                                      dp_opt_get_string(state->opts->basic,
>                                                 SDAP_SEARCH_BASE),
>
> SDAP_NETGROUP_SEARCH_BASE),
>                                      LDAP_SCOPE_SUBTREE,
>                                      state->filter, state->attrs,
>                                      state->opts->netgroup_map,
>
> I'm not sure if this fixes the issue.

Thank you very much, this patch is obviously correct. ACK

I have attached a reformatted version of the patch for easier inclusion.

bye,
Sumit
> Best,
> Moritz
> _______________________________________________
> sssd-devel mailing list
> [e-mail]
> https://fedorahosted.org/mailman/listinfo/sssd-devel

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/01/2010 04:11 AM, Sumit Bose wrote:
> Thank you very much, this patch is obviously correct. ACK
>
> I have attached a reformatted version of the patch for easier inclusion.

Pushed to master and sssd-1-4.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkzOvzkACgkQeiVVYja6o6NX9gCfZTrI2ZSEXgD1k0Q+dRljdhLM
> zaQAn23CdR61ZnKy/DftsFOhyOwGr58C
> =ylg0
> -----END PGP SIGNATURE-----