11:10 a.m.
URL: https://github.com/SSSD/sssd/pull/93
Author: jhrozek
Title: #93: SSH: Use default_domain_suffix for users' authorized keys
Action: opened
PR body:
"""
None
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/93/head:pr93
git checkout pr93
11:11 a.m.
New subject: [sssd PR#93][edited] SSH: Use default_domain_suffix for users' authorized keys
URL: https://github.com/SSSD/sssd/pull/93
Author: jhrozek
Title: #93: SSH: Use default_domain_suffix for users' authorized keys
Action: edited
11:13 a.m.
New subject: [sssd PR#93][edited] SSH: Use default_domain_suffix for users' authorized keys
URL: https://github.com/SSSD/sssd/pull/93
Author: jhrozek
Title: #93: SSH: Use default_domain_suffix for users' authorized keys
Action: edited
Changed field: body
Original value:
"""
In commit eeecc48 we disabled
default_domain_suffix for the SSH responder, but in a wrong way -- we
disabled the functionality completely, also for users, not only for
groups. This might have been correct at the time, since SSH keys in ID
overrides are a relatively new feature, but it's definitely not correct
in general.
Instead, this patch restores the use of default_domain_suffix, but only
for looking up public keys of users, not of groups.
"""
11:13 a.m.
New subject: [sssd PR#93][synchronized] SSH: Use default_domain_suffix for users' authorized keys
URL: https://github.com/SSSD/sssd/pull/93
Author: jhrozek
Title: #93: SSH: Use default_domain_suffix for users' authorized keys
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/93/head:pr93
git checkout pr93
5:38 a.m.
New subject: [sssd PR#93][comment] SSH: Use default_domain_suffix for users' authorized keys
URL: https://github.com/SSSD/sssd/pull/93
Title: #93: SSH: Use default_domain_suffix for users' authorized keys
celestian commented:
"""
Code LGTM.
CI: http://sssd-ci.duckdns.org/logs/job/57/87/summary.html
There is a failure on test ```test_sanity_rfc2307``` -- I think it is not connected to
your patch.
ACK
"""
See the full comment at https://github.com/SSSD/sssd/pull/93#issuecomment-263249860
5:38 a.m.
New subject: [sssd PR#93][+Accepted] SSH: Use default_domain_suffix for users' authorized keys
URL: https://github.com/SSSD/sssd/pull/93
Title: #93: SSH: Use default_domain_suffix for users' authorized keys
Label: +Accepted
7:06 a.m.
New subject: [sssd PR#93][comment] SSH: Use default_domain_suffix for users' authorized keys
URL: https://github.com/SSSD/sssd/pull/93
Title: #93: SSH: Use default_domain_suffix for users' authorized keys
pbrezina commented:
"""
On 11/24/2016 06:10 PM, Jakub Hrozek wrote:
------------------------------------------------------------------------
You can view, comment on, or merge this pull request online at:
https://github.com/SSSD/sssd/pull/93
Commit Summary
* SSH: Use default_domain_suffix for users' authorized keys
File Changes
* *M* src/responder/ssh/sshsrv_cmd.c
<https://github.com/SSSD/sssd/pull/93/files#diff-0> (12)
Patch Links:
* https://github.com/SSSD/sssd/pull/93.patch
* https://github.com/SSSD/sssd/pull/93.diff
Can you also prepare a patch to handle this inside cache_req? Ideally on
top of nss patches so we can avoid collisions.
"""
See the full comment at https://github.com/SSSD/sssd/pull/93#issuecomment-263266690
4:33 a.m.
New subject: [sssd PR#93][comment] SSH: Use default_domain_suffix for users' authorized keys
URL: https://github.com/SSSD/sssd/pull/93
Title: #93: SSH: Use default_domain_suffix for users' authorized keys
jhrozek commented:
"""
master: ed71fba97dfcf5b3f0f1834c06660c481b9ab3ce
sssd-1-14: 2949fe58ac344c44d756ca309d4b2b7f3590cee3
"""
See the full comment at https://github.com/SSSD/sssd/pull/93#issuecomment-265115833
4:33 a.m.
New subject: [sssd PR#93][closed] SSH: Use default_domain_suffix for users' authorized keys
URL: https://github.com/SSSD/sssd/pull/93
Author: jhrozek
Title: #93: SSH: Use default_domain_suffix for users' authorized keys
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/93/head:pr93
git checkout pr93
4:33 a.m.
New subject: [sssd PR#93][-Accepted] SSH: Use default_domain_suffix for users' authorized keys
URL: https://github.com/SSSD/sssd/pull/93
Title: #93: SSH: Use default_domain_suffix for users' authorized keys
Label: -Accepted
4:33 a.m.
New subject: [sssd PR#93][+Pushed] SSH: Use default_domain_suffix for users' authorized keys
URL: https://github.com/SSSD/sssd/pull/93
Title: #93: SSH: Use default_domain_suffix for users' authorized keys
Label: +Pushed
4:35 a.m.
New subject: [sssd PR#93][comment] SSH: Use default_domain_suffix for users' authorized keys
URL: https://github.com/SSSD/sssd/pull/93
Title: #93: SSH: Use default_domain_suffix for users' authorized keys
jhrozek commented:
"""
On Mon, Nov 28, 2016 at 05:06:54AM -0800, Pavel Březina wrote:
Can you also prepare a patch to handle this inside cache_req? Ideally
on
top of nss patches so we can avoid collisions.
Yes, but since this patch had to be pushed for downstream's sake, I
filed a ticket in the meantime:
https://fedorahosted.org/sssd/ticket/3260
"""
See the full comment at https://github.com/SSSD/sssd/pull/93#issuecomment-265116353
2697
days inactive
2709
days old
sssd-devel@lists.fedorahosted.org
11 comments
1 participants
participants (1)
-
fidencio