[sssd PR#90][opened] UTIL: Fix implicit declaration of function 'htobe32'

[fidencio]

URL: https://github.com/SSSD/sssd/pull/90
Author: lslebodn
 Title: #90: UTIL: Fix implicit declaration of function 'htobe32'
Action: opened

PR body:
"""
Include internal wrapper header file for endian related functions.

CC       src/util/cert/nss/libsss_cert_la-cert.lo
src/util/cert/nss/cert.c: In function 'cert_to_ssh_key':
src/util/cert/nss/cert.c:358: error: implicit declaration of function 'htobe32'
gmake[2]: *** [Makefile:12421: src/util/cert/nss/libsss_cert_la-cert.lo] Error 1
gmake[2]: Leaving directory '/root/sssd_from_git'
gmake[1]: *** [Makefile:20050: all-recursive] Error 1
gmake[1]: Leaving directory '/root/sssd_from_git'
gmake: *** [Makefile:7116: all] Error 2
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/90/head:pr90
git checkout pr90

[sssd PR#90][comment] UTIL: Fix implicit declaration of function 'htobe32'

[fidencio]

URL: https://github.com/SSSD/sssd/pull/90
Title: #90: UTIL: Fix implicit declaration of function 'htobe32'

fidencio commented:
"""
So, discussing in person with Lukáš he told me the compilation error happened when building sssd for BSD.
Would you mind including a mention to that in the commit message? Something like "Breakage noticed when building SSSD on *BSD" (or anything towards this line ...)

Is this the only breakage we have there? I'll wait for the whole series :-)
"""

See the full comment at https://github.com/SSSD/sssd/pull/90#issuecomment-262771305

[sssd PR#90][+Changes requested] UTIL: Fix implicit declaration of function 'htobe32'

[fidencio]

URL: https://github.com/SSSD/sssd/pull/90
Title: #90: UTIL: Fix implicit declaration of function 'htobe32'

Label: +Changes requested

[sssd PR#90][synchronized] UTIL: Fix implicit declaration of function 'htobe32'

[fidencio]

URL: https://github.com/SSSD/sssd/pull/90
Author: lslebodn
 Title: #90: UTIL: Fix implicit declaration of function 'htobe32'
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/90/head:pr90
git checkout pr90

[sssd PR#90][-Changes requested] UTIL: Fix implicit declaration of function 'htobe32'

[fidencio]

URL: https://github.com/SSSD/sssd/pull/90
Title: #90: UTIL: Fix implicit declaration of function 'htobe32'

Label: -Changes requested

[sssd PR#90][comment] UTIL: Fix implicit declaration of function 'htobe32'

[fidencio]

URL: https://github.com/SSSD/sssd/pull/90
Title: #90: UTIL: Fix implicit declaration of function 'htobe32'

lslebodn commented:
"""
Updated version attached; waiting for result from CentOS CI.
"""

See the full comment at https://github.com/SSSD/sssd/pull/90#issuecomment-262783056

[sssd PR#90][comment] UTIL: Fix implicit declaration of function 'htobe32'

[fidencio]

URL: https://github.com/SSSD/sssd/pull/90
Title: #90: UTIL: Fix implicit declaration of function 'htobe32'

fidencio commented:
"""
Acked-by: Fabiano Fidêncio 
"""

See the full comment at https://github.com/SSSD/sssd/pull/90#issuecomment-262854577

[sssd PR#90][+Accepted] UTIL: Fix implicit declaration of function 'htobe32'

[fidencio]

URL: https://github.com/SSSD/sssd/pull/90
Title: #90: UTIL: Fix implicit declaration of function 'htobe32'

Label: +Accepted

[sssd PR#90][comment] UTIL: Fix implicit declaration of function 'htobe32'

[fidencio]

URL: https://github.com/SSSD/sssd/pull/90
Title: #90: UTIL: Fix implicit declaration of function 'htobe32'

lslebodn commented:
"""
master:
* 58aa8d645fa95641431a2828e985f80c7fc36465

sssd-1-14:
* a70351fddb9c26763b2bf658f56ff043a7b3db6f

sssd-1-13:
* 1491279a333f9ecb682c87f7cf3a4c53b9b90ff3

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/90#issuecomment-262937346

[sssd PR#90][closed] UTIL: Fix implicit declaration of function 'htobe32'

[fidencio]

URL: https://github.com/SSSD/sssd/pull/90
Author: lslebodn
 Title: #90: UTIL: Fix implicit declaration of function 'htobe32'
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/90/head:pr90
git checkout pr90

[sssd PR#90][+Pushed] UTIL: Fix implicit declaration of function 'htobe32'

[fidencio]

URL: https://github.com/SSSD/sssd/pull/90
Title: #90: UTIL: Fix implicit declaration of function 'htobe32'

Label: +Pushed