[sssd PR#868][opened] ifp: let cache_req parse input name so it can fallback to upn search

[pbrezina]

   URL: https://github.com/SSSD/sssd/pull/868
Author: pbrezina
 Title: #868: ifp: let cache_req parse input name so it can fallback to upn search
Action: opened

PR body:
"""
UPN search expects that the input name is in its fully qualified form.
However, GetUserAttr calls cache_req with unqualified username therefore
it never fallback to UPN search.

Steps to reproduce:
1. Configure SSSD against AD
2. Set UPN to `TestUserUPN(a)ad.vm`
3. Run:

```
dbus-send --print-reply --system --dest=org.freedesktop.sssd.infopipe
/org/freedesktop/sssd/infopipe org.freedesktop.sssd.infopipe.GetUserAttr
string:[e-mail] array:string:name
Error sbus.Error.NotFound: No such file or directory
```

Resolves:
https://pagure.io/SSSD/sssd/issue/4065
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/868/head:pr868
git checkout pr868

[sssd PR#868][comment] ifp: let cache_req parse input name so it can fallback to upn search

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/868
Title: #868: ifp: let cache_req parse input name so it can fallback to upn search

pbrezina commented:
"""
I am not entirely sure about this change:

```diff
     /* IFP serves both POSIX and application domains. Requests that need
      * to differentiate between the two must be qualified
      */
-    subreq = cache_req_send(state, state->rctx->ev, state->rctx,
-                            state->ncache, 0,
-                            CACHE_REQ_ANY_DOM,
-                            state->domname, data);
+    subreq = cache_req_send(state, state->rctx->ev, state->rctx,
state->ncache,
+                            0, CACHE_REQ_ANY_DOM, NULL, data);
     if (subreq == NULL) {
-        tevent_req_error(req, ENOMEM);
-        return;
+        ret = ENOMEM;
+        goto done;
     }

`cache_req` internally will parse the input name and if it is fully qualified it will
search only in the right domain. @jhrozek Is there any specific reason why we would have
to provide search domain already in this `cache_req` call?
```
"""

See the full comment at https://github.com/SSSD/sssd/pull/868#issuecomment-522561558

[sssd PR#868][comment] ifp: let cache_req parse input name so it can fallback to upn search

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/868
Title: #868: ifp: let cache_req parse input name so it can fallback to upn search

pbrezina commented:
"""
I am not entirely sure about this change:

```diff
     /* IFP serves both POSIX and application domains. Requests that need
      * to differentiate between the two must be qualified
      */
-    subreq = cache_req_send(state, state->rctx->ev, state->rctx,
-                            state->ncache, 0,
-                            CACHE_REQ_ANY_DOM,
-                            state->domname, data);
+    subreq = cache_req_send(state, state->rctx->ev, state->rctx,
state->ncache,
+                            0, CACHE_REQ_ANY_DOM, NULL, data);
     if (subreq == NULL) {
-        tevent_req_error(req, ENOMEM);
-        return;
+        ret = ENOMEM;
+        goto done;
     }
```

`cache_req` internally will parse the input name and if it is fully qualified it will
search only in the right domain. @jhrozek Is there any specific reason why we would have
to provide search domain already in this `cache_req` call?

"""

See the full comment at https://github.com/SSSD/sssd/pull/868#issuecomment-522561558

[sssd PR#868][comment] ifp: let cache_req parse input name so it can fallback to upn search

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/868
Title: #868: ifp: let cache_req parse input name so it can fallback to upn search

sumit-bose commented:
"""
Hi,

thank you for the patch. It is working well in my tests, code looks good, passed CI and
Coverity didn't find a new issue as well. ACK

About your question above, I think in the old code `data` only had the short name, so the
domain name (if available) had to be given as well to make sure the right user is found.
Since the new code has the fully-qualified name in `data` the domain name does not have to
be given a second time.

bye,
Sumit 
"""

See the full comment at https://github.com/SSSD/sssd/pull/868#issuecomment-527306009

[sssd PR#868][+Accepted] ifp: let cache_req parse input name so it can fallback to upn search

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/868
Title: #868: ifp: let cache_req parse input name so it can fallback to upn search

Label: +Accepted

[sssd PR#868][+Ready to push] ifp: let cache_req parse input name so it can fallback to upn search

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/868
Title: #868: ifp: let cache_req parse input name so it can fallback to upn search

Label: +Ready to push

[sssd PR#868][comment] ifp: let cache_req parse input name so it can fallback to upn search

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/868
Title: #868: ifp: let cache_req parse input name so it can fallback to upn search

pbrezina commented:
"""
* `master`
    * 18611d70e2916138103a099d45861252d6323366 - ifp: let cache_req parse input name so it
can fallback to upn search

"""

See the full comment at https://github.com/SSSD/sssd/pull/868#issuecomment-527463775

[sssd PR#868][+Pushed] ifp: let cache_req parse input name so it can fallback to upn search

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/868
Title: #868: ifp: let cache_req parse input name so it can fallback to upn search

Label: +Pushed

[sssd PR#868][-Accepted] ifp: let cache_req parse input name so it can fallback to upn search

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/868
Title: #868: ifp: let cache_req parse input name so it can fallback to upn search

Label: -Accepted

[sssd PR#868][-Ready to push] ifp: let cache_req parse input name so it can fallback to upn search

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/868
Title: #868: ifp: let cache_req parse input name so it can fallback to upn search

Label: -Ready to push

[sssd PR#868][closed] ifp: let cache_req parse input name so it can fallback to upn search

[pbrezina]

   URL: https://github.com/SSSD/sssd/pull/868
Author: pbrezina
 Title: #868: ifp: let cache_req parse input name so it can fallback to upn search
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/868/head:pr868
git checkout pr868