URL: https://github.com/SSSD/sssd/pull/5908 Author: sgoveas Title: #5908: Check default debug level of sssd and corresponding logs Action: opened
PR body: """ It consists of five test cases: 1. Check default debug level when sssd start successfully 2. Check default debug level by successful authentication of the user 3. Check default level as 0 and 1 4. Check default level as 2 5. Check SBUS code should not trigger failure message during modules startup
Verifies: Issues: #5422 #5425
Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1893159 https://bugzilla.redhat.com/show_bug.cgi?id=1915319 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5908/head:pr5908 git checkout pr5908
URL: https://github.com/SSSD/sssd/pull/5908 Title: #5908: Check default debug level of sssd and corresponding logs
Label: +Tests
URL: https://github.com/SSSD/sssd/pull/5908 Title: #5908: Check default debug level of sssd and corresponding logs
alexey-tikhonov commented: """ What does this ``` Check default level as 0 and 1 Check default level as 2 ``` mean?
Default level is `(SSSDBG_FATAL_FAILURE|SSSDBG_CRIT_FAILURE|SSSDBG_OP_FAILURE)`, this corresponds to `2`.
How is it - "default level as 0 and 1"? """
See the full comment at https://github.com/SSSD/sssd/pull/5908#issuecomment-988202785
URL: https://github.com/SSSD/sssd/pull/5908 Title: #5908: Check default debug level of sssd and corresponding logs
alexey-tikhonov commented: """ ``` Check default level as 0 and 1 Check default level as 2 ```
Default level is `(SSSDBG_FATAL_FAILURE|SSSDBG_CRIT_FAILURE|SSSDBG_OP_FAILURE)`, this corresponds to `2`.
How is it - "default level as 0 and 1"? """
See the full comment at https://github.com/SSSD/sssd/pull/5908#issuecomment-988202785
URL: https://github.com/SSSD/sssd/pull/5908 Title: #5908: Check default debug level of sssd and corresponding logs
alexey-tikhonov commented: """ ``` Check default level as 0 and 1 Check default level as 2 ```
Default level is `(SSSDBG_FATAL_FAILURE|SSSDBG_CRIT_FAILURE|SSSDBG_OP_FAILURE)`, this corresponds to `2`.
How is it - "default level as 0 and 1"?
UPD: having read tests code, I think I understand now. But I think description is unclear. Something like "Check that messages with levels 0 and 1 are printed with default log level" would be better, imo. """
See the full comment at https://github.com/SSSD/sssd/pull/5908#issuecomment-988202785
URL: https://github.com/SSSD/sssd/pull/5908 Author: sgoveas Title: #5908: Check default debug level of sssd and corresponding logs Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5908/head:pr5908 git checkout pr5908
URL: https://github.com/SSSD/sssd/pull/5908 Author: sgoveas Title: #5908: Check default debug level of sssd and corresponding logs Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5908/head:pr5908 git checkout pr5908
URL: https://github.com/SSSD/sssd/pull/5908 Title: #5908: Check default debug level of sssd and corresponding logs
sgoveas commented: """
Check default level as 0 and 1 Check default level as 2Default level is `(SSSDBG_FATAL_FAILURE|SSSDBG_CRIT_FAILURE|SSSDBG_OP_FAILURE)`, this corresponds to `2`.
How is it - "default level as 0 and 1"?
UPD: having read tests code, I think I understand now. But I think description is unclear. Something like "Check that messages with levels 0 and 1 are printed with default log level" would be better, imo.
Updated the title """
See the full comment at https://github.com/SSSD/sssd/pull/5908#issuecomment-995764217
URL: https://github.com/SSSD/sssd/pull/5908 Title: #5908: Check default debug level of sssd and corresponding logs
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5908 Title: #5908: Check default debug level of sssd and corresponding logs
alexey-tikhonov commented: """ PEP check is failing: - https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-5908/3/fedora34/ci-pep8.log - https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-5908/3/rhel8/ci-pep8.log """
See the full comment at https://github.com/SSSD/sssd/pull/5908#issuecomment-997822797
URL: https://github.com/SSSD/sssd/pull/5908 Title: #5908: Check default debug level of sssd and corresponding logs
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5908 Title: #5908: Check default debug level of sssd and corresponding logs
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/5908 Author: sgoveas Title: #5908: Check default debug level of sssd and corresponding logs Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5908/head:pr5908 git checkout pr5908
URL: https://github.com/SSSD/sssd/pull/5908 Title: #5908: Check default debug level of sssd and corresponding logs
sgoveas commented: """
PEP check is failing:
Fixed the errors from this PR. Will send a separate commit for the other errors if they still exist """
See the full comment at https://github.com/SSSD/sssd/pull/5908#issuecomment-998567450
URL: https://github.com/SSSD/sssd/pull/5908 Author: sgoveas Title: #5908: Check default debug level of sssd and corresponding logs Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5908/head:pr5908 git checkout pr5908
URL: https://github.com/SSSD/sssd/pull/5908 Title: #5908: Check default debug level of sssd and corresponding logs
alexey-tikhonov commented: """ Thank you for the updates. Looks good to me. """
See the full comment at https://github.com/SSSD/sssd/pull/5908#issuecomment-998771951
URL: https://github.com/SSSD/sssd/pull/5908 Title: #5908: Check default debug level of sssd and corresponding logs
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/5908 Title: #5908: Check default debug level of sssd and corresponding logs
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5908 Title: #5908: Check default debug level of sssd and corresponding logs
alexey-tikhonov commented: """
Thank you for the updates. Looks good to me.
@jakub-vavra-cz, could you please take a look as well? """
See the full comment at https://github.com/SSSD/sssd/pull/5908#issuecomment-1005047491
URL: https://github.com/SSSD/sssd/pull/5908 Title: #5908: Check default debug level of sssd and corresponding logs
shridhargadekar commented: """ @sgoveas Could you implement f-strings instead of currently used string formatting. """
See the full comment at https://github.com/SSSD/sssd/pull/5908#issuecomment-1009636603
URL: https://github.com/SSSD/sssd/pull/5908 Author: sgoveas Title: #5908: Check default debug level of sssd and corresponding logs Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5908/head:pr5908 git checkout pr5908
URL: https://github.com/SSSD/sssd/pull/5908 Title: #5908: Check default debug level of sssd and corresponding logs
sgoveas commented: """
@sgoveas Could you implement f-strings instead of currently used string formatting.
Done """
See the full comment at https://github.com/SSSD/sssd/pull/5908#issuecomment-1009643589
URL: https://github.com/SSSD/sssd/pull/5908 Author: sgoveas Title: #5908: Check default debug level of sssd and corresponding logs Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5908/head:pr5908 git checkout pr5908
sssd-devel@lists.fedorahosted.org
-
alexey-tikhonov -
sgoveas
-
shridhargadekar