11:57 p.m.
URL: https://github.com/SSSD/sssd/pull/5908
Author: sgoveas
Title: #5908: Check default debug level of sssd and corresponding logs
Action: opened
PR body:
"""
It consists of five test cases:
1. Check default debug level when sssd start
successfully
2. Check default debug level by
successful authentication of the user
3. Check default level as 0 and 1
4. Check default level as 2
5. Check SBUS code should not trigger failure
message during modules startup
Verifies:
Issues: #5422
#5425
Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1893159
https://bugzilla.redhat.com/show_bug.cgi?id=1915319
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5908/head:pr5908
git checkout pr5908
10:36 a.m.
New subject: [sssd PR#5908][+Tests] Check default debug level of sssd and corresponding logs
URL: https://github.com/SSSD/sssd/pull/5908
Title: #5908: Check default debug level of sssd and corresponding logs
Label: +Tests
1:22 p.m.
New subject: [sssd PR#5908][comment] Check default debug level of sssd and corresponding logs
URL: https://github.com/SSSD/sssd/pull/5908
Title: #5908: Check default debug level of sssd and corresponding logs
alexey-tikhonov commented:
"""
What does this
```
Check default level as 0 and 1
Check default level as 2
```
mean?
Default level is `(SSSDBG_FATAL_FAILURE|SSSDBG_CRIT_FAILURE|SSSDBG_OP_FAILURE)`, this
corresponds to `2`.
How is it - "default level as 0 and 1"?
"""
See the full comment at https://github.com/SSSD/sssd/pull/5908#issuecomment-988202785
1:40 p.m.
New subject: [sssd PR#5908][comment] Check default debug level of sssd and corresponding logs
URL: https://github.com/SSSD/sssd/pull/5908
Title: #5908: Check default debug level of sssd and corresponding logs
alexey-tikhonov commented:
"""
```
Check default level as 0 and 1
Check default level as 2
```
Default level is `(SSSDBG_FATAL_FAILURE|SSSDBG_CRIT_FAILURE|SSSDBG_OP_FAILURE)`, this
corresponds to `2`.
How is it - "default level as 0 and 1"?
"""
See the full comment at https://github.com/SSSD/sssd/pull/5908#issuecomment-988202785
1:52 p.m.
New subject: [sssd PR#5908][comment] Check default debug level of sssd and corresponding logs
URL: https://github.com/SSSD/sssd/pull/5908
Title: #5908: Check default debug level of sssd and corresponding logs
alexey-tikhonov commented:
"""
```
Check default level as 0 and 1
Check default level as 2
```
Default level is `(SSSDBG_FATAL_FAILURE|SSSDBG_CRIT_FAILURE|SSSDBG_OP_FAILURE)`, this
corresponds to `2`.
How is it - "default level as 0 and 1"?
UPD: having read tests code, I think I understand now. But I think description is unclear.
Something like "Check that messages with levels 0 and 1 are printed with default log
level" would be better, imo.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5908#issuecomment-988202785
6:15 a.m.
New subject: [sssd PR#5908][synchronized] Check default debug level of sssd and corresponding logs
URL: https://github.com/SSSD/sssd/pull/5908
Author: sgoveas
Title: #5908: Check default debug level of sssd and corresponding logs
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5908/head:pr5908
git checkout pr5908
6:17 a.m.
New subject: [sssd PR#5908][synchronized] Check default debug level of sssd and corresponding logs
URL: https://github.com/SSSD/sssd/pull/5908
Author: sgoveas
Title: #5908: Check default debug level of sssd and corresponding logs
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5908/head:pr5908
git checkout pr5908
6:19 a.m.
New subject: [sssd PR#5908][comment] Check default debug level of sssd and corresponding logs
URL: https://github.com/SSSD/sssd/pull/5908
Title: #5908: Check default debug level of sssd and corresponding logs
sgoveas commented:
"""
```
Check default level as 0 and 1
Check default level as 2
```
Default level is `(SSSDBG_FATAL_FAILURE|SSSDBG_CRIT_FAILURE|SSSDBG_OP_FAILURE)`, this
corresponds to `2`.
How is it - "default level as 0 and 1"?
UPD: having read tests code, I think I understand now. But I think description is
unclear. Something like "Check that messages with levels 0 and 1 are printed with
default log level" would be better, imo.
Updated the title
"""
See the full comment at https://github.com/SSSD/sssd/pull/5908#issuecomment-995764217
2:09 a.m.
New subject: [sssd PR#5908][+Waiting for review] Check default debug level of sssd and corresponding logs
URL: https://github.com/SSSD/sssd/pull/5908
Title: #5908: Check default debug level of sssd and corresponding logs
Label: +Waiting for review
5:16 a.m.
New subject: [sssd PR#5908][comment] Check default debug level of sssd and corresponding logs
URL: https://github.com/SSSD/sssd/pull/5908
Title: #5908: Check default debug level of sssd and corresponding logs
alexey-tikhonov commented:
"""
PEP check is failing:
- https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-5908/3/fedora34/ci-pep8.log
- https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-5908/3/rhel8/ci-pep8.log
"""
See the full comment at https://github.com/SSSD/sssd/pull/5908#issuecomment-997822797
5:16 a.m.
New subject: [sssd PR#5908][-Waiting for review] Check default debug level of sssd and corresponding logs
URL: https://github.com/SSSD/sssd/pull/5908
Title: #5908: Check default debug level of sssd and corresponding logs
Label: -Waiting for review
5:16 a.m.
New subject: [sssd PR#5908][+Changes requested] Check default debug level of sssd and corresponding logs
URL: https://github.com/SSSD/sssd/pull/5908
Title: #5908: Check default debug level of sssd and corresponding logs
Label: +Changes requested
2:19 a.m.
New subject: [sssd PR#5908][synchronized] Check default debug level of sssd and corresponding logs
URL: https://github.com/SSSD/sssd/pull/5908
Author: sgoveas
Title: #5908: Check default debug level of sssd and corresponding logs
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5908/head:pr5908
git checkout pr5908
2:22 a.m.
New subject: [sssd PR#5908][comment] Check default debug level of sssd and corresponding logs
URL: https://github.com/SSSD/sssd/pull/5908
Title: #5908: Check default debug level of sssd and corresponding logs
sgoveas commented:
"""
PEP check is failing:
* https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-5908/3/fedora34/ci-pep8.log
* https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-5908/3/rhel8/ci-pep8.log
Fixed the errors from this PR. Will send a separate commit for the other errors if they
still exist
"""
See the full comment at https://github.com/SSSD/sssd/pull/5908#issuecomment-998567450
3:26 a.m.
New subject: [sssd PR#5908][synchronized] Check default debug level of sssd and corresponding logs
URL: https://github.com/SSSD/sssd/pull/5908
Author: sgoveas
Title: #5908: Check default debug level of sssd and corresponding logs
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5908/head:pr5908
git checkout pr5908
7:18 a.m.
New subject: [sssd PR#5908][comment] Check default debug level of sssd and corresponding logs
URL: https://github.com/SSSD/sssd/pull/5908
Title: #5908: Check default debug level of sssd and corresponding logs
alexey-tikhonov commented:
"""
Thank you for the updates. Looks good to me.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5908#issuecomment-998771951
7:18 a.m.
New subject: [sssd PR#5908][-Changes requested] Check default debug level of sssd and corresponding logs
URL: https://github.com/SSSD/sssd/pull/5908
Title: #5908: Check default debug level of sssd and corresponding logs
Label: -Changes requested
7:18 a.m.
New subject: [sssd PR#5908][+Waiting for review] Check default debug level of sssd and corresponding logs
URL: https://github.com/SSSD/sssd/pull/5908
Title: #5908: Check default debug level of sssd and corresponding logs
Label: +Waiting for review
12:01 p.m.
New subject: [sssd PR#5908][comment] Check default debug level of sssd and corresponding logs
URL: https://github.com/SSSD/sssd/pull/5908
Title: #5908: Check default debug level of sssd and corresponding logs
alexey-tikhonov commented:
"""
Thank you for the updates. Looks good to me.
@jakub-vavra-cz, could you please take a look as well?
"""
See the full comment at https://github.com/SSSD/sssd/pull/5908#issuecomment-1005047491
12:25 a.m.
New subject: [sssd PR#5908][comment] Check default debug level of sssd and corresponding logs
URL: https://github.com/SSSD/sssd/pull/5908
Title: #5908: Check default debug level of sssd and corresponding logs
shridhargadekar commented:
"""
@sgoveas Could you implement f-strings instead of currently used string formatting.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5908#issuecomment-1009636603
12:40 a.m.
New subject: [sssd PR#5908][synchronized] Check default debug level of sssd and corresponding logs
URL: https://github.com/SSSD/sssd/pull/5908
Author: sgoveas
Title: #5908: Check default debug level of sssd and corresponding logs
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5908/head:pr5908
git checkout pr5908
12:42 a.m.
New subject: [sssd PR#5908][comment] Check default debug level of sssd and corresponding logs
URL: https://github.com/SSSD/sssd/pull/5908
Title: #5908: Check default debug level of sssd and corresponding logs
sgoveas commented:
"""
@sgoveas Could you implement f-strings instead of currently used
string formatting.
Done
"""
See the full comment at https://github.com/SSSD/sssd/pull/5908#issuecomment-1009643589
3:42 a.m.
New subject: [sssd PR#5908][synchronized] Check default debug level of sssd and corresponding logs
URL: https://github.com/SSSD/sssd/pull/5908
Author: sgoveas
Title: #5908: Check default debug level of sssd and corresponding logs
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5908/head:pr5908
git checkout pr5908
833
days inactive
869
days old
sssd-devel@lists.fedorahosted.org
22 comments
3 participants
participants (3)
-
alexey-tikhonov -
sgoveas
-
shridhargadekar