[PATCH] tests: Use unique name for TEST_PATH

[Lukas Slebodnik]

ehlo,

attached patch should prevent copy@paste errors in unit tests.

e.g.
e0f2a783439fb7d3b85469f34ad6d672abf7e1fa
0d0e787555efc1e6e4eb39a924bb9861bf2921d5

LS

[Jakub Hrozek]

On Thu, Sep 10, 2015 at 03:28:50PM +0200, Lukas Slebodnik wrote:
> ehlo,
>
> attached patch should prevent copy@paste errors in unit tests.
>
> e.g.
> e0f2a783439fb7d3b85469f34ad6d672abf7e1fa
> 0d0e787555efc1e6e4eb39a924bb9861bf2921d5
>
> LS

I like the patches and they improve the tests a lot, but there is a
warning when invoking Makefile.am now, about using a non-POSIX variable
name:
    Makefile.am:398: warning: *F: non-POSIX variable name

I don't really mind us using GNU extensions in Makefile.am, but shouldn't
we then use -Wno-portability to suppress warnings?

[Lukas Slebodnik]

On (14/09/15 15:37), Jakub Hrozek wrote:
> On Thu, Sep 10, 2015 at 03:28:50PM +0200, Lukas Slebodnik wrote:
> > ehlo,
> >
> > attached patch should prevent copy@paste errors in unit tests.
> >
> > e.g.
> > e0f2a783439fb7d3b85469f34ad6d672abf7e1fa
> > 0d0e787555efc1e6e4eb39a924bb9861bf2921d5
> >
> > LS
>
> I like the patches and they improve the tests a lot, but there is a
> warning when invoking Makefile.am now, about using a non-POSIX variable
> name:
>    Makefile.am:398: warning: *F: non-POSIX variable name
>
> I don't really mind us using GNU extensions in Makefile.am, but shouldn't
> we then use -Wno-portability to suppress warnings?

I didn't mind a warnig because there were other non-POSIX warnings
in make for manual pages.

But it's not a big problem to disable them.

Updated version is attached.

LS

[Jakub Hrozek]

On Fri, Sep 18, 2015 at 10:40:58AM +0200, Lukas Slebodnik wrote:
> On (14/09/15 15:37), Jakub Hrozek wrote:
> > On Thu, Sep 10, 2015 at 03:28:50PM +0200, Lukas Slebodnik wrote:
> > > ehlo,
> > >
> > > attached patch should prevent copy@paste errors in unit tests.
> > >
> > > e.g.
> > > e0f2a783439fb7d3b85469f34ad6d672abf7e1fa
> > > 0d0e787555efc1e6e4eb39a924bb9861bf2921d5
> > >
> > > LS
> >
> > I like the patches and they improve the tests a lot, but there is a
> > warning when invoking Makefile.am now, about using a non-POSIX variable
> > name:
> >    Makefile.am:398: warning: *F: non-POSIX variable name
> >
> > I don't really mind us using GNU extensions in Makefile.am, but shouldn't
> > we then use -Wno-portability to suppress warnings?
>
> I didn't mind a warnig because there were other non-POSIX warnings
> in make for manual pages.
>
> But it's not a big problem to disable them.
>
> Updated version is attached.
>
> LS

Thanks, ACK.

CI (together with your other test patches):
    http://sssd-ci.duckdns.org/logs/job/26/81/summary.html

[Jakub Hrozek]

On Fri, Sep 18, 2015 at 01:20:32PM +0200, Jakub Hrozek wrote:
> Thanks, ACK.
>
> CI (together with your other test patches):
>     http://sssd-ci.duckdns.org/logs/job/26/81/summary.html

master:
    * d71cd46ede9c57e3947c86c61306a9caddce242c
    * 50c9d542e8bf641412debaa82a4dcf67ddb72258