3:11 a.m.
URL: https://github.com/SSSD/sssd/pull/157
Author: lslebodn
Title: #157: intg: Fix python3 issues
Action: opened
PR body:
"""
Mostly string/bytes related issues.
It looks like my comments to the integration tests
were lost as part of review or due to rebases.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/157/head:pr157
git checkout pr157
9:26 a.m.
New subject: [sssd PR#157][comment] intg: Fix python3 issues
URL: https://github.com/SSSD/sssd/pull/157
Title: #157: intg: Fix python3 issues
fidencio commented:
"""
Patch does make sense, but I don't feel comfortable ACKing python related stuff.
Martin Basti? :-)
"""
See the full comment at https://github.com/SSSD/sssd/pull/157#issuecomment-280361657
9:47 a.m.
New subject: [sssd PR#157][comment] intg: Fix python3 issues
URL: https://github.com/SSSD/sssd/pull/157
Title: #157: intg: Fix python3 issues
fidencio commented:
"""
@lslebodn: I'd say the changes mentioned by Martin (thanks for the review, btw) could
(and do make sense) be part of this "series" (not exactly the same patch though,
as already mentioned by Martin).
"""
See the full comment at https://github.com/SSSD/sssd/pull/157#issuecomment-280367849
9:47 a.m.
New subject: [sssd PR#157][+Changes requested] intg: Fix python3 issues
URL: https://github.com/SSSD/sssd/pull/157
Title: #157: intg: Fix python3 issues
Label: +Changes requested
12:13 p.m.
New subject: [sssd PR#157][synchronized] intg: Fix python3 issues
URL: https://github.com/SSSD/sssd/pull/157
Author: lslebodn
Title: #157: intg: Fix python3 issues
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/157/head:pr157
git checkout pr157
12:38 p.m.
New subject: [sssd PR#157][-Changes requested] intg: Fix python3 issues
URL: https://github.com/SSSD/sssd/pull/157
Title: #157: intg: Fix python3 issues
Label: -Changes requested
3:06 a.m.
New subject: [sssd PR#157][comment] intg: Fix python3 issues
URL: https://github.com/SSSD/sssd/pull/157
Title: #157: intg: Fix python3 issues
fidencio commented:
"""
@lslebodn:
There's no need to resend the patch, just change it before pushing ...
But, please, add some comment explaining the reason of using 'w' in the
NamedTemporaryFile() (just because it's not something obvious).
"""
See the full comment at https://github.com/SSSD/sssd/pull/157#issuecomment-280595179
3:06 a.m.
New subject: [sssd PR#157][+Accepted] intg: Fix python3 issues
URL: https://github.com/SSSD/sssd/pull/157
Title: #157: intg: Fix python3 issues
Label: +Accepted
3:17 a.m.
New subject: [sssd PR#157][comment] intg: Fix python3 issues
URL: https://github.com/SSSD/sssd/pull/157
Title: #157: intg: Fix python3 issues
MartinBasti commented:
"""
IMO the `w` arg is quite obvious in python
"""
See the full comment at https://github.com/SSSD/sssd/pull/157#issuecomment-280597778
3:24 a.m.
New subject: [sssd PR#157][comment] intg: Fix python3 issues
URL: https://github.com/SSSD/sssd/pull/157
Title: #157: intg: Fix python3 issues
fidencio commented:
"""
I'd like to see the whole explanation in the commit message:
'If content is unicode, then instead of encoding, NamedTemporaryFile can be opened in
textual write mode "w", default mode is binary "w+b" '
Doesn't seem to be obvious as it ended up caught during the review (and I'm quite
dumb on python related stuff). So better having it in the commit message than searching
for it on my email if necessary.
"""
See the full comment at https://github.com/SSSD/sssd/pull/157#issuecomment-280599707
5:28 a.m.
New subject: [sssd PR#157][comment] intg: Fix python3 issues
URL: https://github.com/SSSD/sssd/pull/157
Title: #157: intg: Fix python3 issues
lslebodn commented:
"""
On (17/02/17 01:17), MartinBasti wrote:
IMO the `w` arg is quite obvious in python
Agree
The commit message should not learn people how to use python.
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/157#issuecomment-280626053
5:32 a.m.
New subject: [sssd PR#157][comment] intg: Fix python3 issues
URL: https://github.com/SSSD/sssd/pull/157
Title: #157: intg: Fix python3 issues
fidencio commented:
"""
It shouldn't teach people how to use python, true. But it has to have a good
explanation why those changes where necessary (and here as much info as possible is
desirable, mainly for people who don't do python and may blame this code for
reference).
"""
See the full comment at https://github.com/SSSD/sssd/pull/157#issuecomment-280626724
5:58 a.m.
New subject: [sssd PR#157][synchronized] intg: Fix python3 issues
URL: https://github.com/SSSD/sssd/pull/157
Author: lslebodn
Title: #157: intg: Fix python3 issues
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/157/head:pr157
git checkout pr157
6:16 a.m.
New subject: [sssd PR#157][comment] intg: Fix python3 issues
URL: https://github.com/SSSD/sssd/pull/157
Title: #157: intg: Fix python3 issues
fidencio commented:
"""
@lslebodn, thanks!
Please, go for it.
"""
See the full comment at https://github.com/SSSD/sssd/pull/157#issuecomment-280634497
6:31 a.m.
New subject: [sssd PR#157][comment] intg: Fix python3 issues
URL: https://github.com/SSSD/sssd/pull/157
Title: #157: intg: Fix python3 issues
lslebodn commented:
"""
master:
* bac4458c89a589055ae3daf4f72cc7dba886264a
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/157#issuecomment-280637220
6:32 a.m.
New subject: [sssd PR#157][closed] intg: Fix python3 issues
URL: https://github.com/SSSD/sssd/pull/157
Author: lslebodn
Title: #157: intg: Fix python3 issues
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/157/head:pr157
git checkout pr157
6:37 a.m.
New subject: [sssd PR#157][+Pushed] intg: Fix python3 issues
URL: https://github.com/SSSD/sssd/pull/157
Title: #157: intg: Fix python3 issues
Label: +Pushed
2622
days inactive
2623
days old
sssd-devel@lists.fedorahosted.org
16 comments
3 participants
participants (3)
-
fidencio -
lslebodn
-
MartinBasti