-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 11/04/2010 11:07 AM, Simo Sorce wrote:
On Thu, 04 Nov 2010 11:00:53 -0400
Stephen Gallagher <sgallagh(a)redhat.com> wrote:
> On 11/04/2010 10:36 AM, Stephen Gallagher wrote:
>> On 11/04/2010 10:10 AM, Stephen Gallagher wrote:
>>> On 11/04/2010 10:06 AM, Simo Sorce wrote:
>>>> On Thu, 04 Nov 2010 09:04:37 -0400
>>>> Stephen Gallagher <sgallagh(a)redhat.com> wrote:
>>
>>>>> -----BEGIN PGP SIGNED MESSAGE-----
>>>>> Hash: SHA1
>>>>>
>>>>> This patch makes two changes:
>>>>>
>>>>> 1) If we receive an error from rotating the logs, add it to the
>>>>> syslog message
>>>>> 2) Check for EINTR when closing the debug file and retry.
>>>>>
>>>>> This will either resolve
>>>>>
https://fedorahosted.org/sssd/ticket/668 or at minimum help
>>>>> identify it.
>>
>>>> This patch still doesn't reopen logs if fclose() fails for other
>>>> reasons than EINTR, is that what you meant ?
>>
>>> Yeah, I sent this before we discussed that. This patch was mainly
>>> for diagnostic purposes.
>>
>>> Self-nack. I'll revise the patch to do the reopening.
>>
>>
>>
>> This should be more like it.
>>
>
> Simo noted offline that some of the checks were redundant. I've
> streamlined the patch somewhat now.
>
ACK.
Simo.
Pushed to master.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkzT9PIACgkQeiVVYja6o6NFvACfbMGuWj910nPLoFSZO0lvC5Fq
C+kAoJDbIF8X9lPE1YRgEMrEhrdUMnyk
=bgbV
-----END PGP SIGNATURE-----