URL: https://github.com/SSSD/sssd/pull/5495 Author: mtorromeo Title: #5495: Fix python headers detection with recent autoconf (Fixes #5336) Action: opened
PR body: """ See details in issue report #5336. This is causing issues on Arch Linux which is using autoconf-2.71 at the moment.
This only addresses the specific issue with python headers detection and not the whole use of if statements in autoconf files. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5495/head:pr5495 git checkout pr5495
URL: https://github.com/SSSD/sssd/pull/5495 Author: mtorromeo Title: #5495: Fix python headers detection with recent autoconf (Fixes #5336) Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5495/head:pr5495 git checkout pr5495
URL: https://github.com/SSSD/sssd/pull/5495 Author: mtorromeo Title: #5495: Fix python headers detection with recent autoconf (Fixes #5336) Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5495/head:pr5495 git checkout pr5495
URL: https://github.com/SSSD/sssd/pull/5495 Title: #5495: Fix python headers detection with recent autoconf (Fixes #5336)
mtorromeo commented: """ This only solves part of the issue so I replaced all shell conditionals with `AS_IF`s in configure.ac but I guess even m4 files in src/external should be updated.
For the moment I am going to explicitly expand `AC_PROG_CPP` in configure.ac as a workaround. """
See the full comment at https://github.com/SSSD/sssd/pull/5495#issuecomment-774565694
URL: https://github.com/SSSD/sssd/pull/5495 Title: #5495: Fix python headers detection with recent autoconf (Fixes #5336)
ikerexxe commented: """ By the way, do you mind changing your commit messages? Something in the following format would be nice: `configure: Fix python headers detection with recent autoconf` `Resolves: https://github.com/SSSD/sssd/issues/5336%60 """
See the full comment at https://github.com/SSSD/sssd/pull/5495#issuecomment-810284993
URL: https://github.com/SSSD/sssd/pull/5495 Title: #5495: Fix python headers detection with recent autoconf (Fixes #5336)
mtorromeo commented: """
By the way, do you mind changing your commit messages? Something in the following format would be nice: `configure: Fix python headers detection with recent autoconf` `Resolves: https://github.com/SSSD/sssd/issues/5336%60
I can change the message but, as mentioned above, this MR does not really fix issue #5536. It's just a small part of what would need to be changed and I ended up using a workaround to bypass that issue.
I don't even know if you might still want to merge this as-is. """
See the full comment at https://github.com/SSSD/sssd/pull/5495#issuecomment-810873897
URL: https://github.com/SSSD/sssd/pull/5495 Title: #5495: Fix python headers detection with recent autoconf (Fixes #5336)
ikerexxe commented: """
I can change the message but, as mentioned above, this MR does not really fix issue #5536. It's just a small part of what would need to be changed and I ended up using a workaround to bypass that issue.
I think it's a step forward. Can you provide more information about the workaround? From what I gather it's something related with `AC_PROG_CPP` macro. Maybe you could provide a link to the patch.
I don't even know if you might still want to merge this as-is.
As said before this is a step forward, so yes I'm willing to merge it.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5495#issuecomment-810965898
URL: https://github.com/SSSD/sssd/pull/5495 Author: mtorromeo Title: #5495: Fix python headers detection with recent autoconf (Fixes #5336) Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5495/head:pr5495 git checkout pr5495
URL: https://github.com/SSSD/sssd/pull/5495 Title: #5495: Fix python headers detection with recent autoconf (Fixes #5336)
mtorromeo commented: """
I think it's a step forward. Can you provide more information about the workaround? From what I gather it's something related with `AC_PROG_CPP` macro. Maybe you could provide a link to the patch.
This is the one-liner I'm using: `sed '/AM_PROG_CC_C_O/ i AC_PROG_CPP' -i configure.ac`
As said before this is a step forward, so yes I'm willing to merge it.
Alright, I updated the MR with the requested changes.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5495#issuecomment-810995224
URL: https://github.com/SSSD/sssd/pull/5495 Author: mtorromeo Title: #5495: Fix python headers detection with recent autoconf (Fixes #5336) Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5495/head:pr5495 git checkout pr5495
URL: https://github.com/SSSD/sssd/pull/5495 Title: #5495: Fix python headers detection with recent autoconf (Fixes #5336)
kloczek commented: """ Why not drastically simplify whole python detection using pkgconfig and skip all headers checks? """
See the full comment at https://github.com/SSSD/sssd/pull/5495#issuecomment-813950517
URL: https://github.com/SSSD/sssd/pull/5495 Title: #5495: Fix python headers detection with recent autoconf (Fixes #5336)
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5495 Title: #5495: Fix python headers detection with recent autoconf (Fixes #5336)
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5495 Title: #5495: Fix python headers detection with recent autoconf (Fixes #5336)
pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5495
* `master` * cd843dafe63589d0a77145445c454f6fc19dabae - configure: Fix python headers detection with recent autoconf Resolves: https://github.com/SSSD/sssd/issues/5336
"""
See the full comment at https://github.com/SSSD/sssd/pull/5495#issuecomment-815620266
URL: https://github.com/SSSD/sssd/pull/5495 Title: #5495: Fix python headers detection with recent autoconf (Fixes #5336)
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/5495 Title: #5495: Fix python headers detection with recent autoconf (Fixes #5336)
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5495 Title: #5495: Fix python headers detection with recent autoconf (Fixes #5336)
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5495 Author: mtorromeo Title: #5495: Fix python headers detection with recent autoconf (Fixes #5336) Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5495/head:pr5495 git checkout pr5495
sssd-devel@lists.fedorahosted.org
-
ikerexxe -
kloczek
-
mtorromeo
-
pbrezina