[sssd PR#858][opened] ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true
URL: https://github.com/SSSD/sssd/pull/858 Author: pbrezina Title: #858: ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true Action: opened
PR body: """ This caused an error when saving local user as a fallback:
``` [sdap_save_user] (0x0400): Storing info for user testuser@ldap.vm [sysdb_ldb_msg_difference] (0x2000): Added attr [gecos] to entry [name=testuser@ldap.vm,cn=users,cn=ldap.vm,cn=sysdb] [sysdb_set_cache_entry_attr] (0x0080): ldb_modify failed: [Invalid attribute syntax](21)[Element gecos has empty attribute in ldb message (name=testuser@ldap.vm,cn=users,cn=ldap.vm,cn=sysdb)!] [sysdb_set_cache_entry_attr] (0x0040): Error: 22 (Invalid argument) [sysdb_set_entry_attr] (0x0080): Cannot set attrs for name=testuser@ldap.vm,cn=users,cn=ldap.vm,cn=sysdb, 22 [Invalid argument] [sysdb_store_user] (0x0040): Cache update failed: 22 [sysdb_store_user] (0x0400): Error: 22 (Invalid argument) [sdap_save_user] (0x0020): Failed to save user [testuser@ldap.vm] ```
Steps to reproduce: 1. create local user `testuser` 2. add it to LDAP group memberUid 3. set `passwd: sss files`, `group: sss files` (sss must be before files) 4. set enable_files_domain = false and ldap_rfc2307_fallback_to_local_users = true 5. run sssd 6. id testuser -> it does not contain the LDAP group without the patch
Resolves: https://pagure.io/SSSD/sssd/issue/4013
Note: this fix only the case when the nsswitch order is `sss files` but no files domain is available. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/858/head:pr858 git checkout pr858
URL: https://github.com/SSSD/sssd/pull/858 Author: pbrezina Title: #858: ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/858/head:pr858 git checkout pr858
URL: https://github.com/SSSD/sssd/pull/858 Author: pbrezina Title: #858: ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true Action: edited
Changed field: body Original value: """ This caused an error when saving local user as a fallback:
``` [sdap_save_user] (0x0400): Storing info for user testuser@ldap.vm [sysdb_ldb_msg_difference] (0x2000): Added attr [gecos] to entry [name=testuser@ldap.vm,cn=users,cn=ldap.vm,cn=sysdb] [sysdb_set_cache_entry_attr] (0x0080): ldb_modify failed: [Invalid attribute syntax](21)[Element gecos has empty attribute in ldb message (name=testuser@ldap.vm,cn=users,cn=ldap.vm,cn=sysdb)!] [sysdb_set_cache_entry_attr] (0x0040): Error: 22 (Invalid argument) [sysdb_set_entry_attr] (0x0080): Cannot set attrs for name=testuser@ldap.vm,cn=users,cn=ldap.vm,cn=sysdb, 22 [Invalid argument] [sysdb_store_user] (0x0040): Cache update failed: 22 [sysdb_store_user] (0x0400): Error: 22 (Invalid argument) [sdap_save_user] (0x0020): Failed to save user [testuser@ldap.vm] ```
Steps to reproduce: 1. create local user `testuser` 2. add it to LDAP group memberUid 3. set `passwd: sss files`, `group: sss files` (sss must be before files) 4. set enable_files_domain = false and ldap_rfc2307_fallback_to_local_users = true 5. run sssd 6. id testuser -> it does not contain the LDAP group without the patch
Resolves: https://pagure.io/SSSD/sssd/issue/4013
Note: this fix only the case when the nsswitch order is `sss files` but no files domain is available. """
URL: https://github.com/SSSD/sssd/pull/858 Title: #858: ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/858 Title: #858: ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true
pbrezina commented: """ This PR got stalled. @sumit-bose can you review it please? """
See the full comment at https://github.com/SSSD/sssd/pull/858#issuecomment-537875985
URL: https://github.com/SSSD/sssd/pull/858 Title: #858: ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true
mzidek-rh commented: """ I will review this today or tomorrow. """
See the full comment at https://github.com/SSSD/sssd/pull/858#issuecomment-542644337
URL: https://github.com/SSSD/sssd/pull/858 Title: #858: ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true
mzidek-rh commented: """ ACK.
Just do not close the ticket as it is not 100% solved yet. """
See the full comment at https://github.com/SSSD/sssd/pull/858#issuecomment-543111577
URL: https://github.com/SSSD/sssd/pull/858 Title: #858: ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/858 Title: #858: ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/858 Title: #858: ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/858 Title: #858: ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true
pbrezina commented: """ * `master` * b32347d351259987c496a1be11a81ea19001451f - ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true
"""
See the full comment at https://github.com/SSSD/sssd/pull/858#issuecomment-543174763
URL: https://github.com/SSSD/sssd/pull/858 Title: #858: ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/858 Title: #858: ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/858 Title: #858: ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/858 Author: pbrezina Title: #858: ldap: do not store empty attribute with ldap_rfc2307_fallback_to_local_users = true Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/858/head:pr858 git checkout pr858
sssd-devel@lists.fedorahosted.org
-
mzidek-rh -
pbrezina