[PATCHES] sbus: support incoming signals and NameOwnerChanged

[Jakub Hrozek]

On Wed, Jun 03, 2015 at 01:28:01PM +0200, Pavel Březina wrote:
> From 4adbab01651583c48e103a3d0d5915a6eb6d3809 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Pavel=20B=C5=99ezina?= 
> Date: Wed, 3 Jun 2015 12:35:42 +0200
> Subject: [PATCH 1/2] sbus: add support for incoming signals

So far I only read the code, I didn't do any testing. The code reads
nicely to me, nice job!

Can you write a better commit message that describes from a 100-meter
view how the patch works and mentions the dbus filtering API you used?
Even a dbus API URL would be nice.

Also, can you write tests? I think the sbus subtree is very nicely
tested, it would be nice to keep that tradition.

[Pavel Březina]

Rebased on top of cached objects patches.

[Jakub Hrozek]

On Thu, Jun 18, 2015 at 04:30:26PM +0200, Pavel Březina wrote:
> Rebased on top of cached objects patches.

I had a bit of difficulty but the patches work OK and the code looks
well to me, too.

I'm just waiting for Coverity and CI before pushing..

[Jakub Hrozek]

On Thu, Jun 18, 2015 at 05:55:13PM +0200, Jakub Hrozek wrote:
> On Thu, Jun 18, 2015 at 04:30:26PM +0200, Pavel Březina wrote:
> > Rebased on top of cached objects patches.
>
> I had a bit of difficulty but the patches work OK and the code looks
> well to me, too.
>
> I'm just waiting for Coverity and CI before pushing..

CI: http://sssd-ci.duckdns.org/logs/job/17/91/summary.html

[Jakub Hrozek]

On Thu, Jun 18, 2015 at 05:55:13PM +0200, Jakub Hrozek wrote:
> On Thu, Jun 18, 2015 at 04:30:26PM +0200, Pavel Březina wrote:
> > Rebased on top of cached objects patches.
>
> I had a bit of difficulty but the patches work OK and the code looks
> well to me, too.
>
> I'm just waiting for Coverity and CI before pushing..

CI finished together with Sumit's by-cert lookups.

Pushed to master:
    * d4aa049726ce8c6feeaf6995d4abb4cb5155b9a1
    * ae7247551b78a05a5397d3c790afad7ef51b0d9d