URL: https://github.com/SSSD/sssd/pull/664 Author: jhrozek Title: #664: pep8: Ignore W504 and W605 to silence warnings on Debian Action: opened
PR body: """ This code: pkcs11_txt.write("library=libsoftokn3.so\nname=soft\n" + "parameters=configdir='sql:" + config.ABS_BUILDDIR + "/../test_CA/p11_nssdb' " + "dbSlotDescription='SSSD Test Slot' " + "dbTokenDescription='SSSD Test Token' " + "secmod='secmod.db' flags=readOnly)\n\n") pkcs11_txt.close()
Was producing warnings such as: ./src/tests/intg/test_pam_responder.py:143:22: W504 line break after binary operator
Even though it looks OK visually and conforms to pep8's written form.
Additionaly, this regular expression compilation: Template = re.compile( ' *<template name="(\S+)">(.*?)</template>\r?\n?', re.MULTILINE | re.DOTALL )
Was producing a warning such as: ./src/sbus/codegen/sbus_Template.py:156:29: W605 invalid escape sequence '\S'
Since the \S literal is part of a regular expression, let's suppress this warning as well. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/664/head:pr664 git checkout pr664
URL: https://github.com/SSSD/sssd/pull/664 Title: #664: pep8: Ignore W504 and W605 to silence warnings on Debian
jhrozek commented: """ Internal CI is running, I'll send a link once it finishes """
See the full comment at https://github.com/SSSD/sssd/pull/664#issuecomment-426189079
URL: https://github.com/SSSD/sssd/pull/664 Title: #664: pep8: Ignore W504 and W605 to silence warnings on Debian
mzidek-rh commented: """ If the internal CI finishes successfully feel free to push. """
See the full comment at https://github.com/SSSD/sssd/pull/664#issuecomment-426190452
URL: https://github.com/SSSD/sssd/pull/664 Title: #664: pep8: Ignore W504 and W605 to silence warnings on Debian
sumit-bose commented: """ About W504, if I understand it correctly there is no final agreement about the line break and binary operators in pep8, so there is W504 for a break after and W503 for a break before. As long as we do not have an agreement which style should be preferred in SSSD code it makes sense to ignore both. """
See the full comment at https://github.com/SSSD/sssd/pull/664#issuecomment-426225445
URL: https://github.com/SSSD/sssd/pull/664 Title: #664: pep8: Ignore W504 and W605 to silence warnings on Debian
jhrozek commented: """ CI passed: http://vm-031.$ABC/logs/job/94/00/summary.html """
See the full comment at https://github.com/SSSD/sssd/pull/664#issuecomment-426226913
URL: https://github.com/SSSD/sssd/pull/664 Title: #664: pep8: Ignore W504 and W605 to silence warnings on Debian
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/664 Title: #664: pep8: Ignore W504 and W605 to silence warnings on Debian
jhrozek commented: """ * master:ec7665973936897ab6be58308e655f08d91bec5c * sssd-1-16: bca1935761a8ac21a45abcda9f82feec259dc65c """
See the full comment at https://github.com/SSSD/sssd/pull/664#issuecomment-426570586
URL: https://github.com/SSSD/sssd/pull/664 Author: jhrozek Title: #664: pep8: Ignore W504 and W605 to silence warnings on Debian Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/664/head:pr664 git checkout pr664
URL: https://github.com/SSSD/sssd/pull/664 Title: #664: pep8: Ignore W504 and W605 to silence warnings on Debian
Label: +Pushed
sssd-devel@lists.fedorahosted.org