[sssd PR#5829][opened] DP: Resolve intermediate groups prior to SR overlay

[justin-stephenson]

   URL: https://github.com/SSSD/sssd/pull/5829
Author: justin-stephenson
 Title: #5829: DP: Resolve intermediate groups prior to SR overlay
Action: opened

PR body:
"""
SSSD SR exclude_groups checking can fail when only intermediate
groups are fetched during the login process. Add a step to
resolve these groups during Initgroups processing to ensure
the exclude groups check matches against the group name correctly.

This logic exists already similarly in the simple access provider.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5829/head:pr5829
git checkout pr5829

[sssd PR#5829][comment] DP: Resolve intermediate groups prior to SR overlay

[justin-stephenson]

  URL: https://github.com/SSSD/sssd/pull/5829
Title: #5829: DP: Resolve intermediate groups prior to SR overlay

justin-stephenson commented:
"""
https://bugzilla.redhat.com/show_bug.cgi?id=1968340
"""

See the full comment at https://github.com/SSSD/sssd/pull/5829#issuecomment-945898763

[sssd PR#5829][synchronized] DP: Resolve intermediate groups prior to SR overlay

[justin-stephenson]

   URL: https://github.com/SSSD/sssd/pull/5829
Author: justin-stephenson
 Title: #5829: DP: Resolve intermediate groups prior to SR overlay
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5829/head:pr5829
git checkout pr5829

[sssd PR#5829][+Bugzilla] DP: Resolve intermediate groups prior to SR overlay

[alexey-tikhonov]

  URL: https://github.com/SSSD/sssd/pull/5829
Title: #5829: DP: Resolve intermediate groups prior to SR overlay

Label: +Bugzilla

[sssd PR#5829][comment] DP: Resolve intermediate groups prior to SR overlay

[justin-stephenson]

  URL: https://github.com/SSSD/sssd/pull/5829
Title: #5829: DP: Resolve intermediate groups prior to SR overlay

justin-stephenson commented:
"""
This is on me to fix the intg test failures, test_initgroups_with_mc is failing, likely
due to ``sbus_call_nss_memcache_UpdateInitgroups_send`` being moved into
`dp_get_account_info_initgroups_resolv_done`.

-- Before SSSD is stopped
~~~
bash-5.1# id user1
uid=1001(user1) gid=2001(group1) groups=2001(group1)

bash-5.1# hexdump -C /tmp/sssd-intg.C2ZNOgHS/var/lib/sss/mc/group
00000000  01 00 00 f0 01 00 00 00  01 00 00 00 01 00 00 00  |................|
00000010  79 32 3d a6 40 00 60 00  cd 4c 00 00 a0 99 09 00  |y2=.@.`..L......|
00000020  38 00 00 00 78 00 60 00  48 4d 60 00 00 00 00 00  |8...x.`.HM`.....|
00000030  01 00 00 f0 00 00 00 00  00 00 00 f0 55 00 00 00  |............U...|
00000040  cb d3 6d 61 00 00 00 00  ff ff ff ff ff ff ff ff  |..ma............|
00000050  dc 51 00 00 d1 bf 00 00  ff ff ff ff 00 00 00 f0  |.Q..............|
00000060  10 00 00 00 d1 07 00 00  03 00 00 00 1d 00 00 00  |................|
00000070  67 72 6f 75 70 31 00 2a  00 75 73 65 72 31 00 75  |group1.*.user1.u|
00000080  73 65 72 31 31 00 75 73  65 72 32 31 00 ff ff ff  |ser11.user21....|
00000090  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
~~~

--- After SSSD is stopped when returning from memcache
~~~
bash-5.1# id user2
uid=1002(user2) gid=2002 groups=2002


bash-5.1# hexdump -C /tmp/sssd-intg.C2ZNOgHS/var/lib/sss/mc/group
00000000  01 00 00 f0 01 00 00 00  01 00 00 00 01 00 00 00  |................|
00000010  ad 7a 29 a7 40 00 60 00  cd 4c 00 00 a0 99 09 00  |.z).@.`..L......|
00000020  38 00 00 00 78 00 60 00  48 4d 60 00 00 00 00 00  |8...x.`.HM`.....|
00000030  01 00 00 f0 00 00 00 00  ff ff ff ff ff ff ff ff  |................|
00000040  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
*
00600070  ff ff ff ff ff ff ff ff  00 00 00 00 00 00 00 00  |................|
00600080  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
*
00604d40  00 00 00 00 00 00 00 00  ff ff ff ff ff ff ff ff  |................|
00604d50  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
*
0069e6e0  ff ff ff ff ff ff ff ff                           |........|
0069e6e8
~~~
"""

See the full comment at https://github.com/SSSD/sssd/pull/5829#issuecomment-946126101

[sssd PR#5829][synchronized] DP: Resolve intermediate groups prior to SR overlay

[justin-stephenson]

   URL: https://github.com/SSSD/sssd/pull/5829
Author: justin-stephenson
 Title: #5829: DP: Resolve intermediate groups prior to SR overlay
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5829/head:pr5829
git checkout pr5829

[sssd PR#5829][synchronized] DP: Resolve intermediate groups prior to SR overlay

[justin-stephenson]

   URL: https://github.com/SSSD/sssd/pull/5829
Author: justin-stephenson
 Title: #5829: DP: Resolve intermediate groups prior to SR overlay
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5829/head:pr5829
git checkout pr5829

[sssd PR#5829][synchronized] DP: Resolve intermediate groups prior to SR overlay

[justin-stephenson]

   URL: https://github.com/SSSD/sssd/pull/5829
Author: justin-stephenson
 Title: #5829: DP: Resolve intermediate groups prior to SR overlay
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5829/head:pr5829
git checkout pr5829

[sssd PR#5829][+Waiting for review] DP: Resolve intermediate groups prior to SR overlay

[justin-stephenson]

  URL: https://github.com/SSSD/sssd/pull/5829
Title: #5829: DP: Resolve intermediate groups prior to SR overlay

Label: +Waiting for review

[sssd PR#5829][comment] DP: Resolve intermediate groups prior to SR overlay

[justin-stephenson]

  URL: https://github.com/SSSD/sssd/pull/5829
Title: #5829: DP: Resolve intermediate groups prior to SR overlay

justin-stephenson commented:
"""
Ready for review, intg issues fixed.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5829#issuecomment-947205783

[sssd PR#5829][comment] DP: Resolve intermediate groups prior to SR overlay

[justin-stephenson]

  URL: https://github.com/SSSD/sssd/pull/5829
Title: #5829: DP: Resolve intermediate groups prior to SR overlay

justin-stephenson commented:
"""
Ready for review, intg test issues fixed.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5829#issuecomment-947205783

[sssd PR#5829][comment] DP: Resolve intermediate groups prior to SR overlay

[justin-stephenson]

  URL: https://github.com/SSSD/sssd/pull/5829
Title: #5829: DP: Resolve intermediate groups prior to SR overlay

justin-stephenson commented:
"""
Sumit suggested to check for intermediate groups by checking for groups which have a GID,
and isPosix is false. `simple_check_process_group()` seems to perform more checks than I
added in `dp_sr_resolve_groups_check() ` but i'm not sure if these two functions need
to match exactly for the purposes of this PR.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5829#issuecomment-948631387

[sssd PR#5829][+Changes requested] DP: Resolve intermediate groups prior to SR overlay

[alexey-tikhonov]

  URL: https://github.com/SSSD/sssd/pull/5829
Title: #5829: DP: Resolve intermediate groups prior to SR overlay

Label: +Changes requested

[sssd PR#5829][-Waiting for review] DP: Resolve intermediate groups prior to SR overlay

[alexey-tikhonov]

  URL: https://github.com/SSSD/sssd/pull/5829
Title: #5829: DP: Resolve intermediate groups prior to SR overlay

Label: -Waiting for review

[sssd PR#5829][synchronized] DP: Resolve intermediate groups prior to SR overlay

[justin-stephenson]

   URL: https://github.com/SSSD/sssd/pull/5829
Author: justin-stephenson
 Title: #5829: DP: Resolve intermediate groups prior to SR overlay
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5829/head:pr5829
git checkout pr5829

[sssd PR#5829][synchronized] DP: Resolve intermediate groups prior to SR overlay

[justin-stephenson]

   URL: https://github.com/SSSD/sssd/pull/5829
Author: justin-stephenson
 Title: #5829: DP: Resolve intermediate groups prior to SR overlay
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5829/head:pr5829
git checkout pr5829

[sssd PR#5829][synchronized] DP: Resolve intermediate groups prior to SR overlay

[justin-stephenson]

   URL: https://github.com/SSSD/sssd/pull/5829
Author: justin-stephenson
 Title: #5829: DP: Resolve intermediate groups prior to SR overlay
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5829/head:pr5829
git checkout pr5829

[sssd PR#5829][synchronized] DP: Resolve intermediate groups prior to SR overlay

[justin-stephenson]

   URL: https://github.com/SSSD/sssd/pull/5829
Author: justin-stephenson
 Title: #5829: DP: Resolve intermediate groups prior to SR overlay
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5829/head:pr5829
git checkout pr5829

[sssd PR#5829][comment] DP: Resolve intermediate groups prior to SR overlay

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5829
Title: #5829: DP: Resolve intermediate groups prior to SR overlay

pbrezina commented:
"""
I'm gonna do the release, pushing now.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5829#issuecomment-964228744

[sssd PR#5829][+Accepted] DP: Resolve intermediate groups prior to SR overlay

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5829
Title: #5829: DP: Resolve intermediate groups prior to SR overlay

Label: +Accepted

[sssd PR#5829][-Changes requested] DP: Resolve intermediate groups prior to SR overlay

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5829
Title: #5829: DP: Resolve intermediate groups prior to SR overlay

Label: -Changes requested

[sssd PR#5829][+Ready to push] DP: Resolve intermediate groups prior to SR overlay

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5829
Title: #5829: DP: Resolve intermediate groups prior to SR overlay

Label: +Ready to push

[sssd PR#5829][comment] DP: Resolve intermediate groups prior to SR overlay

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5829
Title: #5829: DP: Resolve intermediate groups prior to SR overlay

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5829

* `master`
    * 232ba7f0dcc2ee104c881bc3406f4dda3de86216 - DP: Resolve intermediate groups prior to
SR overlay

"""

See the full comment at https://github.com/SSSD/sssd/pull/5829#issuecomment-964229177

[sssd PR#5829][+Pushed] DP: Resolve intermediate groups prior to SR overlay

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5829
Title: #5829: DP: Resolve intermediate groups prior to SR overlay

Label: +Pushed

[sssd PR#5829][-Accepted] DP: Resolve intermediate groups prior to SR overlay

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5829
Title: #5829: DP: Resolve intermediate groups prior to SR overlay

Label: -Accepted

[sssd PR#5829][-Ready to push] DP: Resolve intermediate groups prior to SR overlay

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5829
Title: #5829: DP: Resolve intermediate groups prior to SR overlay

Label: -Ready to push

[sssd PR#5829][closed] DP: Resolve intermediate groups prior to SR overlay

[pbrezina]

   URL: https://github.com/SSSD/sssd/pull/5829
Author: justin-stephenson
 Title: #5829: DP: Resolve intermediate groups prior to SR overlay
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5829/head:pr5829
git checkout pr5829

[sssd PR#5829][comment] DP: Resolve intermediate groups prior to SR overlay

[justin-stephenson]

  URL: https://github.com/SSSD/sssd/pull/5829
Title: #5829: DP: Resolve intermediate groups prior to SR overlay

justin-stephenson commented:
"""
>  I'm gonna do the release, pushing now.
>  
Thank you!
"""

See the full comment at https://github.com/SSSD/sssd/pull/5829#issuecomment-965328446