[sssd PR#354][opened] libwbclient: Fix warning statement with no effect

[lslebodn]

   URL: https://github.com/SSSD/sssd/pull/354
Author: lslebodn
 Title: #354: libwbclient: Fix warning statement with no effect
Action: opened

PR body:
"""
src/sss_client/libwbclient/wbc_pam_sssd.c: In function ‘wbcAuthenticateUserEx’:
src/sss_client/libwbclient/wbc_pam_sssd.c:52:5: error: statement with no effect
[-Werror=unused-value]
     WBC_ERR_WINBIND_NOT_AVAILABLE;
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/sss_client/libwbclient/wbc_pam_sssd.c:53:1: error: control reaches end of non-void
function [-Werror=return-type]
 }
 ^

`WBC_SSSD_NOT_IMPLEMENTED` is not an error code but also macro which can log to syslog
and then return `WBC_ERR_NOT_IMPLEMENTED`
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/354/head:pr354
git checkout pr354

[sssd PR#354][comment] libwbclient: Fix warning statement with no effect

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/354
Title: #354: libwbclient: Fix warning statement with no effect

sumit-bose commented:
"""
oops, I'm sorry for not catching this, so I put a postit to my monitor reminding me to
really run a build with even the simplest looking changes. So let me run a build before I
ack it ...
"""

See the full comment at https://github.com/SSSD/sssd/pull/354#issuecomment-324056898

[sssd PR#354][comment] libwbclient: Fix warning statement with no effect

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/354
Title: #354: libwbclient: Fix warning statement with no effect

lslebodn commented:
"""
I was testing such patch on el7 and I did not notice it either.
I wonder how could it fix https://pagure.io/SSSD/sssd/issue/3461 :-)
"""

See the full comment at https://github.com/SSSD/sssd/pull/354#issuecomment-324057600

[sssd PR#354][comment] libwbclient: Fix warning statement with no effect

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/354
Title: #354: libwbclient: Fix warning statement with no effect

fidencio commented:
"""
That's exactly the case that could be avoided by having something like
https://github.com/SSSD/sssd/pull/50.
"""

See the full comment at https://github.com/SSSD/sssd/pull/354#issuecomment-324060339

[sssd PR#354][comment] libwbclient: Fix warning statement with no effect

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/354
Title: #354: libwbclient: Fix warning statement with no effect

sumit-bose commented:
"""
ACK
"""

See the full comment at https://github.com/SSSD/sssd/pull/354#issuecomment-324065118

[sssd PR#354][+Accepted] libwbclient: Fix warning statement with no effect

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/354
Title: #354: libwbclient: Fix warning statement with no effect

Label: +Accepted

[sssd PR#354][comment] libwbclient: Fix warning statement with no effect

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/354
Title: #354: libwbclient: Fix warning statement with no effect

fidencio commented:
"""
That's exactly the case that could be avoided by having something like
https://github.com/SSSD/sssd/pull/50.
"""

See the full comment at https://github.com/SSSD/sssd/pull/354#issuecomment-324060339

[sssd PR#354][closed] libwbclient: Fix warning statement with no effect

[lslebodn]

   URL: https://github.com/SSSD/sssd/pull/354
Author: lslebodn
 Title: #354: libwbclient: Fix warning statement with no effect
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/354/head:pr354
git checkout pr354

[sssd PR#354][+Pushed] libwbclient: Fix warning statement with no effect

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/354
Title: #354: libwbclient: Fix warning statement with no effect

Label: +Pushed

[sssd PR#354][comment] libwbclient: Fix warning statement with no effect

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/354
Title: #354: libwbclient: Fix warning statement with no effect

lslebodn commented:
"""
master:
* aede6a1f4412f133e4b3fd76944f764d76fc4868
"""

See the full comment at https://github.com/SSSD/sssd/pull/354#issuecomment-324099400