URL: https://github.com/SSSD/sssd/pull/112 Author: justin-stephenson Title: #112: FAILOVER: Improve port status log messages Action: opened
PR body: """ This PR is created to ensure administrators do not follow the wrong path troubleshooting issues, especially with messages such as:
`Port status of port 636 for server 'server' is 'not working'`
This patch should help to clarify that there is no direct relationship between port status and actual networking status. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/112/head:pr112 git checkout pr112
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/112#issuecomment-268095628
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/112#issuecomment-268095633
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages
jhrozek commented: """ ok to test """
See the full comment at https://github.com/SSSD/sssd/pull/112#issuecomment-268183489
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages
jhrozek commented: """ I have two comments: 1. The new debug message has "louder" debug level than the one that sets the port as non-working. I would suggest to also change the 'not working' debug message to MINOR_FAILURE 1. I'm not sure it's correct to say that there is 'no relationship' between the message and the networking status, but not a 'direct relationship' or '1:1 mapping' I'm not sure how to reword the message better though, do you think it would make sense to say something like 'even if the network port is reachable, the internal port can be marked as not working if sssd is not able to complete the full connection request' """
See the full comment at https://github.com/SSSD/sssd/pull/112#issuecomment-268471510
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages
jhrozek commented: """ I wonder if @mzidek-rh has any more comments """
See the full comment at https://github.com/SSSD/sssd/pull/112#issuecomment-268471546
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages
mzidek-rh commented: """ Hi Justin!
I agree with jhrozek that the debug level is not correct and that the message is confusing, because there is relationship between the status of internal port representation and the system network status. Maybe we can just change the debug message in case of 'not working' status. For example by adding a sentence "This means that SSSD was not able to complete the full connection request and which does not necessary indicate networking issues."
Michal """
See the full comment at https://github.com/SSSD/sssd/pull/112#issuecomment-268513334
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages
mzidek-rh commented: """ Hi Justin!
I agree with jhrozek that the debug level is not correct and that the message is confusing, because there is relationship between the status of internal port representation and the system network status. Maybe we can just change the debug message in case of 'not working' status. For example by adding a sentence "This means that SSSD was not able to complete the full connection request which does not necessary indicate networking issues."
Michal """
See the full comment at https://github.com/SSSD/sssd/pull/112#issuecomment-268513334
URL: https://github.com/SSSD/sssd/pull/112 Author: justin-stephenson Title: #112: FAILOVER: Improve port status log messages Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/112/head:pr112 git checkout pr112
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages
justin-stephenson commented: """ Hello Jakub/Michal, thanks a lot for your comments and review.
I updated the PR to provide a better explanation which uses elements of both suggestions mentioned.
I used `SSSDBG_MINOR_FAILURE` for this message but i'm not confident if this is the desired log level(sorry if I misunderstood), now we have 3 different DEBUG log level types being used in `get_port_status`.
Also, is there a better location or calling function to log this message which will avoid duplicate messages as shown below?
[sssd[be[jstephen.local]]] [fo_resolve_service_send] (0x0100): Trying to resolve service 'IPA' [sssd[be[jstephen.local]]] [get_server_status] (0x1000): Status of server 'ipa-server-f24.jstephen.local' is 'working' [sssd[be[jstephen.local]]] [get_port_status] (0x1000): Port status of port 389 for server 'ipa-server-f24.jstephen.local' is 'not working' [sssd[be[jstephen.local]]] [get_port_status] (0x0080): SSSD is unable to complete the full connection request, this internal status does not necessarily indicate network port issues. [sssd[be[jstephen.local]]] [get_server_status] (0x1000): Status of server 'ipa-replica-f25.jstephen.local' is 'not working' [sssd[be[jstephen.local]]] [get_server_status] (0x1000): Status of server 'ipa-server-f24.jstephen.local' is 'working' [sssd[be[jstephen.local]]] [get_port_status] (0x1000): Port status of port 0 for server 'ipa-server-f24.jstephen.local' is 'not working' [sssd[be[jstephen.local]]] [get_port_status] (0x0080): SSSD is unable to complete the full connection request, this internal status does not necessarily indicate network port issues. [sssd[be[jstephen.local]]] [fo_resolve_service_send] (0x0020): No available servers for service 'IPA' """
See the full comment at https://github.com/SSSD/sssd/pull/112#issuecomment-268629883
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages
jhrozek commented: """ I'm sorry this review stalled.
I think the current patch is fine. About the duplicate messages -- the messages from get_server_status and get_port_status are quite low debug level and inform about a current state. So in my opinion this is OK and your patch improves the situation.
So I'm adding the accepted label and will push after a bit of time to let other developers chime in if they have another opinion. """
See the full comment at https://github.com/SSSD/sssd/pull/112#issuecomment-277069153
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/112 Author: justin-stephenson Title: #112: FAILOVER: Improve port status log messages Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/112/head:pr112 git checkout pr112
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages
jhrozek commented: """ * master: 1c7f9a676088ecee4c14df14b8688b391fb32a05 """
See the full comment at https://github.com/SSSD/sssd/pull/112#issuecomment-277713445
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages
Label: -Accepted
sssd-devel@lists.fedorahosted.org
-
fidencio -
jhrozek