URL: https://github.com/SSSD/sssd/pull/5281 Author: thalman Title: #5281: Dn with spaces for 1.16 Action: opened
PR body: """ Cherry picked commits of PR https://github.com/SSSD/sssd/pull/5262
Resolves: #5261
"""
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5281/head:pr5281 git checkout pr5281
URL: https://github.com/SSSD/sssd/pull/5281 Author: thalman Title: #5281: Dn with spaces for 1.16 Action: edited
Changed field: body Original value: """ Cherry picked commits of PR https://github.com/SSSD/sssd/pull/5262
Resolves: #5261
"""
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
alexey-tikhonov commented: """ This is quite clean backport of #5262, hence ACK. """
See the full comment at https://github.com/SSSD/sssd/pull/5281#issuecomment-675542757
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
alexey-tikhonov commented: """ This is quite clean backport of #5262, covscan is clean, hence ACK. """
See the full comment at https://github.com/SSSD/sssd/pull/5281#issuecomment-675542757
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
alexey-tikhonov commented: """ This is quite clean backport of #5262 and covscan is clean, hence ACK. """
See the full comment at https://github.com/SSSD/sssd/pull/5281#issuecomment-675542757
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
Label: +Bugzilla
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
alexey-tikhonov commented: """ RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1859554 """
See the full comment at https://github.com/SSSD/sssd/pull/5281#issuecomment-675563688
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/5281 Author: thalman Title: #5281: Dn with spaces for 1.16 Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5281/head:pr5281 git checkout pr5281
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
thalman commented: """ Updated of an another part of the patch. """
See the full comment at https://github.com/SSSD/sssd/pull/5281#issuecomment-676371594
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
sumit-bose commented: """ Hi,
thanks for the update, ACK.
Btw, the cherry-picked messages might need an update after the original patches are commited to master.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5281#issuecomment-676388286
URL: https://github.com/SSSD/sssd/pull/5281 Author: thalman Title: #5281: Dn with spaces for 1.16 Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5281/head:pr5281 git checkout pr5281
URL: https://github.com/SSSD/sssd/pull/5281 Author: thalman Title: #5281: Dn with spaces for 1.16 Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5281/head:pr5281 git checkout pr5281
URL: https://github.com/SSSD/sssd/pull/5281 Author: thalman Title: #5281: Dn with spaces for 1.16 Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5281/head:pr5281 git checkout pr5281
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
alexey-tikhonov commented: """ Patches: ``` UTIL: DN sanitization UTIL: Use sss_sanitize_dn where we deal with DN UTIL: Use sss_sanitize_dn where we deal with DN 2 ``` were reviewed by @elkoniu and @sumit-bose
Patch ``` ldap: use member DN to create ghost user hash table ``` was reviewed by @thalman and me.
As Sumit wrote, cherry-pick commit messages might need an update after the original patches are commited to master. """
See the full comment at https://github.com/SSSD/sssd/pull/5281#issuecomment-688255131
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
Label: +Blocked
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
thalman commented: """ There were again changes in master branch PR (typo in comment + ghost hash tests). I will push them here once the https://github.com/SSSD/sssd/pull/5262 is approved or merged """
See the full comment at https://github.com/SSSD/sssd/pull/5281#issuecomment-689552127
URL: https://github.com/SSSD/sssd/pull/5281 Author: thalman Title: #5281: WIP: Dn with spaces for 1.16 Action: edited
Changed field: title Original value: """ Dn with spaces for 1.16 """
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: WIP: Dn with spaces for 1.16
pbrezina commented: """ master PR is merged, please update this one """
See the full comment at https://github.com/SSSD/sssd/pull/5281#issuecomment-702650278
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: WIP: Dn with spaces for 1.16
Label: -Blocked
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: WIP: Dn with spaces for 1.16
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/5281 Author: thalman Title: #5281: WIP: Dn with spaces for 1.16 Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5281/head:pr5281 git checkout pr5281
URL: https://github.com/SSSD/sssd/pull/5281 Author: thalman Title: #5281: Dn with spaces for 1.16 Action: edited
Changed field: title Original value: """ WIP: Dn with spaces for 1.16 """
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
thalman commented: """ Cherry-picked last/acked version from master. Please take a look. """
See the full comment at https://github.com/SSSD/sssd/pull/5281#issuecomment-703592477
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
alexey-tikhonov commented: """ Seems commit hashes doesn't match that mentioned in https://github.com/SSSD/sssd/pull/5262#issuecomment-702649764
But this is something that can be fixed during the merge...
Otherwise LGTM. """
See the full comment at https://github.com/SSSD/sssd/pull/5281#issuecomment-703609586
URL: https://github.com/SSSD/sssd/pull/5281 Author: thalman Title: #5281: Dn with spaces for 1.16 Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5281/head:pr5281 git checkout pr5281
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5281
* `sssd-1-16` * e5ae7bab88603fd64a27bcf59d4bba1503835ad0 - intg: allow member DN to have a different case * a63a22284d85d54514247549e94212e466b5c93c - ldap: use member DN to create ghost user hash table * f31005a076fa470d3b1a1b6117f306355ae6d97b - UTIL: Use sss_sanitize_dn where we deal with DN 2 * a960d66daaa1e0fb0602958452c6b40ee714f3b2 - UTIL: Use sss_sanitize_dn where we deal with DN * a20e08524d58c52ebfb5b971b361a91d911825cf - UTIL: DN sanitization
"""
See the full comment at https://github.com/SSSD/sssd/pull/5281#issuecomment-704162353
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5281 Author: thalman Title: #5281: Dn with spaces for 1.16 Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5281/head:pr5281 git checkout pr5281
sssd-devel@lists.fedorahosted.org