[sssd PR#955][opened] tests: fix race confition in files provider tests

[pbrezina]

   URL: https://github.com/SSSD/sssd/pull/955
Author: pbrezina
 Title: #955: tests: fix race confition in files provider tests
Action: opened

PR body:
"""
Lets give files provider more time to load changes from files to avoid
race condition failures. The files provider tests works like this:

1. File is changed
2. inotify callback is triggered in SSSD
3. Cache is updated
4. Assertions are done

This sleep is supposed to eliminated race condition between step 1 and 2
so tests do not continue before inotify callback had a chance to kick in.

One second was not enough in some slow virtual environments where the
test non-deterministicly failed (SSSD is starting, doing some initial tasks,
so it is possible that inotify callback is delayed a little bit).
Three seconds is a hopefully safe random value.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/955/head:pr955
git checkout pr955

[sssd PR#955][comment] tests: fix race confition in files provider tests

[alexey-tikhonov]

  URL: https://github.com/SSSD/sssd/pull/955
Title: #955: tests: fix race confition in files provider tests

alexey-tikhonov commented:
"""
For detailed discussion see #947 
"""

See the full comment at https://github.com/SSSD/sssd/pull/955#issuecomment-562105150

[sssd PR#955][+Accepted] tests: fix race confition in files provider tests

[alexey-tikhonov]

  URL: https://github.com/SSSD/sssd/pull/955
Title: #955: tests: fix race confition in files provider tests

Label: +Accepted

[sssd PR#955][-Accepted] tests: fix race confition in files provider tests

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/955
Title: #955: tests: fix race confition in files provider tests

Label: -Accepted

[sssd PR#955][+Blocked] tests: fix race confition in files provider tests

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/955
Title: #955: tests: fix race confition in files provider tests

Label: +Blocked

[sssd PR#955][comment] tests: fix race confition in files provider tests

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/955
Title: #955: tests: fix race confition in files provider tests

pbrezina commented:
"""
Actually, as Alexey pointer out from [my
comment](https://github.com/SSSD/sssd/pull/947#issuecomment-562093538) `dp_sbus` calls in
`sf_passwd|group_cb` are useless because they are received by responders only after
`sf_enum_files` is finished due to their asynchronous nature.

This needs to be fixed first and perhaps it will also fix the tests (though the race
condition before inotify callback is triggered will still exist so some sleep may be
necessary).


"""

See the full comment at https://github.com/SSSD/sssd/pull/955#issuecomment-562114520

[sssd PR#955][comment] tests: fix race confition in files provider tests

[alexey-tikhonov]

  URL: https://github.com/SSSD/sssd/pull/955
Title: #955: tests: fix race confition in files provider tests

alexey-tikhonov commented:
"""
https://pagure.io/SSSD/sssd/issue/4130
"""

See the full comment at https://github.com/SSSD/sssd/pull/955#issuecomment-564107418