[sssd PR#658][opened] pytest: Test case for sudo: search with lower cased name for case insensitive domains

List overview All Threads
Download

newer

older

[sssd PR#666][opened] ci: add...

[sssd PR#660][opened] doc: remove...

mrniranjan

20 Sep 2018 20 Sep '18

12:32 p.m.

URL: https://github.com/SSSD/sssd/pull/658 Author: mrniranjan Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains Action: opened

PR body: """

"""

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/658/head:pr658 git checkout pr658

Attachments:

sssd-pr-658.patch (text/x-diff — 13.7 KB)

Show replies by date

centos-ci

20 Sep 20 Sep

12:32 p.m.

New subject: [sssd PR#658][comment] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains

centos-ci commented: """ Can one of the admins verify this patch? """

See the full comment at https://github.com/SSSD/sssd/pull/658#issuecomment-423132698

sumit-bose

1:13 p.m.

New subject: [sssd PR#658][comment] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains

sumit-bose commented: """ ok ot test """

See the full comment at https://github.com/SSSD/sssd/pull/658#issuecomment-423145060

jhrozek

9:51 p.m.

New subject: [sssd PR#658][comment] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains

jhrozek commented: """ ok to test """

See the full comment at https://github.com/SSSD/sssd/pull/658#issuecomment-423310772

jhrozek

9:54 p.m.

New subject: [sssd PR#658][comment] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains

jhrozek commented: """ the previous comment had a typo :-) But more importantly, I'm not sure why the centos CI didn't start automatically. I suspect it was just a PEBKAC and I might have not clicked 'apply' but only 'save' in the centos jenkins. I've clicked both now, just to be sure :-] """

See the full comment at https://github.com/SSSD/sssd/pull/658#issuecomment-423311945

jhrozek

9:55 p.m.

New subject: [sssd PR#658][comment] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains

jhrozek commented: """ the previous comment had a typo :-) But more importantly, I'm not sure why the centos CI didn't start automatically, @mrniranjan should be in the whitelist by now.

I suspect it was just a PEBKAC and I might have not clicked 'apply' but only 'save' in the centos jenkins when I was adding @mrniranjan to the whitelist. I've clicked both now, just to be sure :-] """

See the full comment at https://github.com/SSSD/sssd/pull/658#issuecomment-423311945

jhrozek

21 Sep 21 Sep

9:31 a.m.

New subject: [sssd PR#658][comment] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains

jhrozek commented: """ retest this please """

See the full comment at https://github.com/SSSD/sssd/pull/658#issuecomment-423441455

jhrozek

9:31 a.m.

New subject: [sssd PR#658][comment] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains

jhrozek commented: """ It's strange that the centos CI is failing, the internal CI passed just fine..so I rescheduled the job, let's see what happens. """

See the full comment at https://github.com/SSSD/sssd/pull/658#issuecomment-423441554

jhrozek

24 Sep 24 Sep

1:21 p.m.

New subject: [sssd PR#658][+Changes requested] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains

Label: +Changes requested

mrniranjan

5:32 p.m.

New subject: [sssd PR#658][synchronized] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Author: mrniranjan Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/658/head:pr658 git checkout pr658

mrniranjan

5:36 p.m.

New subject: [sssd PR#658][synchronized] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Author: mrniranjan Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/658/head:pr658 git checkout pr658

mrniranjan

5:45 p.m.

New subject: [sssd PR#658][synchronized] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Author: mrniranjan Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/658/head:pr658 git checkout pr658

jhrozek

8:30 p.m.

New subject: [sssd PR#658][comment] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains

jhrozek commented: """ On Mon, Sep 24, 2018 at 05:09:51AM -0700, Niranjan Mallapadi wrote:

...

mrniranjan commented on this pull request.

...

no_passwd = [(ldap.MOD_ADD, 'sudoOption', '!authenticate'.encode('utf-8'))]
try:
   (_, _) = ldap_inst.add_entry(sudo_attr1, capsrule_dn1)
except LdapException:
   pytest.fail("Failed to add %s rule in ldap" % (capsrule_dn1))
try:
   (_, _) = ldap_inst.add_entry(sudo_attr2, capsrule_dn2)
except LdapException:
   pytest.fail("Failed to add %s rule in ldap" % (capsrule_dn2))
else:
   (_, _) = ldap_inst.modify_ldap(capsrule_dn1, no_passwd)
   (_, _) = ldap_inst.modify_ldap(capsrule_dn2, no_passwd)
+@pytest.fixture +def enable_sss_sudo_nsswitch(session_multihost, tmpdir, request):

authselect doesn't do it by default, Not sure if that's bug, currently authselect adds sss to passwd,group,netgroup,automount, services.

Also "sudoers: files " entry doesn't exist in default /etc/nsswith.conf

OK, interesting, then this change makes sense.

"""

See the full comment at https://github.com/SSSD/sssd/pull/658#issuecomment-424077897

mrniranjan

25 Sep 25 Sep

4:25 a.m.

New subject: [sssd PR#658][synchronized] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Author: mrniranjan Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/658/head:pr658 git checkout pr658

mrniranjan

4:34 a.m.

New subject: [sssd PR#658][synchronized] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Author: mrniranjan Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/658/head:pr658 git checkout pr658

mrniranjan

5:43 a.m.

New subject: [sssd PR#658][synchronized] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Author: mrniranjan Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/658/head:pr658 git checkout pr658

mrniranjan

26 Sep 26 Sep

2:35 p.m.

New subject: [sssd PR#658][synchronized] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Author: mrniranjan Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/658/head:pr658 git checkout pr658

jhrozek

27 Sep 27 Sep

2:10 p.m.

New subject: [sssd PR#658][-Changes requested] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains

Label: -Changes requested

mrniranjan

29 Sep 29 Sep

5:46 a.m.

New subject: [sssd PR#658][comment] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains

mrniranjan commented: """ @jhrozek can you review this """

See the full comment at https://github.com/SSSD/sssd/pull/658#issuecomment-425612963

jhrozek

1 Oct 1 Oct

12:17 p.m.

New subject: [sssd PR#658][comment] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains

jhrozek commented: """ Thank you for the patches. The tests work. I only have some questions about the patches inline. But they are not urgent, feel free to fix or not as you see fit. """

See the full comment at https://github.com/SSSD/sssd/pull/658#issuecomment-425857548

mrniranjan

12:28 p.m.

New subject: [sssd PR#658][synchronized] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Author: mrniranjan Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/658/head:pr658 git checkout pr658

mrniranjan

12:39 p.m.

New subject: [sssd PR#658][synchronized] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Author: mrniranjan Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/658/head:pr658 git checkout pr658

jhrozek

1:16 p.m.

New subject: [sssd PR#658][+Accepted] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains

Label: +Accepted

mrniranjan

1:18 p.m.

New subject: [sssd PR#658][synchronized] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Author: mrniranjan Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/658/head:pr658 git checkout pr658

jhrozek

9:30 p.m.

New subject: [sssd PR#658][comment] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains

jhrozek commented: """ * master: 0e8f9ffe9d34ff664304a8b5f18827b175285eae 56842e706c26cd4cce6a3fbd2e175e844f75887f 78333065761450873a1855aa41e28761299851e2 58d11ae61dfc5d5fb95ee38de10f3637bc8edd53 2ac3efd1173af62c3bb4b8fb3a823330529bbc22 a62caa0e396eac08d4d225142a63003b2b2ba061 4276b3f73d26f9fb7fdd39e1443df5301f96a099 """

See the full comment at https://github.com/SSSD/sssd/pull/658#issuecomment-426033592

jhrozek

9:30 p.m.

New subject: [sssd PR#658][closed] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Author: mrniranjan Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains Action: closed

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/658/head:pr658 git checkout pr658

jhrozek

9:31 p.m.

New subject: [sssd PR#658][+Pushed] pytest: Test case for sudo: search with lower cased name for case insensitive domains

URL: https://github.com/SSSD/sssd/pull/658 Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive domains

Label: +Pushed

2758

Age (days ago)

2769

Last active (days ago)

sssd-devel@lists.fedorahosted.org

26 comments

4 participants

tags (0)

participants (4)

centos-ci
jhrozek
mrniranjan
sumit-bose