[sssd PR#1015][opened] proxy: allow proxy provider to start without having proxy_resolver_lib_name set
URL: https://github.com/SSSD/sssd/pull/1015 Author: pbrezina Title: #1015: proxy: allow proxy provider to start without having proxy_resolver_lib_name set Action: opened
PR body: """ Proxy provider fails to start unless `proxy_resolver_lib_name` is set since recent hosts resolver addition. This would impact all existing proxy provider configurations.
This patch makes sure that proxy resolver is disabled if the option is not set but other functions are not affected. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/1015/head:pr1015 git checkout pr1015
URL: https://github.com/SSSD/sssd/pull/1015 Title: #1015: proxy: allow proxy provider to start without having proxy_resolver_lib_name set
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/1015 Title: #1015: proxy: allow proxy provider to start without having proxy_resolver_lib_name set
alexey-tikhonov commented: """ Patch itself is fine.
But I wonder if `dp_target_init()` should free `target->methods` in case `(!target->explicitly_configured && (ret == ELIBBAD || ret == ENOTSUP)` """
See the full comment at https://github.com/SSSD/sssd/pull/1015#issuecomment-607872006
URL: https://github.com/SSSD/sssd/pull/1015 Title: #1015: proxy: allow proxy provider to start without having proxy_resolver_lib_name set
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/1015 Author: pbrezina Title: #1015: proxy: allow proxy provider to start without having proxy_resolver_lib_name set Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/1015/head:pr1015 git checkout pr1015
URL: https://github.com/SSSD/sssd/pull/1015 Title: #1015: proxy: allow proxy provider to start without having proxy_resolver_lib_name set
pbrezina commented: """ Thank you. It seems to be safe to free it. I added new commit to the patch set. """
See the full comment at https://github.com/SSSD/sssd/pull/1015#issuecomment-608376669
URL: https://github.com/SSSD/sssd/pull/1015 Title: #1015: proxy: allow proxy provider to start without having proxy_resolver_lib_name set
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/1015 Title: #1015: proxy: allow proxy provider to start without having proxy_resolver_lib_name set
alexey-tikhonov commented: """ I only have tiny nitpick - please see inline.
Otherwise everything is fine. """
See the full comment at https://github.com/SSSD/sssd/pull/1015#issuecomment-608555212
URL: https://github.com/SSSD/sssd/pull/1015 Title: #1015: proxy: allow proxy provider to start without having proxy_resolver_lib_name set
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/1015 Author: pbrezina Title: #1015: proxy: allow proxy provider to start without having proxy_resolver_lib_name set Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/1015/head:pr1015 git checkout pr1015
URL: https://github.com/SSSD/sssd/pull/1015 Title: #1015: proxy: allow proxy provider to start without having proxy_resolver_lib_name set
pbrezina commented: """ Good idea. Switched to zfree. """
See the full comment at https://github.com/SSSD/sssd/pull/1015#issuecomment-609676556
URL: https://github.com/SSSD/sssd/pull/1015 Title: #1015: proxy: allow proxy provider to start without having proxy_resolver_lib_name set
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/1015 Author: pbrezina Title: #1015: proxy: allow proxy provider to start without having proxy_resolver_lib_name set Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/1015/head:pr1015 git checkout pr1015
URL: https://github.com/SSSD/sssd/pull/1015 Title: #1015: proxy: allow proxy provider to start without having proxy_resolver_lib_name set
alexey-tikhonov commented: """ Thank you. Ack. """
See the full comment at https://github.com/SSSD/sssd/pull/1015#issuecomment-610215813
URL: https://github.com/SSSD/sssd/pull/1015 Title: #1015: proxy: allow proxy provider to start without having proxy_resolver_lib_name set
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/1015 Title: #1015: proxy: allow proxy provider to start without having proxy_resolver_lib_name set
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/1015 Title: #1015: proxy: allow proxy provider to start without having proxy_resolver_lib_name set
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/1015 Title: #1015: proxy: allow proxy provider to start without having proxy_resolver_lib_name set
pbrezina commented: """ * `master` * 41220021d21b7711a416b5aeb8446c14dd931140 - dp: free methods if target is not configured * 23c2d376b83a101b904ae6be3129841a723c336d - be: add BE_REQ_HOST to be_req2str * c7d328ea95324060b3be9b67ae70be8e8c70fad8 - proxy: do not fail if proxy_resolver_lib_name is not set
"""
See the full comment at https://github.com/SSSD/sssd/pull/1015#issuecomment-611471868
URL: https://github.com/SSSD/sssd/pull/1015 Title: #1015: proxy: allow proxy provider to start without having proxy_resolver_lib_name set
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/1015 Title: #1015: proxy: allow proxy provider to start without having proxy_resolver_lib_name set
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/1015 Title: #1015: proxy: allow proxy provider to start without having proxy_resolver_lib_name set
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/1015 Author: pbrezina Title: #1015: proxy: allow proxy provider to start without having proxy_resolver_lib_name set Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/1015/head:pr1015 git checkout pr1015
sssd-devel@lists.fedorahosted.org
-
alexey-tikhonov -
pbrezina