[sssd PR#610][opened] AD: consult the Partial Attribute Set instead of searching the GC for POSIX attributes
3:03 p.m.
URL: https://github.com/SSSD/sssd/pull/610
Author: jhrozek
Title: #610: AD: consult the Partial Attribute Set instead of searching the GC for POSIX
attributes
Action: opened
PR body:
"""
These patches implement fixes that should improve the performance of
detecting the presence of the POSIX attributes in the Global Catalog.
Instead of running the full search `(|(uidNumber=*)(gidNumber=*))` with
sizelimit=1 which causes the server to first find a full page of results
and then return only one, consult the AD schema which marks the attributes
replicated to the Global Catalog.
More details are described in the desing page PR at
https://pagure.io/SSSD/docs/pull-request/69
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/610/head:pr610
git checkout pr610
3:09 p.m.
New subject: [sssd PR#610][comment] AD: consult the Partial Attribute Set instead of searching the GC for POSIX attributes
URL: https://github.com/SSSD/sssd/pull/610
Title: #610: AD: consult the Partial Attribute Set instead of searching the GC for POSIX
attributes
jhrozek commented:
"""
So one thing I was not sure about myself is whether the check should be re-run each time
SSSD cycles between online and offline mode.
"""
See the full comment at https://github.com/SSSD/sssd/pull/610#issuecomment-401630062
7:27 a.m.
New subject: [sssd PR#610][comment] AD: consult the Partial Attribute Set instead of searching the GC for POSIX attributes
URL: https://github.com/SSSD/sssd/pull/610
Title: #610: AD: consult the Partial Attribute Set instead of searching the GC for POSIX
attributes
pbrezina commented:
"""
If I understand it correctly, this check is only one query and should be fast. How about
running it as an online callback and do not run it as part of request? It would clear the
code a little.
"""
See the full comment at https://github.com/SSSD/sssd/pull/610#issuecomment-401787672
10:54 a.m.
New subject: [sssd PR#610][comment] AD: consult the Partial Attribute Set instead of searching the GC for POSIX attributes
URL: https://github.com/SSSD/sssd/pull/610
Title: #610: AD: consult the Partial Attribute Set instead of searching the GC for POSIX
attributes
jhrozek commented:
"""
Hmm maybe not as an online callback because I’m afraid that might be racy but I wonder
about extending the sub domain request (which is already sent by responders to avoid races
and then also wired to online or offline events)
Thanks for the suggestion
Sent from my iPhone
On 2 Jul 2018, at 14:27, Pavel Březina
<notifications(a)github.com> wrote:
If I understand it correctly, this check is only one query and should be fast. How about
running it as an online callback and do not run it as part of request? It would clear the
code a little.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
"""
See the full comment at https://github.com/SSSD/sssd/pull/610#issuecomment-401851036
3:45 p.m.
New subject: [sssd PR#610][synchronized] AD: consult the Partial Attribute Set instead of searching the GC for POSIX attributes
URL: https://github.com/SSSD/sssd/pull/610
Author: jhrozek
Title: #610: AD: consult the Partial Attribute Set instead of searching the GC for POSIX
attributes
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/610/head:pr610
git checkout pr610
3:46 p.m.
New subject: [sssd PR#610][comment] AD: consult the Partial Attribute Set instead of searching the GC for POSIX attributes
URL: https://github.com/SSSD/sssd/pull/610
Title: #610: AD: consult the Partial Attribute Set instead of searching the GC for POSIX
attributes
jhrozek commented:
"""
I reworked the patches. I still need to fix the design page to match the new code, but I
hope the commit messages are clear enough for the time being.
"""
See the full comment at https://github.com/SSSD/sssd/pull/610#issuecomment-403315949
4:15 a.m.
New subject: [sssd PR#610][comment] AD: consult the Partial Attribute Set instead of searching the GC for POSIX attributes
URL: https://github.com/SSSD/sssd/pull/610
Title: #610: AD: consult the Partial Attribute Set instead of searching the GC for POSIX
attributes
pbrezina commented:
"""
This is very nice Jakub. Ack.
"""
See the full comment at https://github.com/SSSD/sssd/pull/610#issuecomment-403414183
4:15 a.m.
New subject: [sssd PR#610][+Accepted] AD: consult the Partial Attribute Set instead of searching the GC for POSIX attributes
URL: https://github.com/SSSD/sssd/pull/610
Title: #610: AD: consult the Partial Attribute Set instead of searching the GC for POSIX
attributes
Label: +Accepted
10:13 a.m.
New subject: [sssd PR#610][comment] AD: consult the Partial Attribute Set instead of searching the GC for POSIX attributes
URL: https://github.com/SSSD/sssd/pull/610
Title: #610: AD: consult the Partial Attribute Set instead of searching the GC for POSIX
attributes
jhrozek commented:
"""
The design document at https://pagure.io/SSSD/docs/pull-request/69 was updated. I mostly
touched the overview and implementation details part.
"""
See the full comment at https://github.com/SSSD/sssd/pull/610#issuecomment-403514017
6:29 a.m.
New subject: [sssd PR#610][comment] AD: consult the Partial Attribute Set instead of searching the GC for POSIX attributes
URL: https://github.com/SSSD/sssd/pull/610
Title: #610: AD: consult the Partial Attribute Set instead of searching the GC for POSIX
attributes
jhrozek commented:
"""
* master:
* 5b2b6493dfb3c1f2cb945356e34c70d8c5d64185
* 8d78119811e2572bb1a05da5abb7c5a2d43d1f97
* 4273ac0490eeef72d2daa0c7f6cee80d65b6b34d
* ba96e7b839b875946f03787a3a57f259230a0fef
* c8d1c1b734a1763b3e1233f060cc5c8d6db078e9
"""
See the full comment at https://github.com/SSSD/sssd/pull/610#issuecomment-403790501
6:29 a.m.
New subject: [sssd PR#610][closed] AD: consult the Partial Attribute Set instead of searching the GC for POSIX attributes
URL: https://github.com/SSSD/sssd/pull/610
Author: jhrozek
Title: #610: AD: consult the Partial Attribute Set instead of searching the GC for POSIX
attributes
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/610/head:pr610
git checkout pr610
6:29 a.m.
New subject: [sssd PR#610][+Pushed] AD: consult the Partial Attribute Set instead of searching the GC for POSIX attributes
URL: https://github.com/SSSD/sssd/pull/610
Title: #610: AD: consult the Partial Attribute Set instead of searching the GC for POSIX
attributes
Label: +Pushed
2123
days inactive
2132
days old
sssd-devel@lists.fedorahosted.org
11 comments
2 participants
participants (2)
-
jhrozek -
pbrezina