URL: https://github.com/SSSD/sssd/pull/458 Author: sumit-bose Title: #458: overrides: fixes for sysdb_invalidate_overrides() Action: opened
PR body: """ There were two issues in sysdb_invalidate_overrides().
First, SYSDB_CACHE_EXPIRE was only reset for the entry in the data cache but not in the timestamp cache.
Second, if one of the steps in the combined replace and delete operation failed no change was committed to the cache. If, for whatever reasons, a user or group object didn't had SYSDB_OVERRIDE_DN set the delete failed and hence SYSDB_CACHE_EXPIRE wasn't reset as well. To make sure the cache is in a consistent state after a view change the replace and the delete operations are don in two steps.
Related to https://pagure.io/SSSD/sssd/issue/3579 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/458/head:pr458 git checkout pr458
URL: https://github.com/SSSD/sssd/pull/458 Title: #458: overrides: fixes for sysdb_invalidate_overrides()
fidencio commented: """ Manual test went fine and our internal CI passed without issues.
CI: http://vm-031.$%7Babc%7D/logs/job/82/02/summary.html
"""
See the full comment at https://github.com/SSSD/sssd/pull/458#issuecomment-348498386
URL: https://github.com/SSSD/sssd/pull/458 Title: #458: overrides: fixes for sysdb_invalidate_overrides()
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/458 Author: sumit-bose Title: #458: overrides: fixes for sysdb_invalidate_overrides() Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/458/head:pr458 git checkout pr458
URL: https://github.com/SSSD/sssd/pull/458 Title: #458: overrides: fixes for sysdb_invalidate_overrides()
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/458 Title: #458: overrides: fixes for sysdb_invalidate_overrides()
sumit-bose commented: """ Thank you for the review, the latest version includes both of your comments. """
See the full comment at https://github.com/SSSD/sssd/pull/458#issuecomment-348518269
URL: https://github.com/SSSD/sssd/pull/458 Title: #458: overrides: fixes for sysdb_invalidate_overrides()
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/458 Title: #458: overrides: fixes for sysdb_invalidate_overrides()
fidencio commented: """ Thanks! Added the "Accepted" label! """
See the full comment at https://github.com/SSSD/sssd/pull/458#issuecomment-348520966
URL: https://github.com/SSSD/sssd/pull/458 Title: #458: overrides: fixes for sysdb_invalidate_overrides()
lslebodn commented: """ master: * a52226c651308a0a7732544b492eb4db56b84f1d * f29040342a6d69e170f4543662621f2e27221f91 * 919b5d76057d31877e0c25ca495711ff76c713d6 * 4671acb949c65c5c080532e03b1b6f1c9377a6a5 * 7988988aab5bd0249476671b850eb3909aa753f8 * b6d3da6cfe78c6d0ddb854088bc23e293b336401 """
See the full comment at https://github.com/SSSD/sssd/pull/458#issuecomment-348526269
URL: https://github.com/SSSD/sssd/pull/458 Author: sumit-bose Title: #458: overrides: fixes for sysdb_invalidate_overrides() Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/458/head:pr458 git checkout pr458
URL: https://github.com/SSSD/sssd/pull/458 Title: #458: overrides: fixes for sysdb_invalidate_overrides()
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
fidencio -
lslebodn
-
sumit-bose