[sssd PR#249][opened] DP: Reduce Data Provider log level noise

[justin-stephenson]

URL: https://github.com/SSSD/sssd/pull/249
Author: justin-stephenson
 Title: #249: DP: Reduce Data Provider log level noise
Action: opened

PR body:
"""

Certain operations are not supported with certain providers
causing informational Data Provider log messages to be logged as
errors or failures. This patch lowers the log level to reduce overall
log noise and ensure only critical log messages are logged when
a low debug_level value is used.

Resolves:
https://pagure.io/SSSD/sssd/issue/3287
https://pagure.io/SSSD/sssd/issue/3278

Tested with the LDAP provider changing ``debug_level``
between 7 and 1 then checking for log messages:

* Before patch with **debug_level=1**
```
# egrep 'dp_find_method|dp_target_init|Data Provider returned' /var/log/sssd/*
[dp_target_init] (0x0020): Target [selinux] is not supported by module [ldap].
[dp_target_init] (0x0020): Target [hostid] is not supported by module [ldap].
[dp_target_init] (0x0020): Target [subdomains] is not supported by module [ldap].
[dp_find_method] (0x0020): Target [subdomains] is not initialized
[dp_find_method] (0x0020): Target [subdomains] is not initialized
[dp_find_method] (0x0020): Target [subdomains] is not initialized
[dp_find_method] (0x0020): Target [subdomains] is not initialized
[sss_dp_get_reply] (0x0010): The Data Provider returned an error [org.freedesktop.sssd.Error.DataProvider.NotSupported]
[sss_dp_get_reply] (0x0010): The Data Provider returned an error [org.freedesktop.sssd.Error.DataProvider.NotSupported]
[sss_dp_get_reply] (0x0010): The Data Provider returned an error [org.freedesktop.sssd.Error.DataProvider.NotSupported]
[sss_dp_get_reply] (0x0010): The Data Provider returned an error [org.freedesktop.sssd.Error.DataProvider.NotSupported]
```

* After patch with **debug_level=1**
```
# egrep 'dp_find_method|dp_target_init|Data Provider returned' /var/log/sssd/*
#

```
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/249/head:pr249
git checkout pr249

[sssd PR#249][comment] DP: Reduce Data Provider log level noise

[centos-ci]

URL: https://github.com/SSSD/sssd/pull/249
Title: #249: DP: Reduce Data Provider log level noise

centos-ci commented:
"""
Can one of the admins verify this patch?
"""

See the full comment at https://github.com/SSSD/sssd/pull/249#issuecomment-297539055

[sssd PR#249][comment] DP: Reduce Data Provider log level noise

[centos-ci]

URL: https://github.com/SSSD/sssd/pull/249
Title: #249: DP: Reduce Data Provider log level noise

centos-ci commented:
"""
Can one of the admins verify this patch?
"""

See the full comment at https://github.com/SSSD/sssd/pull/249#issuecomment-297539057

[sssd PR#249][comment] DP: Reduce Data Provider log level noise

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/249
Title: #249: DP: Reduce Data Provider log level noise

jhrozek commented:
"""
ok to test
"""

See the full comment at https://github.com/SSSD/sssd/pull/249#issuecomment-297544662

[sssd PR#249][+Changes requested] DP: Reduce Data Provider log level noise

[fidencio]

URL: https://github.com/SSSD/sssd/pull/249
Title: #249: DP: Reduce Data Provider log level noise

Label: +Changes requested

[sssd PR#249][comment] DP: Reduce Data Provider log level noise

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/249
Title: #249: DP: Reduce Data Provider log level noise

jhrozek commented:
"""
Maybe it would help to just remove the "Error:" prefix since in most conditions this is an expected message?
"""

See the full comment at https://github.com/SSSD/sssd/pull/249#issuecomment-299200620

[sssd PR#249][synchronized] DP: Reduce Data Provider log level noise

[justin-stephenson]

URL: https://github.com/SSSD/sssd/pull/249
Author: justin-stephenson
 Title: #249: DP: Reduce Data Provider log level noise
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/249/head:pr249
git checkout pr249

[sssd PR#249][comment] DP: Reduce Data Provider log level noise

[justin-stephenson]

URL: https://github.com/SSSD/sssd/pull/249
Title: #249: DP: Reduce Data Provider log level noise

justin-stephenson commented:
"""
Thanks for the review, patch updated.
"""

See the full comment at https://github.com/SSSD/sssd/pull/249#issuecomment-299542958

[sssd PR#249][comment] DP: Reduce Data Provider log level noise

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/249
Title: #249: DP: Reduce Data Provider log level noise

jhrozek commented:
"""
LGTM, if @pbrezina and @fidencio agree, we should push the patch.
"""

See the full comment at https://github.com/SSSD/sssd/pull/249#issuecomment-299861935

[sssd PR#249][-Changes requested] DP: Reduce Data Provider log level noise

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/249
Title: #249: DP: Reduce Data Provider log level noise

Label: -Changes requested

[sssd PR#249][synchronized] DP: Reduce Data Provider log level noise

[justin-stephenson]

URL: https://github.com/SSSD/sssd/pull/249
Author: justin-stephenson
 Title: #249: DP: Reduce Data Provider log level noise
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/249/head:pr249
git checkout pr249

[sssd PR#249][comment] DP: Reduce Data Provider log level noise

[justin-stephenson]

URL: https://github.com/SSSD/sssd/pull/249
Title: #249: DP: Reduce Data Provider log level noise

justin-stephenson commented:
"""
Fixed indentation, updated. Thank you.
"""

See the full comment at https://github.com/SSSD/sssd/pull/249#issuecomment-299905943

[sssd PR#249][comment] DP: Reduce Data Provider log level noise

[fidencio]

URL: https://github.com/SSSD/sssd/pull/249
Title: #249: DP: Reduce Data Provider log level noise

fidencio commented:
"""
On Mon, May 8, 2017 at 5:45 PM, Justin Stephenson 
wrote:
> Fixed indentation, updated. Thank you.

Ack from me!
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> https://github.com/SSSD/sssd/pull/249#issuecomment-299905943, or mute
> the thread
> https://github.com/notifications/unsubscribe-auth/AAG4ejGn1l842hRuTW35hd3OxYhXCVaTks5r3zi0gaJpZM4NJakQ
> .

"""

See the full comment at https://github.com/SSSD/sssd/pull/249#issuecomment-299933501

[sssd PR#249][comment] DP: Reduce Data Provider log level noise

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/249
Title: #249: DP: Reduce Data Provider log level noise

pbrezina commented:
"""
Ack.
"""

See the full comment at https://github.com/SSSD/sssd/pull/249#issuecomment-300109611

[sssd PR#249][+Accepted] DP: Reduce Data Provider log level noise

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/249
Title: #249: DP: Reduce Data Provider log level noise

Label: +Accepted

[sssd PR#249][comment] DP: Reduce Data Provider log level noise

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/249
Title: #249: DP: Reduce Data Provider log level noise

jhrozek commented:
"""
* master: e98d085b529e0ae5e07a717ce3b30f3943be0ee0
"""

See the full comment at https://github.com/SSSD/sssd/pull/249#issuecomment-300136133

[sssd PR#249][+Pushed] DP: Reduce Data Provider log level noise

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/249
Title: #249: DP: Reduce Data Provider log level noise

Label: +Pushed

[sssd PR#249][closed] DP: Reduce Data Provider log level noise

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/249
Author: justin-stephenson
 Title: #249: DP: Reduce Data Provider log level noise
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/249/head:pr249
git checkout pr249

[sssd PR#249][comment] DP: Reduce Data Provider log level noise

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/249
Title: #249: DP: Reduce Data Provider log level noise

jhrozek commented:
"""
Also sssd-1-14: 82a62c650243283d2e8a5177e0f9f35ef1b3478c
"""

See the full comment at https://github.com/SSSD/sssd/pull/249#issuecomment-300137262