[sssd PR#558][opened] WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/558
Author: jhrozek
 Title: #558: WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache
Action: opened

PR body:
"""
This is a WIP on adding tests for the sss_nss_ex interface. I covered only the sss_nss_getgrouplist_timeout function so far.

I'm submitting the PR already in this state to get some feedback if this
coverage is enough and the other functions can be covered similarly or
if there is some issue with this approach.

Also, I found a bug in invalidating the initgroups memory cache, that's
the first of the two patches. Here I'm really not sure if the fix is even
how the issue should be fixed, so I just hacked something up, even without
allocation checks etc.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/558/head:pr558
git checkout pr558

[sssd PR#558][comment] WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/558
Title: #558: WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

jhrozek commented:
"""
btw a hopefully better description of the invalidating memcache issue is in https://pagure.io/SSSD/sssd/issue/3718
"""

See the full comment at https://github.com/SSSD/sssd/pull/558#issuecomment-383959439

[sssd PR#558][comment] WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/558
Title: #558: WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

pbrezina commented:
"""
Test looks good, but I will need better explanation of the issue in the first patch. Even pagure ticket is not verbose enough for me :-)
"""

See the full comment at https://github.com/SSSD/sssd/pull/558#issuecomment-384946429

[sssd PR#558][comment] WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/558
Title: #558: WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

sumit-bose commented:
"""
@pbrezina, maybe https://docs.pagure.org/SSSD.sssd/developers/mmap_cache_1.15.html#the-initgr... can help to explain the peculiars of the name handling of the memory cache with initgroups requests.
"""

See the full comment at https://github.com/SSSD/sssd/pull/558#issuecomment-384958801

[sssd PR#558][synchronized] WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/558
Author: jhrozek
 Title: #558: WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/558/head:pr558
git checkout pr558

[sssd PR#558][comment] WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/558
Title: #558: WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

sumit-bose commented:
"""
retest this, please
"""

See the full comment at https://github.com/SSSD/sssd/pull/558#issuecomment-456086426

[sssd PR#558][comment] WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/558
Title: #558: WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

jhrozek commented:
"""
Just to explain why I pushed a new version: I didn't actually do anything new in this branch, but yesterday for some reason I don't understand all my partitions switched to read-only mode while on the train so I force-pushed my local git repo to github to have the most current snapshot in case my disk was about to die...and I didn't realize this would also propagate to the PRs.
"""

See the full comment at https://github.com/SSSD/sssd/pull/558#issuecomment-456144794

[sssd PR#558][synchronized] WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/558
Author: jhrozek
 Title: #558: WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/558/head:pr558
git checkout pr558

[sssd PR#558][comment] WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/558
Title: #558: WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

jhrozek commented:
"""
Rebased per @pbrezina 's request
"""

See the full comment at https://github.com/SSSD/sssd/pull/558#issuecomment-528062310

[sssd PR#558][comment] WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/558
Title: #558: WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

pbrezina commented:
"""
Some of the tests fails. @jhrozek Is this still a wip? Should I take it over?
"""

See the full comment at https://github.com/SSSD/sssd/pull/558#issuecomment-549309392

[sssd PR#558][comment] WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/558
Title: #558: WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

jhrozek commented:
"""
Maybe? I don't plan on working on this, so do whatever you like..
"""

See the full comment at https://github.com/SSSD/sssd/pull/558#issuecomment-549329226