7:05 a.m.
URL: https://github.com/SSSD/sssd/pull/503
Author: lslebodn
Title: #503: Regression test for false possitive "corrupted" memory cache
Action: opened
PR body:
"""
Resolves:
https://pagure.io/SSSD/sssd/issue/3592
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/503/head:pr503
git checkout pr503
7:07 a.m.
New subject: [sssd PR#503][comment] Regression test for false possitive "corrupted" memory cache
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
lslebodn commented:
"""
You can revert 4382047 for testing purposes to ensure that test fails
"""
See the full comment at https://github.com/SSSD/sssd/pull/503#issuecomment-360126168
1:44 p.m.
New subject: [sssd PR#503][comment] Regression test for false possitive "corrupted" memory cache
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
sumit-bose commented:
"""
Thank you for the test. It works well and fails is the fix is removed.
I agree with removing memchr() from the client code as well.
I wonder if it is really needed to add murmurhash3_bin. Wouldn't it be possible to add
an optional flags argument to murmurhash3 and set a flag if the trailing \0 should be
include in the hash calculation?
"""
See the full comment at https://github.com/SSSD/sssd/pull/503#issuecomment-360250930
1:45 p.m.
New subject: [sssd PR#503][comment] Regression test for false possitive "corrupted" memory cache
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
sumit-bose commented:
"""
CI passes as well with the current exception of Debian
http://vm-031.../logs/job/83/10/summary.html.
"""
See the full comment at https://github.com/SSSD/sssd/pull/503#issuecomment-360251316
3:18 a.m.
New subject: [sssd PR#503][comment] Regression test for false possitive "corrupted" memory cache
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
lslebodn commented:
"""
On (24/01/18 19:44), sumit-bose wrote:
I wonder if it is really needed to add murmurhash3_bin. Wouldn't
it be possible to add an optional flags argument to murmurhash3 and set a flag if the
trailing \0 should be include in the hash calculation?
That's is exatly what I am not sure as well. I even do not like name
`murmurhash3_bin`. Optional argument might be a solution because it will not
break API. Do you have some suggestion for the name?
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/503#issuecomment-360407425
3:29 a.m.
New subject: [sssd PR#503][comment] Regression test for false possitive "corrupted" memory cache
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
sumit-bose commented:
"""
@lslebodn, I would it call just 'flags' as e.g. open(2).
"""
See the full comment at https://github.com/SSSD/sssd/pull/503#issuecomment-360410544
3:40 a.m.
New subject: [sssd PR#503][comment] Regression test for false possitive "corrupted" memory cache
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
lslebodn commented:
"""
@lslebodn, I would it call just 'flags' as e.g. open(2).
It does not sounds to me very pythonic. I'll ask python gurus.
"""
See the full comment at https://github.com/SSSD/sssd/pull/503#issuecomment-360413452
10:54 a.m.
New subject: [sssd PR#503][synchronized] Regression test for false possitive "corrupted" memory cache
URL: https://github.com/SSSD/sssd/pull/503
Author: lslebodn
Title: #503: Regression test for false possitive "corrupted" memory cache
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/503/head:pr503
git checkout pr503
10:55 a.m.
New subject: [sssd PR#503][comment] Regression test for false possitive "corrupted" memory cache
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
lslebodn commented:
"""
@lslebodn, I would it call just 'flags' as e.g. open(2).
What about latest version?
It is be backward compatible including negative test cases. But it allows to pass `NUL`
character to input string.
"""
See the full comment at https://github.com/SSSD/sssd/pull/503#issuecomment-365672349
4:49 a.m.
New subject: [sssd PR#503][comment] Regression test for false possitive "corrupted" memory cache
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
sumit-bose commented:
"""
The latest version looks good. I'll run some local and CI test before giving ACK.
"""
See the full comment at https://github.com/SSSD/sssd/pull/503#issuecomment-365891089
6:26 a.m.
New subject: [sssd PR#503][comment] Regression test for false possitive "corrupted" memory cache
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
sumit-bose commented:
"""
ok, I have no further comments and CI passes as well
http://vm-031.../logs/job/84/09/summary.html (with the unrelated rawhide exception), so
ACK.
"""
See the full comment at https://github.com/SSSD/sssd/pull/503#issuecomment-365912414
6:26 a.m.
New subject: [sssd PR#503][+Accepted] Regression test for false possitive "corrupted" memory cache
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
Label: +Accepted
9:13 a.m.
New subject: [sssd PR#503][comment] Regression test for false possitive "corrupted" memory cache
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
lslebodn commented:
"""
Thank you for review.
"""
See the full comment at https://github.com/SSSD/sssd/pull/503#issuecomment-365956635
9:13 a.m.
New subject: [sssd PR#503][comment] Regression test for false possitive "corrupted" memory cache
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
lslebodn commented:
"""
master:
* 6dc1de9781ab211a43d24cbaed7969d98abc1cc1
* fd17e0925dbcafedb878ddf828a37743c115c9dd
* 8f83feea4586a8fcf4365e0d22e0a16740424cc2
* 41454a64c714e984423fd6e94ea89d183a73cc67
"""
See the full comment at https://github.com/SSSD/sssd/pull/503#issuecomment-365956707
1:56 p.m.
New subject: [sssd PR#503][+Pushed] Regression test for false possitive "corrupted" memory cache
URL: https://github.com/SSSD/sssd/pull/503
Title: #503: Regression test for false possitive "corrupted" memory cache
Label: +Pushed
1:56 p.m.
New subject: [sssd PR#503][closed] Regression test for false possitive "corrupted" memory cache
URL: https://github.com/SSSD/sssd/pull/503
Author: lslebodn
Title: #503: Regression test for false possitive "corrupted" memory cache
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/503/head:pr503
git checkout pr503
2262
days inactive
2284
days old
sssd-devel@lists.fedorahosted.org
15 comments
2 participants
participants (2)
-
lslebodn -
sumit-bose