[sssd PR#395][opened] KCM: Three trivial fixes

[jhrozek]

   URL: https://github.com/SSSD/sssd/pull/395
Author: jhrozek
 Title: #395: KCM: Three trivial fixes
Action: opened

PR body:
"""
I've been working on the KCM responder lately and found some minor issues
that can be merged right away.

1) KCM: Add some forgotten NULL checks

Several memory allocations across the KCM codebase did not check their
result for NULL. This patch fixes that.

2) KCM: Use the right memory context

Inside the tevent request, we should use 'state' as the intermediate memory
context and steal the result up to 'mem_ctx' on success.
'mem_ctx' itself should only be used to create the tevent_req as the first
thing during the request creation.

However, this bug is not very severe as the mem_ctx was always the KCM
operation memory context, so the memory was freed when the operation
terminated.

3) KCM: Do not leak newly created ccache in case the name is malformed

This is not a big deal as the mem_ctx parameter of the operation is
typically just a short-lived operation context. Nonetheless, it is best
practice to not rely on how the memory context is set up in utility
functions.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/395/head:pr395
git checkout pr395

[sssd PR#395][comment] KCM: Three trivial fixes

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/395
Title: #395: KCM: Three trivial fixes

fidencio commented:
"""
retest this, please
"""

See the full comment at https://github.com/SSSD/sssd/pull/395#issuecomment-332955622

[sssd PR#395][+Changes requested] KCM: Three trivial fixes

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/395
Title: #395: KCM: Three trivial fixes

Label: +Changes requested

[sssd PR#395][comment] KCM: Three trivial fixes

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/395
Title: #395: KCM: Three trivial fixes

fidencio commented:
"""
Okay, seems that the CentOS CI failure was just a fluke.

I will fire an internal CI build soon.
"""

See the full comment at https://github.com/SSSD/sssd/pull/395#issuecomment-333039546

[sssd PR#395][synchronized] KCM: Three trivial fixes

[jhrozek]

   URL: https://github.com/SSSD/sssd/pull/395
Author: jhrozek
 Title: #395: KCM: Three trivial fixes
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/395/head:pr395
git checkout pr395

[sssd PR#395][comment] KCM: Three trivial fixes

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/395
Title: #395: KCM: Three trivial fixes

jhrozek commented:
"""
Since new patches were pushed, removing the changes requested label.
"""

See the full comment at https://github.com/SSSD/sssd/pull/395#issuecomment-333589513

[sssd PR#395][-Changes requested] KCM: Three trivial fixes

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/395
Title: #395: KCM: Three trivial fixes

Label: -Changes requested

[sssd PR#395][comment] KCM: Three trivial fixes

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/395
Title: #395: KCM: Three trivial fixes

fidencio commented:
"""
Codewise, ACK.

When our internal CI issues are solved, I'll fire a build and add the
"Accepted" label.
"""

See the full comment at https://github.com/SSSD/sssd/pull/395#issuecomment-333849264

[sssd PR#395][comment] KCM: Three trivial fixes

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/395
Title: #395: KCM: Three trivial fixes

lslebodn commented:
"""
http://vm-058-233.$ABC/logs/job/78/65/summary.html
"""

See the full comment at https://github.com/SSSD/sssd/pull/395#issuecomment-334071462

[sssd PR#395][comment] KCM: Three trivial fixes

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/395
Title: #395: KCM: Three trivial fixes

lslebodn commented:
"""
master:
* 613a832d5bbf4c8174adbc1dcd881c59660cb0f1
* 3e4fe6cc59419ce4c178e9ad31cd1069ab375e9b
* 7f68de6c2e6aaed1929dfbcf1a73606c9b79fd64

"""

See the full comment at https://github.com/SSSD/sssd/pull/395#issuecomment-334071534

[sssd PR#395][closed] KCM: Three trivial fixes

[lslebodn]

   URL: https://github.com/SSSD/sssd/pull/395
Author: jhrozek
 Title: #395: KCM: Three trivial fixes
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/395/head:pr395
git checkout pr395

[sssd PR#395][+Pushed] KCM: Three trivial fixes

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/395
Title: #395: KCM: Three trivial fixes

Label: +Pushed