[sssd PR#583][opened] sudo/sysdb regressions

[fidencio]

URL: https://github.com/SSSD/sssd/pull/583
Author: fidencio
 Title: #583: sudo/sysdb regressions
Action: opened

PR body:
"""
This patch set consists in 3 patches:
- sudo_ldap: fix sudoHost=defaults -> cn=defaults: this is a typo that caused https://pagure.io/SSSD/sssd/issue/3742
- Revert "sysdb custom: completely replace old object instead of merging it": this one caused https://pagure.io/SSSD/sssd/issue/3733
- sysdb_sudo: completely replace old object instead of merging it: As far as I understand, the idea behind cd4590de was to never merged sudo rules. Instead, delete the old one and add the new one. However, doing this all over place caused the regression mentioned above. I've checked the other patches that leaded to this one and seems that keeping the "delete the old one and add the new one" approach may be the cleaner possible way.

@pbrezina, may I ask you to (re)test https://pagure.io/SSSD/sssd/issue/3558 in order to be sure that I won't be adding regressions while trying to fix regressions? Also, I do believe this approach is cleaner than adding a new boolean flag in sysdb_store_custom(), do you agree?
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/583/head:pr583
git checkout pr583

[sssd PR#583][comment] sudo/sysdb regressions

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/583
Title: #583: sudo/sysdb regressions

pbrezina commented:
"""
It is technically correct and it will solve the issue (I will test it later today or tomorrow). Having two rules  with same cn is a conflict and it may be worth documenting it in ldap_sudo_search_base.
"""

See the full comment at https://github.com/SSSD/sssd/pull/583#issuecomment-393143354

[sssd PR#583][comment] sudo/sysdb regressions

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/583
Title: #583: sudo/sysdb regressions

pbrezina commented:
"""
Thank you for looking into this.
"""

See the full comment at https://github.com/SSSD/sssd/pull/583#issuecomment-393143410

[sssd PR#583][comment] sudo/sysdb regressions

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/583
Title: #583: sudo/sysdb regressions

pbrezina commented:
"""
Works. Ack.
"""

See the full comment at https://github.com/SSSD/sssd/pull/583#issuecomment-393505453

[sssd PR#583][+Accepted] sudo/sysdb regressions

[fidencio]

URL: https://github.com/SSSD/sssd/pull/583
Title: #583: sudo/sysdb regressions

Label: +Accepted

[sssd PR#583][comment] sudo/sysdb regressions

[fidencio]

URL: https://github.com/SSSD/sssd/pull/583
Title: #583: sudo/sysdb regressions

fidencio commented:
"""
Adding the "Accepted" label as per https://github.com/SSSD/sssd/pull/583#issuecomment-393505453
"""

See the full comment at https://github.com/SSSD/sssd/pull/583#issuecomment-393568080

[sssd PR#583][comment] sudo/sysdb regressions

[fidencio]

URL: https://github.com/SSSD/sssd/pull/583
Title: #583: sudo/sysdb regressions

fidencio commented:
"""
master:
  179c7fb
  0f897b1
  f9e4c93
"""

See the full comment at https://github.com/SSSD/sssd/pull/583#issuecomment-393680322

[sssd PR#583][closed] sudo/sysdb regressions

[fidencio]

URL: https://github.com/SSSD/sssd/pull/583
Author: fidencio
 Title: #583: sudo/sysdb regressions
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/583/head:pr583
git checkout pr583

[sssd PR#583][-Accepted] sudo/sysdb regressions

[fidencio]

URL: https://github.com/SSSD/sssd/pull/583
Title: #583: sudo/sysdb regressions

Label: -Accepted

[sssd PR#583][+Pushed] sudo/sysdb regressions

[fidencio]

URL: https://github.com/SSSD/sssd/pull/583
Title: #583: sudo/sysdb regressions

Label: +Pushed