[sssd PR#904][opened] KCM: Set kdc_offset to zero initially

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/904
Author: jhrozek
 Title: #904: KCM: Set kdc_offset to zero initially
Action: opened

PR body:
"""
Resolves: https://pagure.io/SSSD/sssd/issue/4100

KCM assumed that the client library would always set the KDC offset, but 
that's not always the case, especially when using multiple krb contexts 
from the client application:
   https://bugzilla.redhat.com/show_bug.cgi?id=1757224#c64

Heimdal also creates ccaches with zero kdc_offset:

https://github.com/heimdal/heimdal/commit/9f58896af958ae5e6e3ebde8c48dad4eda... 
so we should do the same..
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/904/head:pr904
git checkout pr904

[sssd PR#904][comment] KCM: Set kdc_offset to zero initially

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/904
Title: #904: KCM: Set kdc_offset to zero initially

jhrozek commented:
"""
@frozencemetery Do you have an opinion about this one way or the other? This is related to https://bugzilla.redhat.com/show_bug.cgi?id=1757224
"""

See the full comment at https://github.com/SSSD/sssd/pull/904#issuecomment-542875335

[sssd PR#904][comment] KCM: Set kdc_offset to zero initially

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/904
Title: #904: KCM: Set kdc_offset to zero initially

mzidek-rh commented:
"""
I was one of the reviewers of the original patch, so I got another look at it and I think that setting the kdc_offset to INT32_MAX was a mistake that we did not catch.

FWIW this patch LGTM. But I would also like to hear what @frozencemetery thinks.
"""

See the full comment at https://github.com/SSSD/sssd/pull/904#issuecomment-542897369

[sssd PR#904][comment] KCM: Set kdc_offset to zero initially

[frozencemetery]

URL: https://github.com/SSSD/sssd/pull/904
Title: #904: KCM: Set kdc_offset to zero initially

frozencemetery commented:
"""
Thanks for your patience while I was PTO.

In the abstract, I think that 0 makes a lot more sense as an "unset" value than INT32_MAX :)  rhbz#1757224 was exposed because krb5 was fixed to actually honor the offset - before that, we were effectively always treating it as 0, which worked ~most of the time.

So +1 from me, especially since it fixes the issues we're seeing in the bug.  Thanks @jhrozek!
"""

See the full comment at https://github.com/SSSD/sssd/pull/904#issuecomment-543779505

[sssd PR#904][comment] KCM: Set kdc_offset to zero initially

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/904
Title: #904: KCM: Set kdc_offset to zero initially

mzidek-rh commented:
"""
Thanks @frozencemetery  for your input.

ACK.
"""

See the full comment at https://github.com/SSSD/sssd/pull/904#issuecomment-543783226

[sssd PR#904][+Accepted] KCM: Set kdc_offset to zero initially

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/904
Title: #904: KCM: Set kdc_offset to zero initially

Label: +Accepted

[sssd PR#904][+Ready to push] KCM: Set kdc_offset to zero initially

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/904
Title: #904: KCM: Set kdc_offset to zero initially

Label: +Ready to push

[sssd PR#904][comment] KCM: Set kdc_offset to zero initially

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/904
Title: #904: KCM: Set kdc_offset to zero initially

pbrezina commented:
"""
* `master`
    * 2c9bdcf579e430fa8f7e5595a17cf7242adb5216 - KCM: Set kdc_offset to zero initially

"""

See the full comment at https://github.com/SSSD/sssd/pull/904#issuecomment-544427829

[sssd PR#904][+Pushed] KCM: Set kdc_offset to zero initially

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/904
Title: #904: KCM: Set kdc_offset to zero initially

Label: +Pushed

[sssd PR#904][-Accepted] KCM: Set kdc_offset to zero initially

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/904
Title: #904: KCM: Set kdc_offset to zero initially

Label: -Accepted

[sssd PR#904][-Ready to push] KCM: Set kdc_offset to zero initially

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/904
Title: #904: KCM: Set kdc_offset to zero initially

Label: -Ready to push

[sssd PR#904][closed] KCM: Set kdc_offset to zero initially

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/904
Author: jhrozek
 Title: #904: KCM: Set kdc_offset to zero initially
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/904/head:pr904
git checkout pr904