URL: https://github.com/SSSD/sssd/pull/115 Author: sumit-bose Title: #115: libwbclient-sssd: wbcLookupSid() allow NULL arguments Action: opened
PR body: """ Some caller might not be interested in some of the values wbcLookupSid() returns and just pass NULL. Currently 'net ads user info' does this because it is not interested in the domain. wbcLookupSid() should handle this gracefully.
Resolves https://fedorahosted.org/sssd/ticket/3273
A unit-test for wbcLookupSid() is added as well. I had to wrap sss_nss_getnamebysid() because the test shouldn't connect to SSSD but just return some result. Interestingly the wrapping didn't work when I just added libwbclient.la to _LDADD but I had to explicitly add the needed sources. Does anyone know why? """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/115/head:pr115 git checkout pr115
URL: https://github.com/SSSD/sssd/pull/115 Title: #115: libwbclient-sssd: wbcLookupSid() allow NULL arguments
lslebodn commented: """ Works as expected
ACK
master: * 0b78b4e32955ced0f35c6d4685bd277bb03d04cb
sssd-1-14: * 924122b5457f8f93687a81d8171757c8036c8b0f
sssd-1-13: * d41d82fb81bb9c92aebd1ac955cb04ab62dd651e
"""
See the full comment at https://github.com/SSSD/sssd/pull/115#issuecomment-274282248
URL: https://github.com/SSSD/sssd/pull/115 Title: #115: libwbclient-sssd: wbcLookupSid() allow NULL arguments
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/115 Author: sumit-bose Title: #115: libwbclient-sssd: wbcLookupSid() allow NULL arguments Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/115/head:pr115 git checkout pr115
sssd-devel@lists.fedorahosted.org