-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 03/24/2010 09:49 AM, Jakub Hrozek wrote:
On 03/23/2010 01:10 PM, Simo Sorce wrote:
> On Tue, 23 Mar 2010 11:59:22 +0100
> Jakub Hrozek <jhrozek(a)redhat.com> wrote:
>> +
>> + cmd = talloc_asprintf(tctx, "%s %s", userdel_cmd,
>> + tctx->octx->name);
>> + if (!cmd) {
> Nack,
> if you do it this way you must shell escape the username.
> It's probably better to use fork/exec on our own, so you can precisely
> control the arguments w/o worrying about shell special characters.
> Simo.
Thanks for the review, a new patch is attached
Nack.
You can't return WTERMSIG(status) or WSTOPSIG(status), you're mixing
them with errno return codes.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkuzm3AACgkQeiVVYja6o6N2/wCdE4qgx17hoFN81VroZ6PxJPuj
QLsAn2iY+dsKrn8p0mFqJ/hGbXdwpy8N
=7Vwt
-----END PGP SIGNATURE-----