[PATCH] Couple bugfixing patches

[Jan Zelený]

Hi,
I'm sending couple patches fixing bugs I found in the code today:

jzeleny-020-fixed-debug-to-files.patch
This error caused that monitor didn't pass --debug-to-files option to
nss and pam services when creating them.

jzeleny-021-fixed-wrong-variable.patch
Current solution doesn't make any sense to me, I believe the original 
intention was as my patch suggests even though the line can be dropped 
entirely.

Jan

[Jakub Hrozek]

On 05/14/2011 01:23 AM, Jan Zeleny wrote:
> Hi,
> I'm sending couple patches fixing bugs I found in the code today:
>
> jzeleny-020-fixed-debug-to-files.patch
> This error caused that monitor didn't pass --debug-to-files option to
> nss and pam services when creating them.

Ack although it would be nice to make parse_args take multiple
whitespace, too, as we discussed on Friday:

https://fedorahosted.org/sssd/ticket/871
> jzeleny-021-fixed-wrong-variable.patch
> Current solution doesn't make any sense to me, I believe the original 
> intention was as my patch suggests even though the line can be dropped 
> entirely.

Yeah, harmless since sysdb_grouplist was set to NULL on declaration. But
I think setting it explicitly in the ENOENT case is more readable (and
perhaps even more robust should we ever refactor that function)

Ack

[Stephen Gallagher]

On Mon, 2011-05-16 at 10:59 +0200, Jakub Hrozek wrote:
> On 05/14/2011 01:23 AM, Jan Zeleny wrote:
> > Hi,
> > I'm sending couple patches fixing bugs I found in the code today:
> >
> > jzeleny-020-fixed-debug-to-files.patch
> > This error caused that monitor didn't pass --debug-to-files option to
> > nss and pam services when creating them.
>
> Ack although it would be nice to make parse_args take multiple
> whitespace, too, as we discussed on Friday:
>
> https://fedorahosted.org/sssd/ticket/871
> > jzeleny-021-fixed-wrong-variable.patch
> > Current solution doesn't make any sense to me, I believe the original 
> > intention was as my patch suggests even though the line can be dropped 
> > entirely.
>
> Yeah, harmless since sysdb_grouplist was set to NULL on declaration. But
> I think setting it explicitly in the ENOENT case is more readable (and
> perhaps even more robust should we ever refactor that function)
>
> Ack

Pushed to master