-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
We weren't verifying that the file descriptor that we get back from openldap was valid. This patch checks that the file descriptor is >= 0 before returning it.
There's another (arguable) bug here in libtevent. Libtevent should probably not return success for tevent_add_fd() when fd < 0 (especially since it crashes). I'll open a bug upstream.
Fixes https://fedorahosted.org/sssd/ticket/797 and https://bugzilla.redhat.com/show_bug.cgi?id=676027
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
On Mon, Feb 14, 2011 at 10:15:39AM -0500, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
We weren't verifying that the file descriptor that we get back from openldap was valid. This patch checks that the file descriptor is >= 0 before returning it.
There's another (arguable) bug here in libtevent. Libtevent should probably not return success for tevent_add_fd() when fd < 0 (especially since it crashes). I'll open a bug upstream.
Fixes https://fedorahosted.org/sssd/ticket/797 and https://bugzilla.redhat.com/show_bug.cgi?id=676027
ACK
bye, Sumit
Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAk1ZRxsACgkQeiVVYja6o6N9HQCcCas4ORYpjW9PiHAvSn0Avba/ 5dYAoJOPVfWzVGB7KoZTq9uPNrEXBi7d =kWO0 -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/14/2011 02:31 PM, Sumit Bose wrote:
On Mon, Feb 14, 2011 at 10:15:39AM -0500, Stephen Gallagher wrote: We weren't verifying that the file descriptor that we get back from openldap was valid. This patch checks that the file descriptor is >= 0 before returning it.
There's another (arguable) bug here in libtevent. Libtevent should probably not return success for tevent_add_fd() when fd < 0 (especially since it crashes). I'll open a bug upstream.
Fixes https://fedorahosted.org/sssd/ticket/797 and https://bugzilla.redhat.com/show_bug.cgi?id=676027
ACK
Pushed to master and sssd-1-5
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
sssd-devel@lists.fedorahosted.org
-
Stephen Gallagher -
Sumit Bose