[sssd PR#5743][opened] ad: fallback to ldap if cldap is not available in libldap

[pbrezina]

   URL: https://github.com/SSSD/sssd/pull/5743
Author: pbrezina
 Title: #5743: ad: fallback to ldap if cldap is not available in libldap
Action: opened

PR body:
"""
Some distributions do not have cldap support available in libldap. Now
we fallback to ad ping over ldap conditionally during build time.

Resolves: https://github.com/SSSD/sssd/issues/5720

```
:fixes: AD ping is now sent over `ldap` if `cldap` support is not available
  during build. This helps to build SSSD on distributions without `cldap`
  support in `libldap`.
```
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5743/head:pr5743
git checkout pr5743

[sssd PR#5743][comment] ad: fallback to ldap if cldap is not available in libldap

[justin-stephenson]

  URL: https://github.com/SSSD/sssd/pull/5743
Title: #5743: ad: fallback to ldap if cldap is not available in libldap

justin-stephenson commented:
"""
Hi, I compiled openldap-2.5.6 without CLDAP support on fedora rawhide.

* Before the PR:

~~~
(2021-08-17 14:25:02): [be[ad.vm]] [ad_cldap_ping_send] (0x0400): Sending CLDAP ping
(2021-08-17 14:25:02): [be[ad.vm]] [ad_cldap_ping_domain_discovery_done] (0x0400): Found 1
domain controllers in domain ad.vm
(2021-08-17 14:25:02): [be[ad.vm]] [sdap_connect_host_resolv_done] (0x0400): Connecting to
cldap://root-dc.ad.vm:389
(2021-08-17 14:25:02): [be[ad.vm]] [sss_ldap_init_sys_connect_done] (0x0020): ldap_init_fd
failed: Bad parameter to an ldap routine. [22][cldap://root-dc.ad.vm:389]
(2021-08-17 14:25:02): [be[ad.vm]] [ad_cldap_ping_done] (0x0040): Unable to get site and
forest information [2]: No such file or directory
~~~

* After the PR:
~~~
[root(a)master.client.vm ~]# egrep -irn 'sdap_connect_host_send|cldap'
/var/log/sssd/sssd_ad.vm.log 
457:(2021-08-17 15:02:17): [be[ad.vm]] [ad_cldap_ping_send] (0x0400): Sending CLDAP ping
477:(2021-08-17 15:02:17): [be[ad.vm]] [ad_cldap_ping_domain_discovery_done] (0x0400):
Found 1 domain controllers in domain ad.vm
478:(2021-08-17 15:02:17): [be[ad.vm]] [sdap_connect_host_send] (0x0400): Resolving host
root-dc.ad.vm
506:(2021-08-17 15:02:17): [be[ad.vm]] [ad_cldap_ping_dc_done] (0x0400):
root-dc.ad.vm:389: found site (Default-First-Site-Name) and forest (ad.vm)
507:(2021-08-17 15:02:17): [be[ad.vm]] [ad_cldap_ping_done] (0x0400): Found site:
Default-First-Site-Name
508:(2021-08-17 15:02:17): [be[ad.vm]] [ad_cldap_ping_done] (0x0400): Found forest:
ad.vm
1330:(2021-08-17 15:02:31): [be[ad.vm]] [ad_cldap_ping_send] (0x0400): [RID#6] CLDAP ping
is not necessary, using site 'Default-First-Site-Name' and forest
'ad.vm'
~~~

The only issue I see is that the 'CLDAP' ping log messages are misleading (ldap
ping instead). The function names also, but changing those is not worth it IMO (too
invasive for this).

I'm not sure if it should block the PR but It would also be helpful if one of the
users reporting this issue could test out the patch.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5743#issuecomment-900381991

[sssd PR#5743][comment] ad: fallback to ldap if cldap is not available in libldap

[sven-probst]

  URL: https://github.com/SSSD/sssd/pull/5743
Title: #5743: ad: fallback to ldap if cldap is not available in libldap

sven-probst commented:
"""
Applying this patch to the debian bullseye package src fixes the problem with
sssd/ad-group lookups. 
"""

See the full comment at https://github.com/SSSD/sssd/pull/5743#issuecomment-913664144

[sssd PR#5743][comment] ad: fallback to ldap if cldap is not available in libldap

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5743
Title: #5743: ad: fallback to ldap if cldap is not available in libldap

pbrezina commented:
"""
Thanks. @justin-stephenson We can't change name of the functions, perhaps we could
change CLDAP -> LDAP in debug messages but I don't think its worth it as well. Are
you going to ack this,
"""

See the full comment at https://github.com/SSSD/sssd/pull/5743#issuecomment-915873614

[sssd PR#5743][+Accepted] ad: fallback to ldap if cldap is not available in libldap

[justin-stephenson]

  URL: https://github.com/SSSD/sssd/pull/5743
Title: #5743: ad: fallback to ldap if cldap is not available in libldap

Label: +Accepted

[sssd PR#5743][comment] ad: fallback to ldap if cldap is not available in libldap

[justin-stephenson]

  URL: https://github.com/SSSD/sssd/pull/5743
Title: #5743: ad: fallback to ldap if cldap is not available in libldap

justin-stephenson commented:
"""
Ack from my side.
"""

See the full comment at https://github.com/SSSD/sssd/pull/5743#issuecomment-916059051

[sssd PR#5743][+Ready to push] ad: fallback to ldap if cldap is not available in libldap

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5743
Title: #5743: ad: fallback to ldap if cldap is not available in libldap

Label: +Ready to push

[sssd PR#5743][comment] ad: fallback to ldap if cldap is not available in libldap

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5743
Title: #5743: ad: fallback to ldap if cldap is not available in libldap

pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5743

* `master`
    * dfb6594e3ce98c6bd543ceebf739eef70955950d - ad: fallback to ldap if cldap is not
available in libldap

"""

See the full comment at https://github.com/SSSD/sssd/pull/5743#issuecomment-918033978

[sssd PR#5743][+Pushed] ad: fallback to ldap if cldap is not available in libldap

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5743
Title: #5743: ad: fallback to ldap if cldap is not available in libldap

Label: +Pushed

[sssd PR#5743][-Accepted] ad: fallback to ldap if cldap is not available in libldap

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5743
Title: #5743: ad: fallback to ldap if cldap is not available in libldap

Label: -Accepted

[sssd PR#5743][-Ready to push] ad: fallback to ldap if cldap is not available in libldap

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/5743
Title: #5743: ad: fallback to ldap if cldap is not available in libldap

Label: -Ready to push

[sssd PR#5743][closed] ad: fallback to ldap if cldap is not available in libldap

[pbrezina]

   URL: https://github.com/SSSD/sssd/pull/5743
Author: pbrezina
 Title: #5743: ad: fallback to ldap if cldap is not available in libldap
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5743/head:pr5743
git checkout pr5743