11:17 p.m.
URL: https://github.com/SSSD/sssd/pull/5591
Author: aborah-sudo
Title: #5591: Tests: Regression part of bash to pytest of shadow utils
Action: opened
PR body:
"""
This script will contain many regression of shadow utils Bzs.
This is part 1 of that.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5591/head:pr5591
git checkout pr5591
11:29 p.m.
New subject: [sssd PR#5591][synchronized] Tests: Regression part of bash to pytest of shadow utils
URL: https://github.com/SSSD/sssd/pull/5591
Author: aborah-sudo
Title: #5591: Tests: Regression part of bash to pytest of shadow utils
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5591/head:pr5591
git checkout pr5591
12:22 a.m.
New subject: [sssd PR#5591][synchronized] Tests: Regression part of bash to pytest of shadow utils
URL: https://github.com/SSSD/sssd/pull/5591
Author: aborah-sudo
Title: #5591: Tests: Regression part of bash to pytest of shadow utils
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5591/head:pr5591
git checkout pr5591
3:36 a.m.
New subject: [sssd PR#5591][synchronized] Tests: Regression part of bash to pytest of shadow utils
URL: https://github.com/SSSD/sssd/pull/5591
Author: aborah-sudo
Title: #5591: Tests: Regression part of bash to pytest of shadow utils
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5591/head:pr5591
git checkout pr5591
3:36 a.m.
New subject: [sssd PR#5591][comment] Tests: Regression part of bash to pytest of shadow utils
URL: https://github.com/SSSD/sssd/pull/5591
Title: #5591: Tests: Regression part of bash to pytest of shadow utils
aborah-sudo commented:
"""
rewrite line34 in pythonic way.
done
"""
See the full comment at https://github.com/SSSD/sssd/pull/5591#issuecomment-822284604
9:44 a.m.
New subject: [sssd PR#5591][comment] Tests: Regression part of bash to pytest of shadow utils
URL: https://github.com/SSSD/sssd/pull/5591
Title: #5591: Tests: Regression part of bash to pytest of shadow utils
alexey-tikhonov commented:
"""
Why do we add shadow-utils tests to SSSD repo?
"""
See the full comment at https://github.com/SSSD/sssd/pull/5591#issuecomment-822523738
9:45 a.m.
New subject: [sssd PR#5591][+Tests] Tests: Regression part of bash to pytest of shadow utils
URL: https://github.com/SSSD/sssd/pull/5591
Title: #5591: Tests: Regression part of bash to pytest of shadow utils
Label: +Tests
9:46 a.m.
New subject: [sssd PR#5591][+Blocked] Tests: Regression part of bash to pytest of shadow utils
URL: https://github.com/SSSD/sssd/pull/5591
Title: #5591: Tests: Regression part of bash to pytest of shadow utils
Label: +Blocked
10:13 a.m.
New subject: [sssd PR#5591][comment] Tests: Regression part of bash to pytest of shadow utils
URL: https://github.com/SSSD/sssd/pull/5591
Title: #5591: Tests: Regression part of bash to pytest of shadow utils
aborah-sudo commented:
"""
Why do we add shadow-utils tests to SSSD repo?
It was decided to temporarily put all shadow utils ported test cases to sssd repo and
test with CI . Once its decided the place where the ported test cases will be placed , we
will remove the ported test cases from sssd repo . It was decided just not to stop ported
work , or it will take long time to just start the work . Today i have put a mail to
shadow utils team , they said they are ok with pytest and CI on there repo . But this will
take much more time to import the sssd test library there and configure CI . Till then we
would like to put these test cases here on sssd repo . I will forward the mail to you ,
sent by shadow utils team . What is your opinion on this .
"""
See the full comment at https://github.com/SSSD/sssd/pull/5591#issuecomment-822548927
10:37 a.m.
New subject: [sssd PR#5591][comment] Tests: Regression part of bash to pytest of shadow utils
URL: https://github.com/SSSD/sssd/pull/5591
Title: #5591: Tests: Regression part of bash to pytest of shadow utils
alexey-tikhonov commented:
"""
I think it's ok to use PR CI to verify tests are ported correctly, but I don't
think it justifies actually pushing code that test other components to sssd repo.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5591#issuecomment-822566555
5:31 a.m.
New subject: [sssd PR#5591][comment] Tests: Regression part of bash to pytest of shadow utils
URL: https://github.com/SSSD/sssd/pull/5591
Title: #5591: Tests: Regression part of bash to pytest of shadow utils
shridhargadekar commented:
"""
modified changes look fine.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5591#issuecomment-828347036
11:04 a.m.
New subject: [sssd PR#5591][closed] Tests: Regression part of bash to pytest of shadow utils
URL: https://github.com/SSSD/sssd/pull/5591
Author: aborah-sudo
Title: #5591: Tests: Regression part of bash to pytest of shadow utils
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5591/head:pr5591
git checkout pr5591
996
days inactive
1096
days old
sssd-devel@lists.fedorahosted.org
11 comments
3 participants
participants (3)
-
aborah-sudo -
alexey-tikhonov
-
shridhargadekar