URL: https://github.com/SSSD/sssd/pull/206 Author: celestian Title: #206: IFP: Fix of names in GetUserGroups method Action: opened
PR body: """ This patch adds code which chooses the right domain for creation of output group's name. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/206/head:pr206 git checkout pr206
URL: https://github.com/SSSD/sssd/pull/206 Title: #206: IFP: Fix of names in GetUserGroups method
celestian commented: """ How to test:
We need setup sssd as client of FreeIPA server with AD trust. And we need add user from AD domain to FreeIPA group (ask me if you need help).
``` # Reset sssd and clear cache, logs systemctl daemon-reload sudo su -c "truncate -s0 /var/log/sssd/*.log" sudo su -c "rm -f /var/lib/sss/db/*" sudo su -c "rm -f /var/lib/sss/mc/*" sudo systemctl restart sssd.service
# Update of necessary entities dbus-send --print-reply --system --dest=org.freedesktop.sssd.infopipe \ /org/freedesktop/sssd/infopipe/Groups \ org.freedesktop.sssd.infopipe.Groups.FindByName \ string:<ad_group> # it return <ad_group OBJECT>
dbus-send --print-reply --system --dest=org.freedesktop.sssd.infopipe \ "<ad_group OBJECT>" \ org.freedesktop.sssd.infopipe.Groups.Group.UpdateMemberList
# Those two calls should have the same form of outpup groups id test_user@ad_domain | tr ',' '\n'
dbus-send --system --print-reply --dest=org.freedesktop.sssd.infopipe \ /org/freedesktop/sssd/infopipe org.freedesktop.sssd.infopipe.GetUserGroups \ string:test_user@ad_domain ``` """
See the full comment at https://github.com/SSSD/sssd/pull/206#issuecomment-288422804
URL: https://github.com/SSSD/sssd/pull/206 Author: celestian Title: #206: IFP: Fix of names in GetUserGroups method Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/206/head:pr206 git checkout pr206
URL: https://github.com/SSSD/sssd/pull/206 Title: #206: IFP: Fix of names in GetUserGroups method
celestian commented: """ Updated -- I just added "resolves" link to the commit message. """
See the full comment at https://github.com/SSSD/sssd/pull/206#issuecomment-288980755
URL: https://github.com/SSSD/sssd/pull/206 Title: #206: IFP: Fix of names in GetUserGroups method
celestian commented: """ Bump. """
See the full comment at https://github.com/SSSD/sssd/pull/206#issuecomment-293582645
URL: https://github.com/SSSD/sssd/pull/206 Title: #206: IFP: Fix of names in GetUserGroups method
lslebodn commented: """ I do not plan to do full review but I wonder why we need `sss_get_domain_by_name` just in ifp responder. How is this situation solved in nss responder?
Probably question to @pbrezina :-) because @celestian probably do not have a time to update patch (if needed) """
See the full comment at https://github.com/SSSD/sssd/pull/206#issuecomment-293594149
URL: https://github.com/SSSD/sssd/pull/206 Title: #206: IFP: Fix of names in GetUserGroups method
jhrozek commented: """ I think the best way would be to move `sized_member_name` to the responder common code and reuse it. """
See the full comment at https://github.com/SSSD/sssd/pull/206#issuecomment-293620647
URL: https://github.com/SSSD/sssd/pull/206 Title: #206: IFP: Fix of names in GetUserGroups method
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/206 Title: #206: IFP: Fix of names in GetUserGroups method
jhrozek commented: """ Since this PR wasn't updated in a week and we need to merge the patch soon to fix downstream, I opened a new PR #240. """
See the full comment at https://github.com/SSSD/sssd/pull/206#issuecomment-295323276
URL: https://github.com/SSSD/sssd/pull/206 Author: celestian Title: #206: IFP: Fix of names in GetUserGroups method Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/206/head:pr206 git checkout pr206
URL: https://github.com/SSSD/sssd/pull/206 Title: #206: IFP: Fix of names in GetUserGroups method
Label: +Rejected
URL: https://github.com/SSSD/sssd/pull/206 Title: #206: IFP: Fix of names in GetUserGroups method
Label: -Changes requested
sssd-devel@lists.fedorahosted.org
-
celestian -
jhrozek
-
lslebodn