[sssd PR#91][opened] sssctl: Fix missing declaration

[fidencio]

URL: https://github.com/SSSD/sssd/pull/91
Author: lslebodn
 Title: #91: sssctl: Fix missing declaration
Action: opened

PR body:
"""
The WEXITSTATUS is defined in stdlib.h on linux.
There is a nice comment in stdlib.h:
  /* Define the macros <sys/wait.h> also would define this way.  */

It's better to not rely on this and use more platfom friendly
way with including "sys/wait.h".

I found this macro mentioned only in the manual page for wait(2)
and there is mentioned just the "sys/wait.h" and not "stdlib.h"

src/tools/sssctl/sssctl.c: In function 'sssctl_run_command':
src/tools/sssctl/sssctl.c:110: error: implicit declaration of function
'WEXITSTATUS'
gmake[2]: *** [Makefile:22383: src/tools/sssctl/sssctl-sssctl.o] Error 1
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/91/head:pr91
git checkout pr91

[sssd PR#91][comment] sssctl: Fix missing declaration

[fidencio]

URL: https://github.com/SSSD/sssd/pull/91
Title: #91: sssctl: Fix missing declaration

fidencio commented:
"""
Please, mention that the breakage was noticed when building SSSD on FreeBSD on this patch as well.
"""

See the full comment at https://github.com/SSSD/sssd/pull/91#issuecomment-262854618

[sssd PR#91][+Changes requested] sssctl: Fix missing declaration

[fidencio]

URL: https://github.com/SSSD/sssd/pull/91
Title: #91: sssctl: Fix missing declaration

Label: +Changes requested

[sssd PR#91][comment] sssctl: Fix missing declaration

[fidencio]

URL: https://github.com/SSSD/sssd/pull/91
Title: #91: sssctl: Fix missing declaration

lslebodn commented:
"""
On (24/11/16 15:12), fidencio wrote:
> Please, mention that the breakage was noticed when building SSSD on FreeBSD on this patch as well.

The commit message has sufficient information.
The same situation can happen on ther unix platforms
I do not see a reason for mentioning BSD there.

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/91#issuecomment-262913735

[sssd PR#91][-Changes requested] sssctl: Fix missing declaration

[fidencio]

URL: https://github.com/SSSD/sssd/pull/91
Title: #91: sssctl: Fix missing declaration

Label: -Changes requested

[sssd PR#91][comment] sssctl: Fix missing declaration

[fidencio]

URL: https://github.com/SSSD/sssd/pull/91
Title: #91: sssctl: Fix missing declaration

fidencio commented:
"""
On Fri, Nov 25, 2016 at 10:22 AM, lslebodn  wrote:
> On (24/11/16 15:12), fidencio wrote:
> > Please, mention that the breakage was noticed when building SSSD on
>
> FreeBSD on this patch as well.
> >
>
> The commit message has sufficient information.

For you, not for me. Otherwise I wouldn't have asked. :-\
> The same situation can happen on ther unix platforms
> I do not see a reason for mentioning BSD there.

Okay, then.
> LS
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> https://github.com/SSSD/sssd/pull/91#issuecomment-262913735, or mute
> the thread
> https://github.com/notifications/unsubscribe-auth/AAG4ek_J5qlhU7V4h9GBnVixJWYrHxFsks5rBqjIgaJpZM4K7piO
> .

Acked-by: Fabiano Fidêncio

"""

See the full comment at https://github.com/SSSD/sssd/pull/91#issuecomment-262919608

[sssd PR#91][+Accepted] sssctl: Fix missing declaration

[fidencio]

URL: https://github.com/SSSD/sssd/pull/91
Title: #91: sssctl: Fix missing declaration

Label: +Accepted

[sssd PR#91][comment] sssctl: Fix missing declaration

[fidencio]

URL: https://github.com/SSSD/sssd/pull/91
Title: #91: sssctl: Fix missing declaration

lslebodn commented:
"""
On (25/11/16 01:52), fidencio wrote:
> On Fri, Nov 25, 2016 at 10:22 AM, lslebodn  wrote:
> > On (24/11/16 15:12), fidencio wrote:
> > > Please, mention that the breakage was noticed when building SSSD on
> >
> > FreeBSD on this patch as well.
> > >
> >
> > The commit message has sufficient information.
>
> For you, not for me. Otherwise I wouldn't have asked. :-\

I added following sentence to commit mesasge to make you
a litlle bit happier :-)
"For example the libc on FreeBSD does not provide WEXITSTATUS in stdlib.h"
> > LS
> >
> > .
>
> Acked-by: Fabiano Fidêncio

master:
* 73c9330fa3de6912e45c1ab686d5290f143b8352

sssd-1-14:
* 161ddc1f24082c735801775802a483e96909152c

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/91#issuecomment-262941656

[sssd PR#91][closed] sssctl: Fix missing declaration

[fidencio]

URL: https://github.com/SSSD/sssd/pull/91
Author: lslebodn
 Title: #91: sssctl: Fix missing declaration
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/91/head:pr91
git checkout pr91

[sssd PR#91][+Pushed] sssctl: Fix missing declaration

[fidencio]

URL: https://github.com/SSSD/sssd/pull/91
Title: #91: sssctl: Fix missing declaration

Label: +Pushed