[PATCH] Add a special filter type to handle enumerations

[Sumit Bose]

Hi,

this patch adds a special filter type for enumarations instead of using
'name=*'. I think this makes the code easier to read and understand,
allows the usage of a '*' in user or group names (although it might be
recommended to do without) and fixes trac ticket #676.

bye,
Sumit

[Simo Sorce]

On Mon, 29 Nov 2010 11:57:31 +0100
Sumit Bose  wrote:
> Hi,
>
> this patch adds a special filter type for enumarations instead of
> using 'name=*'. I think this makes the code easier to read and
> understand, allows the usage of a '*' in user or group names
> (although it might be recommended to do without) and fixes trac
> ticket #676.
>
> bye,
> Sumit

FWIW:
Theareason why we used the name and * in the name field is because
originally we wanted to allow to search using a smart filter. So that
through the infopipe you could do searches like: all users starting by
A, with a filter like "A*".

But I think we can work on it when we will actually decide to implement
this stuff. Meanwhile, although I haven't reviewed the patch carefully,
the general direction looks quite ok.

Simo.

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/29/2010 05:57 AM, Sumit Bose wrote:
> Hi,
>
> this patch adds a special filter type for enumarations instead of using
> 'name=*'. I think this makes the code easier to read and understand,
> allows the usage of a '*' in user or group names (although it might be
> recommended to do without) and fixes trac ticket #676.

Ack.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkz3qhgACgkQeiVVYja6o6Nz4wCdHAhcl5wqXLyMyV/dWh8V0gWK
> FlsAn1Ji2K1u1D6AMSGNjUPM7NTyx09K
> =g+tO
> -----END PGP SIGNATURE-----

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/02/2010 09:15 AM, Stephen Gallagher wrote:
> On 11/29/2010 05:57 AM, Sumit Bose wrote:
> > Hi,
> > this patch adds a special filter type for enumarations instead of using
> > 'name=*'. I think this makes the code easier to read and understand,
> > allows the usage of a '*' in user or group names (although it might be
> > recommended to do without) and fixes trac ticket #676.
>
> Ack.

Pushed to master.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkz3r18ACgkQeiVVYja6o6PPZQCfZ+YSMlXP5MI5S+XP9gGBoGB3
> tc4AoKVQUB/MRkYPHfbAu3Z/4bIrR06e
> =ZWca
> -----END PGP SIGNATURE-----