This function alters the memory hierarchy of the be_req to ensure memory safety during shutdown. It creates a spy on the be_cli object so that it will free the be_req if the client is freed.
It is generally allocated atop the private data context for the appropriate back-end against which it is being filed.
This should resolve https://fedorahosted.org/sssd/ticket/1226
On Fri, 2012-03-02 at 13:52 -0500, Stephen Gallagher wrote:
This function alters the memory hierarchy of the be_req to ensure memory safety during shutdown. It creates a spy on the be_cli object so that it will free the be_req if the client is freed.
It is generally allocated atop the private data context for the appropriate back-end against which it is being filed.
This should resolve https://fedorahosted.org/sssd/ticket/1226
Simo performed the review on IRC and found one issue (the destructors should not be set until both spies are active) and made a minor improvement request.
New patch attached.
On Fri, 2012-03-02 at 14:19 -0500, Stephen Gallagher wrote:
On Fri, 2012-03-02 at 13:52 -0500, Stephen Gallagher wrote:
This function alters the memory hierarchy of the be_req to ensure memory safety during shutdown. It creates a spy on the be_cli object so that it will free the be_req if the client is freed.
It is generally allocated atop the private data context for the appropriate back-end against which it is being filed.
This should resolve https://fedorahosted.org/sssd/ticket/1226
Simo performed the review on IRC and found one issue (the destructors should not be set until both spies are active) and made a minor improvement request.
New patch attached.
Ok I promised an ACK if the minor improvement was there but NACK, destructors are set twice now, I guess a bad merge when preparing the patch ?
Simo.
On Fri, 2012-03-02 at 14:40 -0500, Simo Sorce wrote:
On Fri, 2012-03-02 at 14:19 -0500, Stephen Gallagher wrote:
On Fri, 2012-03-02 at 13:52 -0500, Stephen Gallagher wrote:
This function alters the memory hierarchy of the be_req to ensure memory safety during shutdown. It creates a spy on the be_cli object so that it will free the be_req if the client is freed.
It is generally allocated atop the private data context for the appropriate back-end against which it is being filed.
This should resolve https://fedorahosted.org/sssd/ticket/1226
Simo performed the review on IRC and found one issue (the destructors should not be set until both spies are active) and made a minor improvement request.
New patch attached.
Ok I promised an ACK if the minor improvement was there but NACK, destructors are set twice now, I guess a bad merge when preparing the patch ?
Simo.
Fixed. Not sure how that happened.
On Fri, 2012-03-02 at 14:42 -0500, Stephen Gallagher wrote:
On Fri, 2012-03-02 at 14:40 -0500, Simo Sorce wrote:
On Fri, 2012-03-02 at 14:19 -0500, Stephen Gallagher wrote:
On Fri, 2012-03-02 at 13:52 -0500, Stephen Gallagher wrote:
This function alters the memory hierarchy of the be_req to ensure memory safety during shutdown. It creates a spy on the be_cli object so that it will free the be_req if the client is freed.
It is generally allocated atop the private data context for the appropriate back-end against which it is being filed.
This should resolve https://fedorahosted.org/sssd/ticket/1226
Simo performed the review on IRC and found one issue (the destructors should not be set until both spies are active) and made a minor improvement request.
New patch attached.
Ok I promised an ACK if the minor improvement was there but NACK, destructors are set twice now, I guess a bad merge when preparing the patch ?
Simo.
Fixed. Not sure how that happened.
Aaand ACK
Simo.
On Fri, 2012-03-02 at 14:43 -0500, Simo Sorce wrote:
On Fri, 2012-03-02 at 14:42 -0500, Stephen Gallagher wrote:
On Fri, 2012-03-02 at 14:40 -0500, Simo Sorce wrote:
On Fri, 2012-03-02 at 14:19 -0500, Stephen Gallagher wrote:
On Fri, 2012-03-02 at 13:52 -0500, Stephen Gallagher wrote:
This function alters the memory hierarchy of the be_req to ensure memory safety during shutdown. It creates a spy on the be_cli object so that it will free the be_req if the client is freed.
It is generally allocated atop the private data context for the appropriate back-end against which it is being filed.
This should resolve https://fedorahosted.org/sssd/ticket/1226
Simo performed the review on IRC and found one issue (the destructors should not be set until both spies are active) and made a minor improvement request.
New patch attached.
Ok I promised an ACK if the minor improvement was there but NACK, destructors are set twice now, I guess a bad merge when preparing the patch ?
Simo.
Fixed. Not sure how that happened.
Aaand ACK
Pushed to master and sssd-1-8.
sssd-devel@lists.fedorahosted.org
-
Simo Sorce -
Stephen Gallagher