URL: https://github.com/SSSD/sssd/pull/1010 Author: ikerexxe Title: #1010: man: in sssd-ipa clarified trusted domains section Action: opened
PR body: """ In sssd-ipa man page added a second option when configuring trusted domains
Resolves: https://pagure.io/SSSD/sssd/issue/4041 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/1010/head:pr1010 git checkout pr1010
URL: https://github.com/SSSD/sssd/pull/1010 Title: #1010: man: in sssd-ipa clarified trusted domains section
alexey-tikhonov commented: """ LGTM, but I will leave this to review for somebody with better English skill...
As a side note, I miss clarification where `subdomain_inherit` option should be used: in parent domain or in sub-domain? But perhaps this should be clarified in sssd.conf... """
See the full comment at https://github.com/SSSD/sssd/pull/1010#issuecomment-605869136
URL: https://github.com/SSSD/sssd/pull/1010 Title: #1010: man: in sssd-ipa clarified trusted domains section
pbrezina commented: """ I believe there should be "A trusted domain configuration can be set either *by* using". @justin-stephenson can you please check this commit for grammar? Thank you. """
See the full comment at https://github.com/SSSD/sssd/pull/1010#issuecomment-607143617
URL: https://github.com/SSSD/sssd/pull/1010 Title: #1010: man: in sssd-ipa clarified trusted domains section
justin-stephenson commented: """ The wording was a bit unclear in my opinion, I might suggest something like:
A trusted domain configuration can be set using the trusted domain subsection as shown in the example below. Alternatively, the `subdomain_inherit` option can be used in the parent domain._ """
See the full comment at https://github.com/SSSD/sssd/pull/1010#issuecomment-607221673
URL: https://github.com/SSSD/sssd/pull/1010 Author: ikerexxe Title: #1010: man: in sssd-ipa clarified trusted domains section Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/1010/head:pr1010 git checkout pr1010
URL: https://github.com/SSSD/sssd/pull/1010 Title: #1010: man: in sssd-ipa clarified trusted domains section
ikerexxe commented: """ Thanks for the improvements Justin. I have just updated the commit with them. """
See the full comment at https://github.com/SSSD/sssd/pull/1010#issuecomment-607239501
URL: https://github.com/SSSD/sssd/pull/1010 Title: #1010: man: in sssd-ipa clarified trusted domains section
pbrezina commented: """ * `master` * 80b9285b39127cc4f27fb9c18d1c03a1c654cdf0 - man: in sssd-ipa clarified trusted domains section
"""
See the full comment at https://github.com/SSSD/sssd/pull/1010#issuecomment-617118175
URL: https://github.com/SSSD/sssd/pull/1010 Title: #1010: man: in sssd-ipa clarified trusted domains section
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/1010 Title: #1010: man: in sssd-ipa clarified trusted domains section
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/1010 Title: #1010: man: in sssd-ipa clarified trusted domains section
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/1010 Author: ikerexxe Title: #1010: man: in sssd-ipa clarified trusted domains section Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/1010/head:pr1010 git checkout pr1010
sssd-devel@lists.fedorahosted.org
-
alexey-tikhonov -
ikerexxe
-
justin-stephenson
-
pbrezina