Hi,
I'm sending this man page amendment on behalf of one of our users who suggested to improve the description of ignore_group_members.
On 01/14/2015 11:13 AM, Jakub Hrozek wrote:
From 6c8cee6aeb6548bfc78d1ba2979a3ba8b002c522 Mon Sep 17 00:00:00 2001 From: John Dickersonjedicker@iastate.edu Date: Fri, 12 Dec 2014 10:38:10 +0100 Subject: [PATCH] MAN: Amend the description of ignore_group_members
The option description should hint that enabling this option may have a positive effect on access control, especially with large groups.
Did you miss a word performance or something similar in this commit description? "positive effect on *performace* of access control?"
Applies fine, builds fine, makes sense to me.
I don't think you have to amend the description as I proposed - so ACK.
Or do we need a native speaker to ack?
On Wed, Jan 14, 2015 at 05:02:24PM +0100, Pavel Reichl wrote:
On 01/14/2015 11:13 AM, Jakub Hrozek wrote:
From 6c8cee6aeb6548bfc78d1ba2979a3ba8b002c522 Mon Sep 17 00:00:00 2001 From: John Dickersonjedicker@iastate.edu Date: Fri, 12 Dec 2014 10:38:10 +0100 Subject: [PATCH] MAN: Amend the description of ignore_group_members
The option description should hint that enabling this option may have a positive effect on access control, especially with large groups.
Did you miss a word performance or something similar in this commit description? "positive effect on *performace* of access control?"
Applies fine, builds fine, makes sense to me.
I don't think you have to amend the description as I proposed - so ACK.
Ah, yes, I will amend the commit message before pushing.
Or do we need a native speaker to ack?
The diff was mostly written by John Dickerson, I just amended some technicalities, so I don't think we need a native speaker here.
On Wed, Jan 14, 2015 at 05:08:03PM +0100, Jakub Hrozek wrote:
On Wed, Jan 14, 2015 at 05:02:24PM +0100, Pavel Reichl wrote:
On 01/14/2015 11:13 AM, Jakub Hrozek wrote:
From 6c8cee6aeb6548bfc78d1ba2979a3ba8b002c522 Mon Sep 17 00:00:00 2001 From: John Dickersonjedicker@iastate.edu Date: Fri, 12 Dec 2014 10:38:10 +0100 Subject: [PATCH] MAN: Amend the description of ignore_group_members
The option description should hint that enabling this option may have a positive effect on access control, especially with large groups.
Did you miss a word performance or something similar in this commit description? "positive effect on *performace* of access control?"
Applies fine, builds fine, makes sense to me.
I don't think you have to amend the description as I proposed - so ACK.
Ah, yes, I will amend the commit message before pushing.
Or do we need a native speaker to ack?
The diff was mostly written by John Dickerson, I just amended some technicalities, so I don't think we need a native speaker here.
* master: dcaf214652568da55b1caf382e04f99b51a544f3
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Pavel Reichl