URL: https://github.com/SSSD/sssd/pull/409 Author: sumit-bose Title: #409: sss_client: refactor internal timeout handling Action: opened
PR body: """ This patch adds a timeout option to the internal client calls so that the timeout is not hard-coded anymore in the low level poll() calls but can be set by the caller with sss_nss_make_request_timeout(). Since the old timeout value is not changed by this patch there is no functional change expected.
Related to https://pagure.io/SSSD/sssd/issue/2478 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/409/head:pr409 git checkout pr409
URL: https://github.com/SSSD/sssd/pull/409 Title: #409: sss_client: refactor internal timeout handling
fidencio commented: """ @sumit-bose, so, AFAIU the main reason behind this change is to expose to slapi-nis a new API which will have the timeout as parameter, right? There's no intention, at all, to make this timeout something configurable from sssd.conf, right?
In case I understood properly the reasoning, the code looks good and I'll ack this patch after getting the results from CI. """
See the full comment at https://github.com/SSSD/sssd/pull/409#issuecomment-337397744
URL: https://github.com/SSSD/sssd/pull/409 Title: #409: sss_client: refactor internal timeout handling
sumit-bose commented: """ @fidenco, yes, the timeout is something which will be controlled by the client. Since different client might have different needs there is no reason to have a central value in sssd.conf. """
See the full comment at https://github.com/SSSD/sssd/pull/409#issuecomment-337463677
URL: https://github.com/SSSD/sssd/pull/409 Title: #409: sss_client: refactor internal timeout handling
fidencio commented: """ CI: http://vm-058-233.$%7Babc%7D/logs/job/79/75/summary.html """
See the full comment at https://github.com/SSSD/sssd/pull/409#issuecomment-337473484
URL: https://github.com/SSSD/sssd/pull/409 Title: #409: sss_client: refactor internal timeout handling
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/409 Title: #409: sss_client: refactor internal timeout handling
jhrozek commented: """ btw since this PR touches the client code, I think similar to the UPG PR we should have two reviewers.
Note that this is in no way a statement about either Fabiano's review or Sumit's code, it's just that client code is critical and should be reviewed very carefully. """
See the full comment at https://github.com/SSSD/sssd/pull/409#issuecomment-337497697
URL: https://github.com/SSSD/sssd/pull/409 Title: #409: sss_client: refactor internal timeout handling
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/409 Title: #409: sss_client: refactor internal timeout handling
fidencio commented: """ Agreed! I've removed the "Accepted" label so far. The second reviewer can add the label after their ACK. """
See the full comment at https://github.com/SSSD/sssd/pull/409#issuecomment-337501771
URL: https://github.com/SSSD/sssd/pull/409 Title: #409: sss_client: refactor internal timeout handling
jhrozek commented: """ This patch is indeed not so complex, ACK! """
See the full comment at https://github.com/SSSD/sssd/pull/409#issuecomment-337844924
URL: https://github.com/SSSD/sssd/pull/409 Title: #409: sss_client: refactor internal timeout handling
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/409 Title: #409: sss_client: refactor internal timeout handling
lslebodn commented: """ master: * 28f9c2051563fad6db26819c3d5188c8f946633e """
See the full comment at https://github.com/SSSD/sssd/pull/409#issuecomment-337880287
URL: https://github.com/SSSD/sssd/pull/409 Author: sumit-bose Title: #409: sss_client: refactor internal timeout handling Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/409/head:pr409 git checkout pr409
URL: https://github.com/SSSD/sssd/pull/409 Title: #409: sss_client: refactor internal timeout handling
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
fidencio -
jhrozek
-
lslebodn
-
sumit-bose