URL: https://github.com/SSSD/sssd/pull/715 Author: AdamWill Title: #715: Use 120 second default timeout for dbus (#1654537) Action: opened
PR body: """ As discussed in #1654537, first login to a system as a FreeIPA domain user now usually causes an expensive SELinux operation to happen; this can take longer than the default dbus message timeout of 25 seconds. To deal with this for now, let's use a 120 second default timeout; this is a big hammer, but unless we can refactor things to use a longer timeout just for that one call, or make the actual operation take less time, there's not much else we can do.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1654537
Signed-off-by: Adam Williamson awilliam@redhat.com """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/715/head:pr715 git checkout pr715
URL: https://github.com/SSSD/sssd/pull/715 Title: #715: Use 120 second default timeout for dbus (#1654537)
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/715#issuecomment-446858543
URL: https://github.com/SSSD/sssd/pull/715 Author: AdamWill Title: #715: Use 120 second default timeout for dbus (#1654537) Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/715/head:pr715 git checkout pr715
URL: https://github.com/SSSD/sssd/pull/715 Title: #715: Use 120 second default timeout for dbus (#1654537)
jhrozek commented: """ ok to test """
See the full comment at https://github.com/SSSD/sssd/pull/715#issuecomment-446878401
URL: https://github.com/SSSD/sssd/pull/715 Title: #715: Use 120 second default timeout for dbus (#1654537)
jhrozek commented: """ @pbrezina can you review? """
See the full comment at https://github.com/SSSD/sssd/pull/715#issuecomment-448222137
URL: https://github.com/SSSD/sssd/pull/715 Title: #715: Use 120 second default timeout for dbus (#1654537)
mzidek-rh commented: """ Just a note that pbrezina is on holiday, so the review may need to wait for January. """
See the full comment at https://github.com/SSSD/sssd/pull/715#issuecomment-448605731
URL: https://github.com/SSSD/sssd/pull/715 Title: #715: Use 120 second default timeout for dbus (#1654537)
jhrozek commented: """ Two notes: 1) I think the patch is correct, it obviously helps the problem Adam saw. The only reason I ask @pbrezina for review is that he knows the sbus IPC much better than anyone else, so he might be able to spot e.g. if we need to tune the timeout somewhere else as well. 2) I filed an upstream ticket https://pagure.io/SSSD/sssd/issue/3909 so it might be a good idea to include it in the commit message when pushing the patch """
See the full comment at https://github.com/SSSD/sssd/pull/715#issuecomment-448950272
URL: https://github.com/SSSD/sssd/pull/715 Title: #715: Use 120 second default timeout for dbus (#1654537)
pbrezina commented: """ Patch look good. Since all dbus calls uses this constant, it is sufficient to change only this. """
See the full comment at https://github.com/SSSD/sssd/pull/715#issuecomment-451134896
URL: https://github.com/SSSD/sssd/pull/715 Author: AdamWill Title: #715: Use 120 second default timeout for dbus (#1654537) Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/715/head:pr715 git checkout pr715
URL: https://github.com/SSSD/sssd/pull/715 Title: #715: Use 120 second default timeout for dbus (#1654537)
AdamWill commented: """ Rebased and added the upstream issue to the commit message (please let me know if the format is wrong). Thanks. """
See the full comment at https://github.com/SSSD/sssd/pull/715#issuecomment-451229921
URL: https://github.com/SSSD/sssd/pull/715 Title: #715: Use 120 second default timeout for dbus (#1654537)
jhrozek commented: """ Thank you very much Adam, looks good to me. """
See the full comment at https://github.com/SSSD/sssd/pull/715#issuecomment-451253485
URL: https://github.com/SSSD/sssd/pull/715 Title: #715: Use 120 second default timeout for dbus (#1654537)
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/715 Title: #715: Use 120 second default timeout for dbus (#1654537)
jhrozek commented: """ Oops, this was pushed already, I just forgot to close the PR. Master: e4469fbdb3d5c53294c6514280ac75b847b3c61c """
See the full comment at https://github.com/SSSD/sssd/pull/715#issuecomment-452252594
URL: https://github.com/SSSD/sssd/pull/715 Author: AdamWill Title: #715: Use 120 second default timeout for dbus (#1654537) Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/715/head:pr715 git checkout pr715
URL: https://github.com/SSSD/sssd/pull/715 Title: #715: Use 120 second default timeout for dbus (#1654537)
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
AdamWill -
centos-ci
-
jhrozek
-
mzidek-rh
-
pbrezina