[sssd PR#983][opened] GPO: Duplicated error message for unreadable GPO

[elkoniu]

   URL: https://github.com/SSSD/sssd/pull/983
Author: elkoniu
 Title: #983: GPO: Duplicated error message for unreadable GPO
Action: opened

PR body:
"""
In case of unreadable GPO error message has been produced
twice - using sss_log() and DEBUG(). Message priority was
set to SSSDBG_CRIT_FAILURE which is not true in this case
and sidefect was message broadcast over users terminals.

Error message duplication has been removed and error
level changed to SSSDBG_MINOR_FAILURE.

Resolves:
https://pagure.io/SSSD/sssd/issue/4133
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/983/head:pr983
git checkout pr983

[sssd PR#983][comment] GPO: Duplicated error message for unreadable GPO

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/983
Title: #983: GPO: Duplicated error message for unreadable GPO

pbrezina commented:
"""
Doesn't it always deny access if unreadable GPO is found?
"""

See the full comment at https://github.com/SSSD/sssd/pull/983#issuecomment-584567592

[sssd PR#983][comment] GPO: Duplicated error message for unreadable GPO

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/983
Title: #983: GPO: Duplicated error message for unreadable GPO

pbrezina commented:
"""
We already discussed this on IRC. TLDR this is a critical error unless it is specifically
set to ignore it, because it denies access when GPO entry is potentially
misconfigured/malformed. In my opinion we should keep logging it to syslog (`sss_log()`)
but provide a correct priority level from `SSS_LOG_*` instead of incorrectly using
`SSSDBG_CRIT_FAILURE` which translates to emergency syslog level and thus printing the
messages also to terminal.
"""

See the full comment at https://github.com/SSSD/sssd/pull/983#issuecomment-585193969

[sssd PR#983][+Changes requested] GPO: Duplicated error message for unreadable GPO

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/983
Title: #983: GPO: Duplicated error message for unreadable GPO

Label: +Changes requested

[sssd PR#983][comment] GPO: Duplicated error message for unreadable GPO

[mzidek-gh]

  URL: https://github.com/SSSD/sssd/pull/983
Title: #983: GPO: Duplicated error message for unreadable GPO

mzidek-gh commented:
"""
Just a note that I also agree with @pbrezina that we should keep logging this in syslog.
This is indication of potentially serious misconfiguration, so I do not mind if it is loud
(but changing the debug message to MINOR from CRIT is OK).
"""

See the full comment at https://github.com/SSSD/sssd/pull/983#issuecomment-585209072

[sssd PR#983][synchronized] GPO: Duplicated error message for unreadable GPO

[elkoniu]

   URL: https://github.com/SSSD/sssd/pull/983
Author: elkoniu
 Title: #983: GPO: Duplicated error message for unreadable GPO
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/983/head:pr983
git checkout pr983

[sssd PR#983][comment] GPO: Duplicated error message for unreadable GPO

[elkoniu]

  URL: https://github.com/SSSD/sssd/pull/983
Title: #983: GPO: Duplicated error message for unreadable GPO

elkoniu commented:
"""
Thanks for input - I changed log level to SSS_LOG_ERR and kept syslog logging as
suggested.
"""

See the full comment at https://github.com/SSSD/sssd/pull/983#issuecomment-585212474

[sssd PR#983][comment] GPO: Duplicated error message for unreadable GPO

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/983
Title: #983: GPO: Duplicated error message for unreadable GPO

pbrezina commented:
"""
Thank you. Ack.
"""

See the full comment at https://github.com/SSSD/sssd/pull/983#issuecomment-587428865

[sssd PR#983][-Changes requested] GPO: Duplicated error message for unreadable GPO

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/983
Title: #983: GPO: Duplicated error message for unreadable GPO

Label: -Changes requested

[sssd PR#983][+Ready to push] GPO: Duplicated error message for unreadable GPO

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/983
Title: #983: GPO: Duplicated error message for unreadable GPO

Label: +Ready to push

[sssd PR#983][+Accepted] GPO: Duplicated error message for unreadable GPO

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/983
Title: #983: GPO: Duplicated error message for unreadable GPO

Label: +Accepted

[sssd PR#983][comment] GPO: Duplicated error message for unreadable GPO

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/983
Title: #983: GPO: Duplicated error message for unreadable GPO

pbrezina commented:
"""
This patch definitely makes sense so I'm going to push it tomorrow if there are no
objections. But I'd like @mzidek-gh to answer questions in the ticket before closing
the ticket.
"""

See the full comment at https://github.com/SSSD/sssd/pull/983#issuecomment-587429790

[sssd PR#983][comment] GPO: Duplicated error message for unreadable GPO

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/983
Title: #983: GPO: Duplicated error message for unreadable GPO

pbrezina commented:
"""
* `master`
    * 9188aa17d9c4dfec1d5744981ea8855465965808 - GPO: Duplicated error message for
unreadable GPO

"""

See the full comment at https://github.com/SSSD/sssd/pull/983#issuecomment-588871384

[sssd PR#983][+Pushed] GPO: Duplicated error message for unreadable GPO

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/983
Title: #983: GPO: Duplicated error message for unreadable GPO

Label: +Pushed

[sssd PR#983][-Accepted] GPO: Duplicated error message for unreadable GPO

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/983
Title: #983: GPO: Duplicated error message for unreadable GPO

Label: -Accepted

[sssd PR#983][-Ready to push] GPO: Duplicated error message for unreadable GPO

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/983
Title: #983: GPO: Duplicated error message for unreadable GPO

Label: -Ready to push

[sssd PR#983][closed] GPO: Duplicated error message for unreadable GPO

[pbrezina]

   URL: https://github.com/SSSD/sssd/pull/983
Author: elkoniu
 Title: #983: GPO: Duplicated error message for unreadable GPO
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/983/head:pr983
git checkout pr983