4:23 a.m.
URL: https://github.com/SSSD/sssd/pull/5852
Author: ikerexxe
Title: #5852: ifp: new interface to validate a certificate
Action: opened
PR body:
"""
New interface to validate a certificate. The input is the certificate to validate and the
output the user path.
It also contains the integration test to check the interface that validates the user
certificate.
Resolves: https://github.com/SSSD/sssd/issues/5851
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5852/head:pr5852
git checkout pr5852
4:32 a.m.
New subject: [sssd PR#5852][synchronized] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Author: ikerexxe
Title: #5852: ifp: new interface to validate a certificate
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5852/head:pr5852
git checkout pr5852
4:36 a.m.
New subject: [sssd PR#5852][synchronized] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Author: ikerexxe
Title: #5852: ifp: new interface to validate a certificate
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5852/head:pr5852
git checkout pr5852
4:36 a.m.
New subject: [sssd PR#5852][edited] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Author: ikerexxe
Title: #5852: ifp: new interface to validate a certificate
Action: edited
Changed field: body
Original value:
"""
New interface to validate a certificate. The input is the certificate to validate and the
output the user path.
It also contains the integration test to check the interface that validates the user
certificate.
Resolves: https://github.com/SSSD/sssd/issues/5851
"""
5:25 a.m.
New subject: [sssd PR#5852][+Bugzilla] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
Label: +Bugzilla
5:25 a.m.
New subject: [sssd PR#5852][+Waiting for review] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
Label: +Waiting for review
10:04 a.m.
New subject: [sssd PR#5852][synchronized] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Author: ikerexxe
Title: #5852: ifp: new interface to validate a certificate
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5852/head:pr5852
git checkout pr5852
10:12 a.m.
New subject: [sssd PR#5852][synchronized] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Author: ikerexxe
Title: #5852: ifp: new interface to validate a certificate
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5852/head:pr5852
git checkout pr5852
10:28 a.m.
New subject: [sssd PR#5852][synchronized] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Author: ikerexxe
Title: #5852: ifp: new interface to validate a certificate
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5852/head:pr5852
git checkout pr5852
6:30 a.m.
New subject: [sssd PR#5852][comment] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
ikerexxe commented:
"""
Hi @martinpitt can you review the latest changes that I made taking into account your
feedback?
"""
See the full comment at https://github.com/SSSD/sssd/pull/5852#issuecomment-960681209
8:51 a.m.
New subject: [sssd PR#5852][+Changes requested] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
Label: +Changes requested
8:51 a.m.
New subject: [sssd PR#5852][-Waiting for review] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
Label: -Waiting for review
10:35 a.m.
New subject: [sssd PR#5852][synchronized] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Author: ikerexxe
Title: #5852: ifp: new interface to validate a certificate
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5852/head:pr5852
git checkout pr5852
10:40 a.m.
New subject: [sssd PR#5852][-Changes requested] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
Label: -Changes requested
10:40 a.m.
New subject: [sssd PR#5852][+Waiting for review] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
Label: +Waiting for review
10:41 a.m.
New subject: [sssd PR#5852][comment] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
ikerexxe commented:
"""
Thanks @pbrezina. I've tackled your comments and the PR is ready for another round of
reviews.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5852#issuecomment-961166940
5:43 a.m.
New subject: [sssd PR#5852][comment] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
pbrezina commented:
"""
```
/home/pbrezina/workspace/sssd/src/responder/ifp/ifp_users.c: In function
‘p11_child_exec’:
/home/pbrezina/workspace/sssd/src/responder/ifp/ifp_users.c:1216:57: error: passing
argument 3 of ‘child_handler_setup’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
1216 | ret = child_handler_setup(state->ev, child_pid,
ifp_users_find_by_valid_cert_done,
|
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| struct tevent_req *
(*)(int, struct tevent_signal *, void *)
In file included from /home/pbrezina/workspace/sssd/src/responder/ifp/ifp_users.c:29:
/home/pbrezina/workspace/sssd/src/util/child_common.h:86:46: note: expected
‘sss_child_callback_t’ {aka ‘void (*)(int, struct tevent_signal *, void *)’} but argument
is of type ‘struct tevent_req * (*)(int, struct tevent_signal *, void *)’
86 | sss_child_callback_t cb, void *pvt,
| ~~~~~~~~~~~~~~~~~~~~~^~
```
"""
See the full comment at https://github.com/SSSD/sssd/pull/5852#issuecomment-961791713
6:42 a.m.
New subject: [sssd PR#5852][+Changes requested] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
Label: +Changes requested
6:42 a.m.
New subject: [sssd PR#5852][-Waiting for review] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
Label: -Waiting for review
6:47 a.m.
New subject: [sssd PR#5852][synchronized] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Author: ikerexxe
Title: #5852: ifp: new interface to validate a certificate
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5852/head:pr5852
git checkout pr5852
9:49 a.m.
New subject: [sssd PR#5852][synchronized] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Author: ikerexxe
Title: #5852: ifp: new interface to validate a certificate
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5852/head:pr5852
git checkout pr5852
9:50 a.m.
New subject: [sssd PR#5852][comment] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
ikerexxe commented:
"""
I've changed the `ifp_users_find_by_valid_cert_done()` a bit so I think you should
review it again.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5852#issuecomment-961957664
9:53 a.m.
New subject: [sssd PR#5852][+Waiting for review] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
Label: +Waiting for review
9:53 a.m.
New subject: [sssd PR#5852][-Changes requested] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
Label: -Changes requested
4:32 a.m.
New subject: [sssd PR#5852][+Changes requested] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
Label: +Changes requested
4:32 a.m.
New subject: [sssd PR#5852][-Waiting for review] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
Label: -Waiting for review
5:28 a.m.
New subject: [sssd PR#5852][synchronized] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Author: ikerexxe
Title: #5852: ifp: new interface to validate a certificate
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5852/head:pr5852
git checkout pr5852
5:29 a.m.
New subject: [sssd PR#5852][-Changes requested] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
Label: -Changes requested
5:29 a.m.
New subject: [sssd PR#5852][+Waiting for review] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
Label: +Waiting for review
5:29 a.m.
New subject: [sssd PR#5852][comment] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
ikerexxe commented:
"""
The patches are ready for another round of review.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5852#issuecomment-963060408
5:54 a.m.
New subject: [sssd PR#5852][comment] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
pbrezina commented:
"""
Ack. Thank you. Can you just add a release note to the commit message?
"""
See the full comment at https://github.com/SSSD/sssd/pull/5852#issuecomment-963077426
6:03 a.m.
New subject: [sssd PR#5852][synchronized] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Author: ikerexxe
Title: #5852: ifp: new interface to validate a certificate
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5852/head:pr5852
git checkout pr5852
6:03 a.m.
New subject: [sssd PR#5852][comment] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
ikerexxe commented:
"""
Ack. Thank you. Can you just add a release note to the commit
message?
Done. Thanks for the review!
"""
See the full comment at https://github.com/SSSD/sssd/pull/5852#issuecomment-963083749
6:17 a.m.
New subject: [sssd PR#5852][comment] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
pbrezina commented:
"""
Better make it `:feature:` and add more information. Imagine that you read it as our user
- you want to now how the method is called and what you should use it for.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5852#issuecomment-963095261
6:18 a.m.
New subject: [sssd PR#5852][comment] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
pbrezina commented:
"""
Better make it `:feature:` and add more information. Imagine that you read it as our user
- you want to now how the method is called and what you should use it for. One sentence
that should catch the essence of the change.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5852#issuecomment-963095261
7:33 a.m.
New subject: [sssd PR#5852][comment] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
ikerexxe commented:
"""
Better make it `:feature:` and add more information. Imagine that you
read it as our user - you want to now how the method is called and what you should use it
for. One sentence that should catch the essence of the change.
What do you think of `:feature: New infopipe interface to validate a user certificate,
that accepts the certificate as an input and outputs the user path.`?
"""
See the full comment at https://github.com/SSSD/sssd/pull/5852#issuecomment-963155213
7:43 a.m.
New subject: [sssd PR#5852][comment] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
martinpitt commented:
"""
How about something like this:
New infopipe method `FindByValidCertificate()` which accepts the
certificate as input, validates it against configured CAs, and outputs the user path on
success. This is similar to the existing `FindByCertificate()`, but that does not do any
trust validation.
(Not sure how long your release notes are allowed to be)
"""
See the full comment at https://github.com/SSSD/sssd/pull/5852#issuecomment-963162874
9:25 a.m.
New subject: [sssd PR#5852][comment] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
pbrezina commented:
"""
Martin's version is better. Especially because it contains the method name and the
difference between current method.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5852#issuecomment-963268735
10:33 a.m.
New subject: [sssd PR#5852][synchronized] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Author: ikerexxe
Title: #5852: ifp: new interface to validate a certificate
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5852/head:pr5852
git checkout pr5852
10:34 a.m.
New subject: [sssd PR#5852][comment] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
ikerexxe commented:
"""
Thanks Martin! I've added that to the release notes.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5852#issuecomment-963343546
10:41 a.m.
New subject: [sssd PR#5852][-Waiting for review] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
Label: -Waiting for review
10:41 a.m.
New subject: [sssd PR#5852][+Ready to push] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
Label: +Ready to push
10:41 a.m.
New subject: [sssd PR#5852][+Accepted] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
Label: +Accepted
4:08 a.m.
New subject: [sssd PR#5852][comment] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5852
* `master`
* 50e6070e4784e4a9a01ce26bd08229a07557948a - Tests: ifp interface to validate
certificate
* cf75d897b8ef03fdc471059214e86824f19b1bd1 - ifp: new interface to validate a
certificate
"""
See the full comment at https://github.com/SSSD/sssd/pull/5852#issuecomment-963999653
4:08 a.m.
New subject: [sssd PR#5852][+Pushed] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
Label: +Pushed
4:08 a.m.
New subject: [sssd PR#5852][-Accepted] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
Label: -Accepted
4:08 a.m.
New subject: [sssd PR#5852][-Ready to push] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Title: #5852: ifp: new interface to validate a certificate
Label: -Ready to push
4:08 a.m.
New subject: [sssd PR#5852][closed] ifp: new interface to validate a certificate
URL: https://github.com/SSSD/sssd/pull/5852
Author: ikerexxe
Title: #5852: ifp: new interface to validate a certificate
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5852/head:pr5852
git checkout pr5852
893
days inactive
904
days old
sssd-devel@lists.fedorahosted.org
47 comments
3 participants
participants (3)
-
ikerexxe -
martinpitt
-
pbrezina